vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-02-03 23:42:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Plugins: Avoid stomping of some variables in wp-settings.php.

Browse Source 
This changeset decreases the chance of accidentally overwriting some variables located in `wp-settings.php`, as the chance of overriding a variable called `$_wp_plugin_file` would be lower than for `$plugin`, `$mu_plugin` or `$network_plugin`.

Props stevegrunwell, joyously, peterwilsoncc, ocean90, SergeyBiryukov, jrf, azouamauriac.
Fixes #55432.


git-svn-id: https://develop.svn.wordpress.org/trunk@53004 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Jb Audras 2022-03-28 13:57:08 +00:00
parent d0bb319a81
commit f1e285c907
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/wp-settings.php
View File

@ -346,7 +346,9 @@ $GLOBALS['wp_plugin_paths'] = array();
// Load must-use plugins.
foreach ( wp_get_mu_plugins() as $mu_plugin ) {
$_wp_plugin_file = $mu_plugin;
include_once $mu_plugin;
$mu_plugin = $_wp_plugin_file; // Avoid stomping of the $mu_plugin variable in a plugin.
/**
* Fires once a single must-use plugin has loaded.
@ -357,13 +359,16 @@ foreach ( wp_get_mu_plugins() as $mu_plugin ) {
*/
do_action( 'mu_plugin_loaded', $mu_plugin );
}
unset( $mu_plugin );
unset( $mu_plugin, $_wp_plugin_file );
// Load network activated plugins.
if ( is_multisite() ) {
foreach ( wp_get_active_network_plugins() as $network_plugin ) {
wp_register_plugin_realpath( $network_plugin );
$_wp_plugin_file = $network_plugin;
include_once $network_plugin;
$network_plugin = $_wp_plugin_file; // Avoid stomping of the $network_plugin variable in a plugin.
/**
* Fires once a single network-activated plugin has loaded.
@ -374,7 +379,7 @@ if ( is_multisite() ) {
*/
do_action( 'network_plugin_loaded', $network_plugin );
}
unset( $network_plugin );
unset( $network_plugin, $_wp_plugin_file );
}
/**
@ -415,7 +420,10 @@ if ( ! is_multisite() ) {
// Load active plugins.
foreach ( wp_get_active_and_valid_plugins() as $plugin ) {
wp_register_plugin_realpath( $plugin );
$_wp_plugin_file = $plugin;
include_once $plugin;
$plugin = $_wp_plugin_file; // Avoid stomping of the $plugin variable in a plugin.
/**
* Fires once a single activated plugin has loaded.
@ -426,7 +434,7 @@ foreach ( wp_get_active_and_valid_plugins() as $plugin ) {
*/
do_action( 'plugin_loaded', $plugin );
}
unset( $plugin );
unset( $plugin, $_wp_plugin_file );
// Load pluggable functions.
require ABSPATH . WPINC . '/pluggable.php';