vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-30 23:30:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Twenty Nineteen: Fix markup errors in twentynineteen_add_ellipses_to_nav():

Browse Source 
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.

Props afercia, chetan200891, ianbelanger.
Fixes #47067.

git-svn-id: https://develop.svn.wordpress.org/trunk@45596 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2019-07-04 09:22:17 +00:00
parent 2aeab4216e
commit fdc5010ba3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/wp-content/themes/twentynineteen/inc/template-functions.php
View File

@@ -206,12 +206,12 @@ function twentynineteen_add_ellipses_to_nav( $nav_menu, $args ) {
<div class="main-menu-more">
<ul class="main-menu">
<li class="menu-item menu-item-has-children">
<button class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1" aria-label="More" aria-haspopup="true" aria-expanded="false">
<span class="screen-reader-text">' . esc_html__( 'More', 'twentynineteen' ) . '</span>' .
<button class="submenu-expand main-menu-more-toggle is-empty" tabindex="-1"
aria-label="' . esc_attr__( 'More', 'twentynineteen' ) . '" aria-haspopup="true" aria-expanded="false">' .
twentynineteen_get_icon_svg( 'arrow_drop_down_ellipsis' ) . '
</button>
<ul class="sub-menu hidden-links">
<li id="menu-item--1" class="mobile-parent-nav-menu-item menu-item--1">
<li class="mobile-parent-nav-menu-item">
<button class="menu-item-link-return">' .
twentynineteen_get_icon_svg( 'chevron_left' ) .
esc_html__( 'Back', 'twentynineteen' ) . '