Commit Graph
11153 Commits
Author SHA1 Message Date
Jonathan Desrosiers 9b160263da Users: Ensure reset password emails are in the receiving user’s locale.
This ensures that reset password emails initiated by an administrator are sent to the user in their preferred locale.

Follow up to [50129,50139-50141,50152].

Props chouby, davidbaumwald, audrasjb, johnbillion.
Fixes #52605. See #34281.

git-svn-id: https://develop.svn.wordpress.org/trunk@50415 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-23 16:37:01 +00:00
Peter Wilson db9c95a056 Security: move Content-Security-Policy script loaders.
Move `wp_get_script_tag()`, `wp_print_script_tag()`, `wp_print_inline_script_tag()` and `wp_get_inline_script_tag()` functions from `functions.php` to `script-loader.php`.

Relocate related tests to `dependencies` sub-directory.

Follow up to [50167].
Props adamsilverstein, hellofromTonya, SergeyBiryukov.
Fixes #39941.


git-svn-id: https://develop.svn.wordpress.org/trunk@50409 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-23 01:58:21 +00:00
Peter Wilson 50639dbad6 Script Loader: Prevent wp_localize_script() warnings.
Prevent `wp_localize_script()` (via `WP_Scripts::localize()`) throwing warnings in PHP 8 when the translation data is passed as a string. This maintains backward compatibility with earlier versions of PHP.

Introduce a `_doing_it_wrong()` notice to `WP_Scripts::localize()` if the translation data is not passed as an array.

Props jrf, peterwilsoncc, SergeyBiryukov.
Fixes #52534.


git-svn-id: https://develop.svn.wordpress.org/trunk@50408 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-22 23:21:56 +00:00
Sergey Biryukov aaf3fc57fc Docs: Document the usage of $pagenow global in a few functions.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50407 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-22 19:16:07 +00:00
Sergey Biryukov cebbabbe21 Media: Explicitly declare the $pagenow global in wp_get_attachment_url().
This avoids an "Undefined index" PHP notice in the function when running the `media` test group separately.

Follow-up to [32342], [50156], [50164], [50393].

Props johnbillion.
Fixes #52606.

git-svn-id: https://develop.svn.wordpress.org/trunk@50406 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-22 18:53:11 +00:00
Sergey Biryukov 6479ea9af8 Embeds: Allow posts with a public custom post status to be embedded.
Previously, only posts with the `publish` status could be embedded.

Props goaroundagain, peterwilsoncc, poena.
Fixes #47574.

git-svn-id: https://develop.svn.wordpress.org/trunk@50401 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-22 13:21:26 +00:00
Robert Anderson 04b26cf226 Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 RC 1.

Fixes #52588.


git-svn-id: https://develop.svn.wordpress.org/trunk@50400 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-22 06:02:34 +00:00
Sergey Biryukov 3d8ea574c5 External Libraries: Upgrade PHPMailer to version 6.3.0.
This is a maintenance release. Changes include:

* Handle early connection errors such as 421 during connection and EHLO states.
* Make the `mail()` and sendmail transports set the envelope sender the same way as SMTP does, i.e. use whatever `From` is set to, only falling back to the `sendmail_from` php.ini setting if `From` is unset. This avoids errors from the `mail()` function if `Sender` is not set explicitly and php.ini is not configured. This is a minor functionality change, so bumps the minor version number.
* Extend `parseAddresses` to decode encoded names.

Release notes: https://github.com/PHPMailer/PHPMailer/releases/tag/v6.3.0

For a full list of changes in this update, see the PHPMailer GitHub:
https://github.com/PHPMailer/PHPMailer/compare/v6.2.0...v6.3.0

Props ayeshrajans.
Fixes #52577.

git-svn-id: https://develop.svn.wordpress.org/trunk@50397 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-21 09:32:41 +00:00
John Blackbourn 66504ce36e Posts, Post Types: Rename the new post parent conditional tag functions for clarity.
* `get_parent_post()` becomes `get_post_parent()`
* `has_parent_post()` becomes `has_post_parent()`

Props johnjamesjacoby, SergeyBiryukov, lukecarbis, peterwilsoncc

Fixes #33045


git-svn-id: https://develop.svn.wordpress.org/trunk@50396 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-20 17:43:55 +00:00
John Blackbourn 9ab39e3363 Docs: Various docblock corrections and improvements.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@50395 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-20 17:08:24 +00:00
John Blackbourn 3f705da1f2 Cron API: Add a missing $wp_error parameter to the pre_reschedule_event filter.
Props tmatsuur, mukesh27

Fixes #52572
See #49961


git-svn-id: https://develop.svn.wordpress.org/trunk@50394 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-20 12:09:45 +00:00
Sergey Biryukov 24f0d03a6c Script Loader: Explicitly declare the $pagenow global in wp_deregister_script().
This avoids an "Undefined index" PHP notice in `wp_resource_hints()` tests when running the full test suite.

Remove the unused global from `get_home_url()`.

Follow-up to [25443], [38100], [38174], [50156], [50164].

Props peterwilsoncc.
Fixes #52566.

git-svn-id: https://develop.svn.wordpress.org/trunk@50393 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-20 09:53:48 +00:00
Felix Arntz c8bbd79d2d Security: Fix bug in wp_is_local_html_output().
Prior to this changeset, the check for the correct RSD link output was relying on a specific protocol, although it needs to accept both the HTTP and HTTPS version of the URL.

Props TimothyBlynJacobs.
Fixes #52542. See #47577.


git-svn-id: https://develop.svn.wordpress.org/trunk@50391 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-19 21:11:02 +00:00
Sergey Biryukov d1c40e9a3d Taxonomy: Optimize wp_delete_term() for large object counts without a default term.
When deleting a term, it has to be removed individually from each object it's connected to, which can take some significant time when there are a lot of objects.

By calling `wp_remove_object_terms()` when no default term is required, we can skip the terms fetch/diff step and significantly speed up the deletion process.

Props dd32.
Fixes #52549.

git-svn-id: https://develop.svn.wordpress.org/trunk@50389 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-19 14:29:29 +00:00
Peter Wilson 50af962653 Posts/Post Types: Prevent duplicates in sticky posts option.
In `unstick_post()` if a post ID is duplicated in the `sticky_posts` option remove all instances.

In both `stick_post()` and `unstick_post()` check for duplicate IDs already stored in the `sticky_post` option and remove them if the option is updated.

Props rahmohn, archon810.
Fixes #52007.


git-svn-id: https://develop.svn.wordpress.org/trunk@50380 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 22:56:34 +00:00
John Blackbourn 910c2db68a Comments: Revert the introduction of the opt-in comment approval notification feature.
This reverts the following commits: [50113], [50112], [50109].

See #33717


git-svn-id: https://develop.svn.wordpress.org/trunk@50375 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 13:06:43 +00:00
Sergey Biryukov e49c3c7f18 Docs: Correct the type of $widget_id argument in is_active_widget().
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50372 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 11:46:35 +00:00
Sergey Biryukov 135d567399 Robots: Rename wp_embed_no_robots to wp_robots_noindex_embeds().
This brings the naming in line with `wp_robots_noindex_search()`.

Follow-up to [49992], [50370].

See #51511, #52457.

git-svn-id: https://develop.svn.wordpress.org/trunk@50371 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-17 10:49:13 +00:00
Peter Wilson f400eb5ab9 General: Add noindex robots meta tag to search results.
Prevent search engines indexing internal search results to protect against reflected web spam attacks.

Props abagtcs, audrasjb, ayeshrajans, burtrw, johnbillion, jonoaldersonwp, peterwilsoncc, poena, sabernhardt, xkon.
Fixes #52457


git-svn-id: https://develop.svn.wordpress.org/trunk@50370 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 23:36:44 +00:00
John Blackbourn 6299c30506 Post WordPress 5.7 Beta 3 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@50369 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 21:18:06 +00:00
John Blackbourn 21c5666fce WordPress 5.7 beta 3.
git-svn-id: https://develop.svn.wordpress.org/trunk@50368 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 20:55:10 +00:00
John Blackbourn 22618cef9a Feeds: Fix the URL returned by get_feed_link() when pretty permalinks are not in use.
Props hauvong, peterwilsoncc, SergeyBiryukov

Fixes #51839


git-svn-id: https://develop.svn.wordpress.org/trunk@50354 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:32:58 +00:00
Sergey Biryukov 8bd8ead1da XML-RPC: Pass the method arguments and the XML-RPC server instance to the xmlrpc_call action.
This provides better context and makes the action easier to use when the call passes specific content in the payload of the request.

Props dd32.
Fixes #52524.

git-svn-id: https://develop.svn.wordpress.org/trunk@50353 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 17:01:46 +00:00
Joe Dolson 4e4837d9b1 Media: Associate upload errors and field with controls.
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.

Props afercia, anevins, antpb, adamsilverstein, poena
Fixes #47120

git-svn-id: https://develop.svn.wordpress.org/trunk@50352 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-16 04:03:37 +00:00
Riad Benguella 9cab116980 Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
The updated packages are:

@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7

Props isabel_brison.
Fixes #52525.


git-svn-id: https://develop.svn.wordpress.org/trunk@50343 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-15 08:27:50 +00:00
Dominik Schilling 93e961bd76 Docs: Improve parameter types for various URL functions and filters that also accept null.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50340 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-13 15:15:00 +00:00
Peter Wilson a55a9183bc Site Health: Update site-health script dependencies.
Add `wp-hooks` and `wp-i18n` to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes #52483.


git-svn-id: https://develop.svn.wordpress.org/trunk@50294 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-12 00:08:16 +00:00
Peter Wilson f9b901549b Canonical: Rename wp_force_plain_ugly_permalink() to match UI terminology.
Rename `wp_force_plain_ugly_permalink()` to `wp_force_plain_post_permalink()` to match terminology used in the WordPress dashboard.

Follow up to [50132].
Props SergeyBiryukov.
Fixes #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@50282 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-10 05:38:23 +00:00
Jonathan Desrosiers 26b3fa70a3 Post WordPress 5.7 Beta 2 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@50281 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 20:38:37 +00:00
Jonathan Desrosiers c351ffcb1c WordPress 5.7 Beta 2.
git-svn-id: https://develop.svn.wordpress.org/trunk@50280 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 20:24:56 +00:00
Kelly Choyce-Dwan a25e5988dd Administration: Update color contrast on UI elements.
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.

Follow-up to [50025].
Props audrasjb, joedolson.
Fixes #52402.



git-svn-id: https://develop.svn.wordpress.org/trunk@50278 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 19:45:47 +00:00
Anthony Burchell 5f2d089fb3 Media: Make adjacent_image_link() include alt text when returning an image.
When using the `adjacent_image_link()` function there is a condition that will return a linked image. Previously, the returned image was sent without alt attributes.

Now, `adjacent_image_link()` will include alt attributes of the image's title when an image is returned.

Props joedolson, Mista-Flo, sabernhardt.
Fixes #52387.


git-svn-id: https://develop.svn.wordpress.org/trunk@50274 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 17:25:18 +00:00
Sergey Biryukov 0ff5b67127 Site Health: Link to the support article on troubleshooting in "There has been a critical error" message.
This page is more geared towards users than the one on debugging, which is more developer-oriented.

Props audrasjb, Clorith, Ipstenu.
Fixes #52392.

git-svn-id: https://develop.svn.wordpress.org/trunk@50272 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 16:57:06 +00:00
John Blackbourn 22cd0a3b9e Comments: Extend the duration of the window within which unapproved comments are visible by their author.
This extension is necessary because the comment approval notification opt-in form introduced in [47887] uses the same mechanism, and the previous limit of one minute meant that users on a slow connection, using assistive technology, with limited motor skills, or who are generally indecisive may not complete the opt-in action within one minute, and therefore not see the confirmation message.

Props joedolson, imath, hellofromTonya, peterwilsoncc, alexstine, davidbaumwald 

Fixes #52406


git-svn-id: https://develop.svn.wordpress.org/trunk@50271 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 16:55:29 +00:00
John Blackbourn f0e3ab49b3 Posts, Post Types: Clarify the documentation about the return value of get_post() when a falsey value is passed.
Props Rahe, juliobox, peterwilsoncc, hellofromTonya, audrasjb

Fixes #33068


git-svn-id: https://develop.svn.wordpress.org/trunk@50266 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 13:42:58 +00:00
Sergey Biryukov a4cb795001 Docs: Update some recently added inline comments per the documentation standards.
Follow-up to [50256], [50258], [50259].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50264 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-09 12:32:54 +00:00
Robert Anderson 385c29b49a Fix wp.i18n.isRTL()
Fixes a bug causing wp.i18n.isRTL() to return false in RTL langauges by manually
loading the translated 'ltr' string for the i18n dependency. This ports over an
identical fix that was made in Gutenberg.

Fixes #52441.
Props @jonsurrell @youknowriad.


git-svn-id: https://develop.svn.wordpress.org/trunk@50259 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 23:49:33 +00:00
Peter Wilson 2e23c29603 Posts/Post Types: Improve documentation of get_posts().
Add references to `WP_Query` to the documentation of `get_posts()`. As the developer documentation for `WP_Query` includes an expanded explanation a full link to developer.wordpress.org is included rather than a standard `@see`.

Props dam6pl, peterwilsoncc.
See #51852, #51800.



git-svn-id: https://develop.svn.wordpress.org/trunk@50257 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 22:50:36 +00:00
Sergey Biryukov c3dd52264d Docs: Clarify the @return value for wp_get_attachment_image_url() and get_the_post_thumbnail_url().
Props GeekPress, audrasjb, naveen17797.
Fixes #52183.

git-svn-id: https://develop.svn.wordpress.org/trunk@50236 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 14:12:21 +00:00
Robert Anderson a8179897a2 Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 beta 2.

Fixes #52467.


git-svn-id: https://develop.svn.wordpress.org/trunk@50235 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-08 03:34:31 +00:00
Sergey Biryukov ef0a312dc1 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Adjust some newly introduced strings to remove unnecessary numbered placeholders for consistency.

Follow-up to [42827].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50234 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-07 12:42:06 +00:00
Sergey Biryukov a07d734d77 Docs: Use typed array notation in the update_post_term_count_statuses filter DocBlock.
Follow-up to [50169].

See #38843.

git-svn-id: https://develop.svn.wordpress.org/trunk@50231 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 19:11:15 +00:00
Sergey Biryukov 73b353ef95 Privacy: Rename the $send_confirmation_email parameter of wp_create_user_request() to $status, for clarity.
Follow-up to [50159], [50165].

Props xkon, TimothyBlynJacobs.
Fixes #52430. See #43890.

git-svn-id: https://develop.svn.wordpress.org/trunk@50230 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-05 15:48:59 +00:00
Sergey Biryukov c17cc1def2 Docs: Consistently document the default value for $args parameter in various cron functions.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@50175 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-03 11:06:39 +00:00
Sergey Biryukov 7d0367b851 Docs: Add a @since note to wp_clear_scheduled_hook() for the $wp_error parameter.
Follow-up to [50143].

See #49961.

git-svn-id: https://develop.svn.wordpress.org/trunk@50174 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-03 10:56:39 +00:00
Sergey Biryukov 3c3590103a Post WordPress 5.7 Beta 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@50172 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 22:21:52 +00:00
Sergey Biryukov 2f8657c858 WordPress 5.7 Beta 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@50171 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 22:04:54 +00:00
Anthony Burchell 26fb7c9682 Media: Consistency in logic to pass wp_getimagesize() tests.
Previously, we used `DIR_TESTDATA` to determine if a test should skip a newly silenced error in `wp_getimagesize()`.

We are now using `WP_RUN_CORE_TESTS` instead for consistency.

Props hellofromTonya, SergeyBiryukov.
See #49889.


git-svn-id: https://develop.svn.wordpress.org/trunk@50170 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 21:34:40 +00:00
Anthony Burchell 422c2c4ad2 Taxonomy: Add filter for post statuses when updating term count.
This adds a filter that allows `$post_statuses` to be modified in term count.

Props GunGeekATX, adamsilverstein, davecpage, nwjames, hellofromTonya, audrasjb, peterwilsoncc, TimothyBlynJacobs.
Fixes #38843.


git-svn-id: https://develop.svn.wordpress.org/trunk@50169 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 21:04:58 +00:00
Sergey Biryukov 6221b8a744 General: Remove admin exception for https in network_home_url().
Previously, `network_home_url()` would automatically switch to `https` if the current request is already `https`, but would only do so on the front end.

This mirrors the change made earlier for `get_home_url()`.

Follow-up to [12598], [21937], [24844], [50156].
See #52421.

git-svn-id: https://develop.svn.wordpress.org/trunk@50168 602fd350-edb4-49c9-b593-d223f7449a82
2021-02-02 20:57:31 +00:00