Commit Graph
100 Commits
Author SHA1 Message Date
Ryan Boren cfd5c395bb The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.


git-svn-id: https://develop.svn.wordpress.org/trunk@26851 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-11 19:48:29 +00:00
Ryan Boren 85d5a58809 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries.
Props adamsilverstein, nacin
fixes #25963


git-svn-id: https://develop.svn.wordpress.org/trunk@26767 602fd350-edb4-49c9-b593-d223f7449a82
2013-12-07 03:10:44 +00:00
Ryan Boren 30f822b8ee Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25880 602fd350-edb4-49c9-b593-d223f7449a82
2013-10-23 14:37:54 +00:00
Ryan Boren 71793b661c Don't show the "Get Shortlink" button for pages with a ?page_id=x permalink.
Props sillybean
fixes #14760


git-svn-id: https://develop.svn.wordpress.org/trunk@25122 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-26 16:05:46 +00:00
Ryan Boren c8889d984f Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@25085 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-22 15:55:07 +00:00
Ryan Boren 5125650b72 Be consistent with the arguments passed to the theme_action_links filter. Stop passing stylesheet from class-wp-ms-themes-list-table.php.
Props georgestephanis
fixes #24478


git-svn-id: https://develop.svn.wordpress.org/trunk@25032 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-16 15:46:08 +00:00
Ryan Boren 17267dd999 wp_get_shortlink() improvements.
* Return shortlinks for pages and public CPTs.
* Return shortlinks even when cruft-free links are not enabled.
* Unit tests

Props sillybean, layotte, cais
fixes #18632
see #14760



git-svn-id: https://develop.svn.wordpress.org/trunk@25030 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-15 20:08:06 +00:00
Ryan Boren b04c19df69 phpdoc for $wp_admin_bar in admin-bar.php
Props jeremyfelt
see #24900


git-svn-id: https://develop.svn.wordpress.org/trunk@24999 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 19:23:00 +00:00
Ryan Boren 3f89738bb5 Remove 'admin' as default username in install.
Props chrisrudzki
fixes #24078


git-svn-id: https://develop.svn.wordpress.org/trunk@24998 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 19:04:32 +00:00
Ryan Boren ca59c0127b Return true from wp_redirect() when redirect successful. Update phpdoc.
Props tivnet
fixes #24969


git-svn-id: https://develop.svn.wordpress.org/trunk@24996 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 17:44:32 +00:00
Ryan Boren 11d7fe1eaf Silence is_dir() to avoud warning when upload_tmp_dir is outside open_basedir.
Props dpash
fixes #24704


git-svn-id: https://develop.svn.wordpress.org/trunk@24995 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 17:39:33 +00:00
Ryan Boren d05c31d063 Set RTL body class for iframes.
Props mitchoyoshitaka
see #24149


git-svn-id: https://develop.svn.wordpress.org/trunk@24994 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 17:35:43 +00:00
Ryan Boren 98e65b8f77 Deprecate get_dashboard_blog().
Remove contextual help for Dashboard Site from the network settings screen.

Props sillybean, ocean90
fixes #24838


git-svn-id: https://develop.svn.wordpress.org/trunk@24993 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 16:07:46 +00:00
Ryan Boren 5d33941220 Bestow sentience upon users. Level up their pronoun.
Props johnbillion
fixes #24513


git-svn-id: https://develop.svn.wordpress.org/trunk@24992 602fd350-edb4-49c9-b593-d223f7449a82
2013-08-06 16:04:07 +00:00
Ryan Boren 57778b81b1 Introduce wp_style_add_data() as a wrapper for $wp_styles->add_data().
Props obenland, nacin
fixes #18753


git-svn-id: https://develop.svn.wordpress.org/trunk@24740 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 19:46:38 +00:00
Ryan Boren f32bc0c541 Fire wp_auth_check_load() from admin_enqueue_scripts instead of admin_init so that it can access the current screen object.
Black list the update and upgrade screens.

Allow plugins to white/black list screens via the wp_auth_check_load filter.

Props nacin

see #23295


git-svn-id: https://develop.svn.wordpress.org/trunk@24738 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 19:06:35 +00:00
Ryan Boren 5211399922 Allow absolute URLs in editor styles.
Props nacin, obenland
fixes #24787


git-svn-id: https://develop.svn.wordpress.org/trunk@24735 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-18 18:11:43 +00:00
Ryan Boren 2a4688c413 Fix editing images with GD when using streams.
Props rmccue, markoheijnen, nacin
fixes #24459


git-svn-id: https://develop.svn.wordpress.org/trunk@24727 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-17 21:16:44 +00:00
Ryan Boren 2093f293c7 Don't sync the blog public option from noindex(). This can cause race conditions.
fixes #23155


git-svn-id: https://develop.svn.wordpress.org/trunk@24559 602fd350-edb4-49c9-b593-d223f7449a82
2013-07-05 15:17:31 +00:00
Ryan Boren 33188fb613 Normalize the UTF-8 and ISO-8859-1 charset strings stored in blog_charset to make them friendlier with PHP functions that accept a charset such as htmlspecialchars().
fixes #23688


git-svn-id: https://develop.svn.wordpress.org/trunk@24510 602fd350-edb4-49c9-b593-d223f7449a82
2013-06-25 19:03:17 +00:00
Ryan Boren fcbfed2328 Introduce customize_save_after action.
Props dovyp, JustinSainton
fixes #24401


git-svn-id: https://develop.svn.wordpress.org/trunk@24344 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-24 10:33:30 +00:00
Ryan Boren 5f472898e5 Use the global post rather than the global post ID. They don't always match, and the global post is more canonical.
see #24330


git-svn-id: https://develop.svn.wordpress.org/trunk@24336 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-23 18:16:24 +00:00
Ryan Boren df26a7f97e In WP_User::get_data_by(), don't abs int negative IDs. Instead, return false when an ID less than 1 is passed.
Props nacin, mordauk
fixes #23480


git-svn-id: https://develop.svn.wordpress.org/trunk@24316 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-22 18:14:37 +00:00
Ryan Boren 687d1a2ce9 Pinking shears
git-svn-id: https://develop.svn.wordpress.org/trunk@24303 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-20 12:10:58 +00:00
Ryan Boren f1068cbe96 Add the Daily Motion shortlink, dai.ly, to the default oembed provider list.
Props georgestephanis
fixes #24353


git-svn-id: https://develop.svn.wordpress.org/trunk@24302 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-20 12:08:07 +00:00
Ryan Boren 2662748593 * Introduce wp_parse_post_content() and use it in setup_postdata(), get_the_content(), and get_the_remaining_content().
* Add a post ID argument to the_content(), get_the_content(), the_remaining_content(), and get_the_remaining_content().
* Pass the post ID to the the_content filter.
* Remove the format_pages global.
* Declare format_content and split_content as vars in WP_Post.
* phpdoc for the the_content filter that documents the new ID argument and denotes it as not-so-portable.

Props gcorne, DrewAPicture, duck_, aaroncampbell
see #24330


git-svn-id: https://develop.svn.wordpress.org/trunk@24301 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-20 11:05:50 +00:00
Ryan Boren 6f80083f14 Display the post format UI when there is structured data associated with the post regardless of the screen option.
Props kovshenin
see #24327


git-svn-id: https://develop.svn.wordpress.org/trunk@24282 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-17 15:12:50 +00:00
Ryan Boren 3506db6e1c Don't show both "update failed" and "update successful" messages when upgrading a theme fails due to connectivity problems.
Props SergeyBiryukov
fixes #23027


git-svn-id: https://develop.svn.wordpress.org/trunk@24276 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-16 12:46:36 +00:00
Ryan Boren a7b5385ccf Check for empty user agent to avoid notice.
Props sergej.mueller
fixes #22979


git-svn-id: https://develop.svn.wordpress.org/trunk@24275 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-16 12:06:36 +00:00
Ryan Boren 8ec3a3a34b Add default args list to wp_remote_request|get|post|head docblocks
Props DrewAPicture
fixes #23838


git-svn-id: https://develop.svn.wordpress.org/trunk@24250 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 14:00:19 +00:00
Ryan Boren de589f8ebe Remove redundant post ID validation.
Props SergeyBiryukov
fixes #24199


git-svn-id: https://develop.svn.wordpress.org/trunk@24249 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 13:57:59 +00:00
Ryan Boren dcd98293d1 Add the flickr shortlink, flic.kr, to the oEmbed default providers list.
Props Ipstenu
fixes #23052


git-svn-id: https://develop.svn.wordpress.org/trunk@24248 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 13:47:37 +00:00
Ryan Boren 9f3b5a4c4b Remove obsolete TODO.
Props wonderboymusic
fixes #11635


git-svn-id: https://develop.svn.wordpress.org/trunk@24247 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 12:44:44 +00:00
Ryan Boren fea88ce184 phpdoc improvements for wp_dashboard_quota()
Props DrewAPicture, h4ck3rm1k3


git-svn-id: https://develop.svn.wordpress.org/trunk@24246 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-14 12:37:30 +00:00
Ryan Boren edee280e39 Avoid warning in gallery_shortcode() when called outside of post context.
Props kovshenin
fixes #24272


git-svn-id: https://develop.svn.wordpress.org/trunk@24198 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-08 16:57:58 +00:00
Ryan Boren 63c3307f28 Update some copy in the Post Formats UI.
see #24227


git-svn-id: https://develop.svn.wordpress.org/trunk@24184 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-07 13:56:07 +00:00
Ryan Boren f5c165c23f Respect the link to setting when inserting a gallery.
Props SergeyBiryukov
fixes #23298


git-svn-id: https://develop.svn.wordpress.org/trunk@24161 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-02 22:07:37 +00:00
Ryan Boren e3d41d52ac Add Rdio to the default oembed providers list.
Props zekeweeks
fixes #24242


git-svn-id: https://develop.svn.wordpress.org/trunk@24160 602fd350-edb4-49c9-b593-d223f7449a82
2013-05-02 22:04:23 +00:00
Ryan Boren da23d9b7b8 Revert attachment.url back to props.url. Fixes error that prevents inserting media into the editor.
see #24046


git-svn-id: https://develop.svn.wordpress.org/trunk@24009 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-17 13:50:12 +00:00
Ryan Boren fc239715ca Use API instead of bare SQL queries in site-users.php.
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23974 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-12 13:35:45 +00:00
Ryan Boren c3e471a535 Use prepare() for the duplicate comment query in wp_allow_comment().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23973 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-12 13:25:16 +00:00
Ryan Boren c5e0ff6017 Update MediaElement.js to 2.11.0.
Props wonderboymusic
see #24015


git-svn-id: https://develop.svn.wordpress.org/trunk@23958 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-10 22:38:30 +00:00
Ryan Boren f69b7492e4 Allow turning off the post formats UI via a show_post_format_ui filter.
Props johnbillion
see #23929


git-svn-id: https://develop.svn.wordpress.org/trunk@23946 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-09 22:43:28 +00:00
Ryan Boren 131e90a91a _wp_preview_terms_filter() should be @since 3.6.0. Standardize on 3.6.0 instead of 3.6.
See #20564


git-svn-id: https://develop.svn.wordpress.org/trunk@23936 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-09 13:05:21 +00:00
Ryan Boren c0e42b5666 Preserve alpha in WP_Image_Editor_GD when images are not resized.
Props joehoyle
see #23039


git-svn-id: https://develop.svn.wordpress.org/trunk@23884 602fd350-edb4-49c9-b593-d223f7449a82
2013-04-01 15:21:19 +00:00
Ryan Boren 315f606306 Fire the update_blog_public action from update_blog_status() instead of update_blog_public(). Pass blog ID and value to the action.
Add code to noindex() to sync the 'public' value in the site options table with the blog_public value in the options table.

fixes #23155


git-svn-id: https://develop.svn.wordpress.org/trunk@23794 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-25 09:29:58 +00:00
Ryan Boren 806002166b In refresh_blog_details(), make sure clean_blog_cache() gets the blog ID when the blog has been previously cached as non-existent. This ensures that -1 values in blog-details are cleared after blogs are created.
Props beezeee, hirozed
fixes #23405


git-svn-id: https://develop.svn.wordpress.org/trunk@23752 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-19 05:05:19 +00:00
Ryan Boren 0da872a785 Clarify phpdoc for the vertical and horizontal arguments to the flip() method in WP_Image_Editor*.
Props dh-shredder
fixes #23775


git-svn-id: https://develop.svn.wordpress.org/trunk@23750 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-19 03:30:04 +00:00
Ryan Boren 01ca819c6f Make the before() and after() methods in Bulk_Plugin_Upgrader_Skin and Bulk_Theme_Upgrader_Skin declarations match Bulk_Upgrader_Skin. Eliminates strict standards warning.
Props charlestonsw
fixes #23807


git-svn-id: https://develop.svn.wordpress.org/trunk@23749 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-19 03:24:51 +00:00
Ryan Boren c920cfa3a0 RTL for Nav Menu tweaks. see #23641. see #23645. props DrewAPicture
git-svn-id: https://develop.svn.wordpress.org/trunk@23748 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-19 03:16:24 +00:00
Ryan Boren 1c2a9008c5 Make WP_Image_Editor::make_image() safe for replication plugins by making sure the directory for the image being made exists.
Props batmoo
fixes #23306


git-svn-id: https://develop.svn.wordpress.org/trunk@23744 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 18:05:23 +00:00
Ryan Boren 72c65a3145 Fix i18n for revision diff strings displaying human time.
Props johnbillion
fixes #23723


git-svn-id: https://develop.svn.wordpress.org/trunk@23743 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 17:58:30 +00:00
Ryan Boren 75dcc983d7 Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.
Props kovshenin
fixes #23426


git-svn-id: https://develop.svn.wordpress.org/trunk@23742 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 17:24:24 +00:00
Ryan Boren b16e4eaf58 Pass tag ID and args array to topic_count_text_callback from wp_generate_tag_cloud().
Props najamelan, toscho
fixes #21198


git-svn-id: https://develop.svn.wordpress.org/trunk@23741 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 17:17:55 +00:00
Ryan Boren 5cf0bc9be0 Bail early with correct WP_Error when an invalid post ID is passed to wp_insert_post() and wp_update_post().
Props simonwheatley
fixes #23474


git-svn-id: https://develop.svn.wordpress.org/trunk@23740 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 14:33:09 +00:00
Ryan Boren be67f3c550 Escape form action urls with esc_url() rather than esc_attr().
Props SergeyBiryukov
fixes #23266


git-svn-id: https://develop.svn.wordpress.org/trunk@23739 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 14:01:25 +00:00
Ryan Boren 18e3a300ab Remove old phpdoc that incorrectly marks wp_timezone_choice() as temporary.
Props danielbachhuber
fixes #23804


git-svn-id: https://develop.svn.wordpress.org/trunk@23738 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 13:35:34 +00:00
Ryan Boren f1a3189b22 Cleanup additional capabilities display in user-edit.php. Mark a string for translation.
Props johnjamesjacoby, SergeyBiryukov
fixes #14267


git-svn-id: https://develop.svn.wordpress.org/trunk@23737 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-18 13:27:57 +00:00
Ryan Boren ec09b27a71 Call them network upgrades rather than network updates to better indicate that they are DB upgrades rather than code/file upgrades.
Improve the contextual help for the Network Upgrade screen.

Props DrewAPicture
fixes #23540


git-svn-id: https://develop.svn.wordpress.org/trunk@23619 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-05 17:02:31 +00:00
Ryan Boren 6d2a8d2ef0 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23594 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 21:11:40 +00:00
Ryan Boren c61b68d896 Remove unnecessary stripslashes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23593 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 20:55:30 +00:00
Ryan Boren 6c3d30e58a In ms-functions.php, remove unnecessary slashing, don't strip the return of get_site_option, s/stripslashes*/wp_unslash/.
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23592 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 16:55:53 +00:00
Ryan Boren b78520da15 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #WP21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23591 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-03 16:30:38 +00:00
Ryan Boren 37fae23001 Always wp_unslash() the return of wp_get_referer().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23570 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:20:32 +00:00
Ryan Boren 436b32ef62 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: https://develop.svn.wordpress.org/trunk@23567 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:14:09 +00:00
Ryan Boren e737c7120e Use prepare instead of escape.
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23564 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:01:01 +00:00
Ryan Boren 4088ca8723 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23563 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 17:00:25 +00:00
Ryan Boren 206318aeca There is no need to strip the output of get_site_option().
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23556 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:37:24 +00:00
Ryan Boren 85782c3e39 Introduce wp_slash() and wp_unslash(). This will be used to cleanup the myriad calls to addslashes*, add_magic_quotes, stripslashes*. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23555 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:34:48 +00:00
Ryan Boren c363aea627 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: https://develop.svn.wordpress.org/trunk@23554 602fd350-edb4-49c9-b593-d223f7449a82
2013-03-01 16:28:40 +00:00
Ryan Boren a6c8efadb9 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: https://develop.svn.wordpress.org/trunk@23416 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-14 22:51:06 +00:00
Ryan Boren 77e5536195 Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.
Props westi
fixes #23448


git-svn-id: https://develop.svn.wordpress.org/trunk@23401 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-11 18:08:14 +00:00
Ryan Boren 51e5049575 In wp_get_archives(), cache queries to individual cache buckets instead of storing them in one cached array. Use incrementor style passive cache invalidation.
fixes #23206
see #23173


git-svn-id: https://develop.svn.wordpress.org/trunk@23385 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 13:54:15 +00:00
Ryan Boren 8b07ad9884 Use incrementors for cache invalidation in get_terms().
fixes #23326
see #23173


git-svn-id: https://develop.svn.wordpress.org/trunk@23384 602fd350-edb4-49c9-b593-d223f7449a82
2013-02-04 13:48:46 +00:00
Ryan Boren 7ff77d2e02 Avoid the appearance of a magic number.
Props nacin
see #23167


git-svn-id: https://develop.svn.wordpress.org/trunk@23320 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-22 15:52:13 +00:00
Ryan Boren 7442b3894b Explicitly set last_changed to 1 instead of the result of wp_cache_set(). Avoids ambiguity and works with cache backends that return void instead of boolean.
see #23167


git-svn-id: https://develop.svn.wordpress.org/trunk@23319 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-22 15:46:16 +00:00
Ryan Boren b8a9b92f54 Declare wp_rewrite as global in _wp_menu_item_classes_by_context().
Props andrewryno
fixes #7337


git-svn-id: https://develop.svn.wordpress.org/trunk@23309 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-21 14:44:30 +00:00
Ryan Boren 818251f59e Whitespace cleanup.
Props dimadin
fixes #23126


git-svn-id: https://develop.svn.wordpress.org/trunk@23308 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-21 14:39:39 +00:00
Ryan Boren bb70f60264 In get_pages(), cache queries to individual cache buckets instead of storing them in one cached array. Also, store post IDs instead of full objects. This reduces overall memory usage as well as the size of the cache buckets. Use incrementor style passive cache invalidation.
Props nprasath002
see #23167


git-svn-id: https://develop.svn.wordpress.org/trunk@23300 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-15 17:32:35 +00:00
Ryan Boren 006d5940cd Try not to send Last-Modified, even with an empty value. Some servers interpret an empty value as the epoch.
Props nacin, slene, SergeyBiryukov, andy
see #23021 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@23267 602fd350-edb4-49c9-b593-d223f7449a82
2013-01-04 19:51:31 +00:00
Ryan Boren 85b8c87a7e Introduce previous_image_link and next_image_link filters. Allows customizing the gallery display order.
Props nacin
fixes #22829 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@23139 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-09 19:54:23 +00:00
Ryan Boren 9575d68a6a Make current_user_can_for_blog() safe to run single site.
Props nacin, MarkJaquith
fixes #22803


git-svn-id: https://develop.svn.wordpress.org/trunk@23117 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 09:53:27 +00:00
Ryan Boren ce2720984b Extend allowed elements for object and embed.
Props azaozz
fixes #22790


git-svn-id: https://develop.svn.wordpress.org/trunk@23112 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-07 00:05:54 +00:00
Ryan Boren a0a13a3fc4 When inserting from URL in the media modal, retain query params and properly insert the caption code.
Props koopersmith
fixes #22796


git-svn-id: https://develop.svn.wordpress.org/trunk@23110 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-06 23:12:59 +00:00
Ryan Boren f549a8baa6 Fix uploads in IE9
Props koopersmith
fixes #22762


git-svn-id: https://develop.svn.wordpress.org/trunk@23079 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 21:21:17 +00:00
Ryan Boren 86203fa6bf Clear the From URL view in the media modal after inserting an image. Improve button enable checks.
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23065 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-05 04:43:51 +00:00
Ryan Boren e13e333569 When inserting an image From URL, show the fields only if it looks like we have a valid image.
Props koopersmith
fixes #22740


git-svn-id: https://develop.svn.wordpress.org/trunk@23048 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 23:07:41 +00:00
Ryan Boren 52b234de11 When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons.
Props azaozz, lessbloat
fixes #22717


git-svn-id: https://develop.svn.wordpress.org/trunk@23046 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 22:42:26 +00:00
Ryan Boren b5fdf3753f In the media modal, clear attachment details when clearing the selection.
Props koopersmith
fixes #22718


git-svn-id: https://develop.svn.wordpress.org/trunk@23045 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 22:19:08 +00:00
Ryan Boren 7e2df6dc07 Better dropdown select handling.
Props cdog, koopersmith
fixes #22693


git-svn-id: https://develop.svn.wordpress.org/trunk@23033 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 18:50:49 +00:00
Ryan Boren fa4b718809 Only show Delete in media modal if the user can delete.
Props nacin, koopersmith
fixes #22711


git-svn-id: https://develop.svn.wordpress.org/trunk@23032 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 18:33:51 +00:00
Ryan Boren eb3dc78a61 Media: Hide "Edit" link in the selection view when it doesn't make sense
Props koopersmith, ocean90, nacin
fixes #22713


git-svn-id: https://develop.svn.wordpress.org/trunk@23031 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 18:23:47 +00:00
Ryan Boren b5ae45fae3 Fix race condition in media insertion where the inserted html is invalid due to output being interleaved.
Props koopermsith
fixes #22696


git-svn-id: https://develop.svn.wordpress.org/trunk@23012 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 04:38:42 +00:00
Ryan Boren 00e20a52dc Final round of media UX improvements.
Props koopersmith
fixes #21390 #22502


git-svn-id: https://develop.svn.wordpress.org/trunk@23006 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-04 01:26:03 +00:00
Ryan Boren 608e95019d Properly set the base URL for the main site when ms-files rewriting is enabled for MU-era installs.
Props nacin
fixes #22702


git-svn-id: https://develop.svn.wordpress.org/trunk@23002 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 22:24:06 +00:00
Ryan Boren 5af1f254e4 No wrap for the attachment Delete Permanently link in the media modal.
Props SergeyBiryukov
fixes #22667


git-svn-id: https://develop.svn.wordpress.org/trunk@22998 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 19:49:45 +00:00
Ryan Boren ecb18ffc05 Increase the PHP memory_limit to WP_MAX_MEMORY_LIMIT in WP_Image_Editor_Imagick.
Props DH-Shredder
fixes #22699


git-svn-id: https://develop.svn.wordpress.org/trunk@22997 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 19:44:58 +00:00
Ryan Boren 71d333f660 In the QuickPress media modal, use the new post id when a post is published.
Props nacin, koopersmith
fixes #22673


git-svn-id: https://develop.svn.wordpress.org/trunk@22994 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 07:17:10 +00:00
Ryan Boren 594bbe90df When settting a featured image, move the currently selected image to the beginning of the library if it doesn't exist within the attachments loaded so far.
Props koopersmith
fixes #22494


git-svn-id: https://develop.svn.wordpress.org/trunk@22993 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 07:04:34 +00:00
Ryan Boren 7ad3d2410c Show a spinner when attachment details are saved.
Props koopersmith
see #22613


git-svn-id: https://develop.svn.wordpress.org/trunk@22991 602fd350-edb4-49c9-b593-d223f7449a82
2012-12-03 06:37:49 +00:00