Commit Graph
36065 Commits
Author SHA1 Message Date
Weston Ruter 1c84857edf Build/Test Tools: Facilitate SVN and Git being co-located in the same directory.
Ignore .svn in .gitignore, and ignore .git in svn:ignore.

Fixes #39245.


git-svn-id: https://develop.svn.wordpress.org/trunk@39577 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-12 05:11:27 +00:00
Dion Hulse de13e89608 Bootstrap: Re-initialize any hooks added manually by object-cache.php.
Prior to 3.1 if a object cache dropin wanted to add actions, they needed to use `$wp_filter` directly.

Props jorbin.
Fixes #39132.


git-svn-id: https://develop.svn.wordpress.org/trunk@39565 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-12 01:28:34 +00:00
Peter Wilson 7950b0e306 Options: Prevent unnecessary SQL updates by update_option.
Previously an option containing an object would trigger an SQL `UPDATE` on all calls to `update_option`, even if the old and new values were identical. This was due to the old and new values having differing resource IDs.

This change compares the old and new values as serialized data to remove the resource ID from the comparison.

Props salcode, bradyvercher, peterwilsoncc.
Fixes #38903.


git-svn-id: https://develop.svn.wordpress.org/trunk@39564 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-11 21:42:12 +00:00
Rachel Baker 260a88d009 REST API: Allow schema sanitization_callback to be set to null to bypass fallback sanitization functions.
The logic in WP_REST_Request->sanitize_params() added in [39091] did not account for `null` or `false` being the sanitization_callback preventing overriding `rest_parse_request_arg()`. This fixes that oversight, allowing the built in sanitization function to be bypassed. See #38593.

Props kkoppenhaver, rachelbaker, jnylen0.
Fixes #39042.


git-svn-id: https://develop.svn.wordpress.org/trunk@39563 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-11 21:25:40 +00:00
Weston Ruter 3a3ebc76a3 Customize: Fix ability to shift-click on placeholder/pre-saved nav menu items in preview to focus on corresponding control.
Fixes #39102.


git-svn-id: https://develop.svn.wordpress.org/trunk@39562 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 23:46:33 +00:00
Weston Ruter 1681d96a6d Customize: Deprecate page_home nav menu item starter content in favor of home_link; replace usage in Twenty Seventeen.
Props celloexpressions, westonruter.
Amends [38991].
See #38615, #38114.
Fixes #39104.


git-svn-id: https://develop.svn.wordpress.org/trunk@39561 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 23:38:04 +00:00
Weston Ruter e27098f5bd Customize: Trim whitespace for URLs supplied for external_header_video to prevent esc_url_raw() from making them invalid.
Props tyxla.
See #38172.
Fixes #39125.


git-svn-id: https://develop.svn.wordpress.org/trunk@39560 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 06:59:24 +00:00
Weston Ruter 0369dea1e4 Customize: Prevent single quotes (apostrophes) in custom_css values from unexpectedly causing false positives for unbalanced character validation errors.
See #39218, #35395.
Fixes #39198.


git-svn-id: https://develop.svn.wordpress.org/trunk@39559 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 06:45:00 +00:00
Weston Ruter be8caefd82 Customize: Fix inability to delete nav menus by preventing preview filters from being added during customize_save admin ajax request.
Also prevent setting `nav_menu_locations[...]` values to `NaN` which gets sent as `null`.

Amends [38810].
See #30937.
Fixes #39103.


git-svn-id: https://develop.svn.wordpress.org/trunk@39558 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 06:29:12 +00:00
Weston Ruter 09df948303 Customize: Prevent scrolling custom_css textarea to top when pressing tab.
Props tyxla, sstoqnov for testing, celloexpressions for testing.
See #38667.
Fixes #39134.


git-svn-id: https://develop.svn.wordpress.org/trunk@39557 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 00:43:34 +00:00
John Blackbourn d9ac66c910 Build/Test Tools: Remove some more randomness.
See #37371


git-svn-id: https://develop.svn.wordpress.org/trunk@39556 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-10 00:01:30 +00:00
John Blackbourn 6db50cd8b2 Build/Test Tools: Reuse another fixture in the user capability tests.
See #38716


git-svn-id: https://develop.svn.wordpress.org/trunk@39555 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 23:35:55 +00:00
John Blackbourn d06bd0172e Build/Test Tools: Remove commented out tests that have existed in an unimplemented state since the dawn of the test infrastructure.
See #38716


git-svn-id: https://develop.svn.wordpress.org/trunk@39554 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 23:11:28 +00:00
Andrea Fercia 7b7914a99f Accessibility: Remove inappropriate content from the Edit Categories and Edit Tags screens headings.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39553 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 20:49:49 +00:00
Andrea Fercia 25f40667d0 Accessibility: Remove inappropriate content from the Edit Comments screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39552 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 18:58:51 +00:00
Andrea Fercia c7b8c49bfc Accessibility: Remove inappropriate content from the Network screens headings.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39551 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 18:56:46 +00:00
boonebgorges 479a743307 Docs: Correct param definition for WP_Query::query().
Props Shelob9.
Fixes #38963.

git-svn-id: https://develop.svn.wordpress.org/trunk@39550 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 16:22:02 +00:00
Boone Gorges 77484a0f4a Taxonomy: Introduce get_term_parents_list().
This new function is a taxonomy-agnostic version of `get_category_parents()`.

Props keesiemeijer, SergeyBiryukov, rafaehlers.
Fixes #17069.

git-svn-id: https://develop.svn.wordpress.org/trunk@39549 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 16:09:31 +00:00
Weston Ruter 3caac42ac0 Customize: Collapse available nav menu items panel when clicking outside over preview or over existing items.
Props rockwell15.
Fixes #38953.


git-svn-id: https://develop.svn.wordpress.org/trunk@39548 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 06:15:15 +00:00
Weston Ruter 3669b47260 Customize: Allow (optional) url parameter to be omitted in intercepted calls to history.pushState() and history.replaceState() in customize preview.
Fixes issue where calls without the `url` parameter erroneously end up rewriting the location path to `/undefined`.

Props Christian1012, westonruter.
Fixes #39175.


git-svn-id: https://develop.svn.wordpress.org/trunk@39547 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 01:58:18 +00:00
Weston Ruter c8eafed944 Customize: Use esc_url_raw() instead of wp_json_encode() to eliminate extraneous slashes when outputting background image URL in CSS url().
Props tyxla, westonruter.
See #22058.
Fixes #39145.


git-svn-id: https://develop.svn.wordpress.org/trunk@39546 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-09 01:42:23 +00:00
Weston Ruter 9c5d1f6011 Customize: Use selected user language for edit shortcuts in preview instead of site language.
Props ocean90.
Fixes #39009.


git-svn-id: https://develop.svn.wordpress.org/trunk@39545 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-08 19:31:37 +00:00
Boone Gorges 07b8be1177 Allow apostrophes in email address during wp-login.php registration.
See #18039 for a related fix when creating users via the Dashboard.

Props tomdxw.
Fixes #34483.

git-svn-id: https://develop.svn.wordpress.org/trunk@39544 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-08 03:57:08 +00:00
Andrea Fercia d3aa41cf19 Accessibility: Remove inappropriate content from the Menus screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39543 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 23:46:22 +00:00
Andrea Fercia 2b2f5a5105 Accessibility: Remove inappropriate content from the old Edit Media screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39542 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 23:29:07 +00:00
Andrea Fercia 3760639b2c Accessibility: Remove inappropriate content from the Widgets screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39541 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 22:17:23 +00:00
Felix Arntz fd4b770d7e Multisite: Replace is_super_admin() with update_core for update permissions.
Fixes #39060. See #37616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39540 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 22:13:34 +00:00
Felix Arntz 6e02c370bf Multisite: Remove redundant is_super_admin() when checking for edit_others_posts.
The super admin on multisite as well as the administrator on non-multisite both have this capability already. For custom post types using different capabilities this change ensures that only users with that capability have permissions.

Fixes #39059. See #37616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39539 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 22:08:52 +00:00
Andrea Fercia 7417527b4b Accessibility: Remove inappropriate content from the Edit User screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39538 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 22:07:14 +00:00
Andrea Fercia 0b9b3bc3f4 Accessibility: Remove inappropriate content from the Link Manager screens headings.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39537 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 20:17:56 +00:00
Andrea Fercia 29f6517e6c Accessibility: Remove inappropriate content from the Add Plugins screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39536 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 19:05:02 +00:00
Andrea Fercia 27bc2d9db6 Accessibility: Remove inappropriate content from the Plugins screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39535 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 18:47:47 +00:00
Andrea Fercia ee5b840228 Accessibility: Remove inappropriate content from the Users screen heading.
See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39534 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 18:28:49 +00:00
Andrea Fercia d986f9dcdc Toolbar: remove some unnecessary CSS lines.
They were commented out in `admin-bar.css` since 3 years, see [26770].

Props kafleg, ketuchetan.

Fixes #39137.


git-svn-id: https://develop.svn.wordpress.org/trunk@39533 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 17:44:45 +00:00
Boone Gorges a7c429cb53 Comments: Clean up unused code after [38446].
When the direct SQL query was removed in [38446], part of the SQL
concatenation was not removed. This changeset fixes that.

Props david.binda.
Fixes #39142.

git-svn-id: https://develop.svn.wordpress.org/trunk@39532 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 15:51:08 +00:00
John Blackbourn 93a5849d7e Users: Style the super admin message on the user editing screen as a notice, not a success message.
Fixes #39131


git-svn-id: https://develop.svn.wordpress.org/trunk@39531 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 01:27:13 +00:00
John Blackbourn 042451a9e1 Taxonomy: Correct the type for the first parameter of the the_category filter.
See #39130


git-svn-id: https://develop.svn.wordpress.org/trunk@39530 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-07 01:22:09 +00:00
Andrea Fercia 30076372d7 Accessibility: Improve keyboard accessibility avoiding confusing tab stops in the Media views.
When sections of the media modal are hidden out of view, their controls may be
still focusable and actionable. This completely hides these sections to avoid
unnecessary tab stops and potential confusion for assistive technology users.

Props SergeyBiryukov, afercia.

Fixes #30599.


git-svn-id: https://develop.svn.wordpress.org/trunk@39529 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 23:27:04 +00:00
Andrea Fercia 428548f388 Accessibility: Remove inappropriate content from the Themes screen heading.
Props joedolson.

See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39528 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 23:11:08 +00:00
Andrea Fercia 28b41784d1 Accessibility: Remove inappropriate content from the Add Themes screen heading.
Props joedolson.

See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39527 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 22:23:22 +00:00
Andrea Fercia 1856218978 Accessibility: Remove inappropriate content from the Media Library screens headings.
Props joedolson.

See #26601.


git-svn-id: https://develop.svn.wordpress.org/trunk@39526 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 22:17:03 +00:00
Helen Hou-Sandi 27adb4849b About page: Update video and REST API reference URLs.
props ocean90, kadamwhite, coffee2code.
see #38616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39522 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 18:23:23 +00:00
Helen Hou-Sandi e81cf1c088 Remove 4.7 cruft from $_old_files.
see #39113.


git-svn-id: https://develop.svn.wordpress.org/trunk@39520 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 17:16:55 +00:00
Helen Hou-Sandi 5149911a8d About page: Bump image versions because CDN caching.
props pento.
see #38616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39517 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 07:12:06 +00:00
Joe McGill 6ab5c9b5b7 About page: Resposive images and CDN media URLs.
This adds `srcset` and `sizes` to the about page images, including
art direction, via `<picture>` for the lead Twenty Seventeen image.

This also replaces URLs for all images and feature videos to their
CDN locations on s.w.org.

Props helen, pento, joemcgill.
Fixes #38616.

git-svn-id: https://develop.svn.wordpress.org/trunk@39514 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 06:54:12 +00:00
Helen Hou-Sandi 4284ddfa05 About page: Imagery and beautification.
Still to come: responsive images, optimized videos, and CDN URLs.

props melchoyce, helen, ramiabraham.
see #38616.


git-svn-id: https://develop.svn.wordpress.org/trunk@39512 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 04:00:32 +00:00
Weston Ruter 385dd3fece Customize: Prevent infinite full refresh from occurring when selective refresh falls back for a nav menu that has items excluded from rendering via filtering.
See #37032.
Fixes #38612.


git-svn-id: https://develop.svn.wordpress.org/trunk@39510 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-06 02:50:13 +00:00
Dominik Schilling (ocean90) 386a0ca669 Comments: Merge a similar string between comments.php, XML-RPC and the REST API comments controller.
Props ramiy.
Fixes #39013.

git-svn-id: https://develop.svn.wordpress.org/trunk@39508 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-05 20:15:09 +00:00
Weston Ruter c4bffeb619 Customize: Defer populating post_name for auto-draft posts in customized state until posts are published.
The ultimate `post_name` is stored in postmeta until the post is published. The `get_page_by_path()` function does not exclude `auto-draft` posts. Revert changes to `wp_unique_post_slug()` from [39411] which excluded `auto-draft` posts.

Props westonruter, dlh for testing, helen for testing.
See #38114, #38928.
Fixes #39078.


git-svn-id: https://develop.svn.wordpress.org/trunk@39506 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-05 19:32:09 +00:00
Weston Ruter 2253e42f06 Customize: Ensure changeset_uuid query param is removed from the customize.php window's location once a changeset has been published (committed) with starter content.
Props westonruter, dlh for testing.
See #30937.
Fixes #39081.


git-svn-id: https://develop.svn.wordpress.org/trunk@39504 602fd350-edb4-49c9-b593-d223f7449a82
2016-12-05 16:55:29 +00:00