vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,557 Commits 1 Branch 0 Tags 243 MiB
29f271da44
Commit Graph

108 Commits

Author SHA1 Message Date
Andrea Fercia
29f271da44 Media: Improve form fields labels association in the Edit Media screen. 
Fixes #34548.

git-svn-id: https://develop.svn.wordpress.org/trunk@35493 602fd350-edb4-49c9-b593-d223f7449a82
 2015-11-03 16:01:11 +00:00
Sergey Biryukov
d21d397d49 Don't use <code> in translatable string in wp-admin/includes/media.php. 
Add translator commment.

Props ramiy.
Fixes #34499.

git-svn-id: https://develop.svn.wordpress.org/trunk@35439 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-30 00:57:22 +00:00
Sergey Biryukov
d842c03e02 Docs: Correct the type and description of $post parameter passed to the attachment_fields_to_save filter. 
Props swissspidy.
Fixes #34404.

git-svn-id: https://develop.svn.wordpress.org/trunk@35374 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-23 13:00:11 +00:00
Helen Hou-Sandi
61ef1ff96f Make some primary action buttons look primary. 
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload

props Dezzy for the initial patch.
fixes #23738.


git-svn-id: https://develop.svn.wordpress.org/trunk@35182 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-15 03:07:48 +00:00
Drew Jaynes
0cb7c0bd9f Docs: Add missing descriptions for the $wpdb global in DocBlocks all the places. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35170 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-14 23:43:10 +00:00
Drew Jaynes
6e6d9f9830 Docs: Specify the default image size in the $size parameter description for the image_send_to_editor hook. 
See #34257. See #32246. See [35058].


git-svn-id: https://develop.svn.wordpress.org/trunk@35080 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:17:19 +00:00
Drew Jaynes
dd7b3a62fd Docs: Normalize spacing in the DocBlock for get_image_send_to_editor() following [35056]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35079 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 17:15:16 +00:00
Drew Jaynes
6db985862a Docs: Normalize spacing in the image_send_to_editor hook doc following [35058]. 
See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35059 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:18:32 +00:00
Drew Jaynes
59db8cfe93 Docs: Adjust documentation for the $size parameter in the image_send_to_editor hook doc to clarify the required order of width and height values when an array is passed. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35058 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:16:35 +00:00
Drew Jaynes
25c0710f4c Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor(). 
Also fixes the return description, and adds the `$size` default value, missed in [35055].

See #34257. See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@35056 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:10:44 +00:00
Drew Jaynes
4d967258f2 Docs: Adjust documentation for the $size parameter in get_image_send_to_editor() to clarify the required order of width and height values when passing an array. 
Also adds the `array` type to the parameter documentation (already supported).

See #34257.


git-svn-id: https://develop.svn.wordpress.org/trunk@35055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-12 16:07:25 +00:00
Sergey Biryukov
d58bcae1ad Media: Return early from media_sideload_image() if $file didn't match the pattern for images. 
Props MikeHansenMe, serpent7776.
Fixes #32755.

git-svn-id: https://develop.svn.wordpress.org/trunk@34984 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-09 04:46:00 +00:00
Scott Taylor
bb2c59c3a8 Media: in wp_read_video|audio_metadata(), set GETID3_TEMP_DIR to get_temp_dir() if it is not defined. This is a workaround for when safe_mode is enabled pre-PHP 5.3. 
Props chriscct7, tomsommer.
Fixes #26265.


git-svn-id: https://develop.svn.wordpress.org/trunk@34866 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-06 14:13:49 +00:00
Drew Jaynes
e9e26c5726 Docs: Add missing DocBlock summaries for a multitude of functions in wp-admin/includes/media.php. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@34823 602fd350-edb4-49c9-b593-d223f7449a82
 2015-10-05 02:43:49 +00:00
Scott Taylor
ed7d34cb13 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 
Fixes #20523.


git-svn-id: https://develop.svn.wordpress.org/trunk@34348 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-20 03:51:55 +00:00
Scott Taylor
337c87e7c7 Media: In get_image_send_to_editor(), allow a custom value for $rel. 
Props tychay.
Fixes #32074.


git-svn-id: https://develop.svn.wordpress.org/trunk@34259 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-17 05:45:31 +00:00
Scott Taylor
c95d6b3ec8 Use get_attached_file() in attachment_submitbox_metadata(). 
Props kitchin.
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34171 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 04:17:38 +00:00
Scott Taylor
577fea566a Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 
Fixes #33386.


git-svn-id: https://develop.svn.wordpress.org/trunk@34163 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-15 02:49:12 +00:00
Scott Taylor
0a7636cfa3 In wp_media_upload_handler(), replace a lingering instance of media_upload_gallery() with wp_iframe(...) 
Props jeffstieler, antpb.
Fixes #17812. 


git-svn-id: https://develop.svn.wordpress.org/trunk@34003 602fd350-edb4-49c9-b593-d223f7449a82
 2015-09-10 17:23:23 +00:00
Scott Taylor
3b8c5529cb foreach is a statement, not a function. 
See #33491.


git-svn-id: https://develop.svn.wordpress.org/trunk@33734 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-25 20:27:56 +00:00
Drew Jaynes
5e6f651daf Docs: Add a missing summary to the DocBlock for wp_media_upload_handler(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@33670 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-20 21:00:42 +00:00
Ella Iseulde Van Dorpe
03653fa600 Editor: Add Media should be a button 
Props afercia.
Fixes #32969.


git-svn-id: https://develop.svn.wordpress.org/trunk@33298 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-16 19:37:07 +00:00
Konstantin Obenland
3a696d7d91 Media: Remove post_type variable, unused since [32676]. 
Fixes #32948.


git-svn-id: https://develop.svn.wordpress.org/trunk@33263 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-14 15:05:29 +00:00
Scott Taylor
f162be6046 For doc block types, favor bool over the few remaining booleans 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32964 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-27 01:02:12 +00:00
John Blackbourn
87d5aefe74 Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.


git-svn-id: https://develop.svn.wordpress.org/trunk@32673 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 16:53:12 +00:00
Scott Taylor
986990163f Add doc blocks to functions that are missing them. 
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32672 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-31 03:17:50 +00:00
Scott Taylor
d55800a4f2 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes: 
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.


git-svn-id: https://develop.svn.wordpress.org/trunk@32653 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 17:03:13 +00:00
Scott Taylor
c8a44d437a Add @static* annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32650 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-29 15:42:40 +00:00
Scott Taylor
23ce2efd12 Add @global annotations for wp-admin/*. 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32642 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-28 21:40:27 +00:00
Scott Taylor
46752a491e When calling unset(), it is unnecessary to immediately precede it with a call to isset(). 
See #32444.


git-svn-id: https://develop.svn.wordpress.org/trunk@32545 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-22 05:46:47 +00:00
Drew Jaynes
3ca1ff6b72 Fix documentation syntax and formatting for the media_sideload_image() DocBlock. 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32352 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-05 02:19:47 +00:00
Drew Jaynes
7138b7e1bd Add two changelog entries for functional changes introduced in 4.2.0. 
Props dimadin.
See #31925.


git-svn-id: https://develop.svn.wordpress.org/trunk@32350 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-05 02:15:27 +00:00
Drew Jaynes
eea4111667 Add a missing DocBlock for wp_caption_input_textarea(). 
See #32246.


git-svn-id: https://develop.svn.wordpress.org/trunk@32341 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-04 01:12:12 +00:00
Drew Jaynes
c7fee4fab0 Add proper descriptions for the @global and @param tags in the wp_media_attach_action() DocBlock. 
See [31619]. See #31888.


git-svn-id: https://develop.svn.wordpress.org/trunk@32018 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-04 21:34:15 +00:00
Scott Taylor
2f20da29b5 Replace array_shift() with reset() where appropriate for performance. 
Props SergeyBiryukov.
Fixes #31259.


git-svn-id: https://develop.svn.wordpress.org/trunk@31829 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-19 03:55:39 +00:00
Andrew Ozz
820fe85082 Press This: 
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660.

git-svn-id: https://develop.svn.wordpress.org/trunk@31799 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-17 00:46:01 +00:00
Sergey Biryukov
5fe8182c7f EXIF/IPTC captions should populate Caption (post_excerpt) on upload, not Description (post_content). 
Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set.

props beaulebens, ericlewis, bendoh, SergeyBiryukov.
fixes #22768.

git-svn-id: https://develop.svn.wordpress.org/trunk@31694 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-10 05:06:39 +00:00
Scott Taylor
42bcec5061 Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video. 
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.


git-svn-id: https://develop.svn.wordpress.org/trunk@31645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-06 20:25:09 +00:00
Scott Taylor
21568b8cc1 detached affects the wp() call for the media list table, so switch our new $_GET key to detach. 
See #6820.


git-svn-id: https://develop.svn.wordpress.org/trunk@31624 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-05 15:58:02 +00:00
Scott Taylor
6c8322e8fa Allow attachments to be Detached from their parent in media grid and list modes. 
See #6820.


git-svn-id: https://develop.svn.wordpress.org/trunk@31619 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-05 05:34:40 +00:00
Sergey Biryukov
100e1e4b20 Terminate JS statements in two admin files. 
props ipm-frommen.
fixes #31311.

git-svn-id: https://develop.svn.wordpress.org/trunk@31440 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-13 04:08:33 +00:00
Scott Taylor
83b6fad852 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.


git-svn-id: https://develop.svn.wordpress.org/trunk@31200 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 04:15:52 +00:00
Scott Taylor
102fb4ac5c Replace the 3 remaining occurrences of wpspin GIF with spinner. 
Props avryl.
Fixes #27482.


git-svn-id: https://develop.svn.wordpress.org/trunk@31187 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-16 00:32:45 +00:00
Sergey Biryukov
b641ca55f5 Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.

git-svn-id: https://develop.svn.wordpress.org/trunk@31109 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-09 05:04:59 +00:00
Scott Taylor
6fd11624d1 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@31090 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 07:04:40 +00:00
Scott Taylor
47f2c42528 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments. 
Props tw2113 for the initial patch.
See #18788.


git-svn-id: https://develop.svn.wordpress.org/trunk@31034 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-03 05:45:17 +00:00
Scott Taylor
91dcf8796b In image_size_input_fields(): 
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.


git-svn-id: https://develop.svn.wordpress.org/trunk@30981 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-20 22:18:12 +00:00
Scott Taylor
8a4fa5662b Improve various @param docs for src/wp-admin/*. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30680 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-01 00:59:43 +00:00
Drew Jaynes (DrewAPicture)
f45fd382b3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.


git-svn-id: https://develop.svn.wordpress.org/trunk@30648 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-30 11:27:19 +00:00
Drew Jaynes (DrewAPicture)
ba21c68c23 4.1 Docs Audit: Convert a hook reference to an inline @see tag in the hook docs for the image_add_caption_text filter. 
See #30469.


git-svn-id: https://develop.svn.wordpress.org/trunk@30600 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-28 08:55:46 +00:00