vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-16 23:00:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
32,557 Commits 1 Branch 0 Tags
29f271da44bc316d71ec70aa8a8680f1502986ef
Commit Graph
108 Commits
Author SHA1 Message Date
Drew Jaynes (DrewAPicture) 6007c0c17d Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.


git-svn-id: https://develop.svn.wordpress.org/trunk@30543 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-24 05:52:45 +00:00
Scott Taylor 6c5e90eaa5 Correct some types in wp-admin/*-location files' doc blocks. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30203 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 07:08:16 +00:00
Scott Taylor 3942ff4616 Correct all @return unknown instances. 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30202 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 06:16:34 +00:00
Scott Taylor ba85fbacba Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out). 
See #30224.


git-svn-id: https://develop.svn.wordpress.org/trunk@30201 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-03 06:07:26 +00:00
Gary Pendergast 0e68ecc0b6 Add wp_json_encode(), a wrapper for json_encode() that ensures everything is converted to UTF-8. 
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.



git-svn-id: https://develop.svn.wordpress.org/trunk@30055 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-28 18:34:16 +00:00
Andrew Ozz 3b757232d0 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@29776 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-29 00:13:47 +00:00
Sergey Biryukov 994566bb17 Pass the attachment ID to the 'image_add_caption_text' filter. 
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29754 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 10:10:19 +00:00
Sergey Biryukov 9e673c7eee Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor. 
props collinsinternet, DrewAPicture.
fixes #29607.

git-svn-id: https://develop.svn.wordpress.org/trunk@29753 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-21 09:55:08 +00:00
Scott Taylor 6ed8bab324 In media_handle_upload(), don't call wp_read_image_metadata() on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling @wp_read_image_metadata(). 
Props jrf for the initial patch.
Fixes #28907.


git-svn-id: https://develop.svn.wordpress.org/trunk@29737 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-11 20:14:56 +00:00
Andrew Ozz 123fae73b5 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602 
git-svn-id: https://develop.svn.wordpress.org/trunk@29729 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 22:39:39 +00:00
Scott Taylor 698f77735b Don't overwrite the length property unnecessarily when generating metadata for audio and video files. 
Props jrf, wonderboymusic.
Fixes #29176.


git-svn-id: https://develop.svn.wordpress.org/trunk@29728 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-10 21:56:24 +00:00
Sergey Biryukov 8cfdbf1167 Use https for apps.wordpress.org links. 
props pento.
fixes #29595 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@29721 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-09 06:28:33 +00:00
Andrew Nacin 84681ddd39 Link to apps.wordpress.org instead of wordpress.org/mobile. 
props pento.
fixes #29496.


git-svn-id: https://develop.svn.wordpress.org/trunk@29703 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-04 14:21:13 +00:00
Sergey Biryukov bd07f41256 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances. 
props nacin.
fixes #28090.

git-svn-id: https://develop.svn.wordpress.org/trunk@29671 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-02 09:07:08 +00:00
Dominik Schilling (ocean90) de7962c947 Media Upload: Improve styling of error messages. 
props afercia, michalzuber.
fixes #29047.

git-svn-id: https://develop.svn.wordpress.org/trunk@29355 602fd350-edb4-49c9-b593-d223f7449a82
 2014-08-02 14:13:06 +00:00
Sergey Biryukov 332a618271 Declare the variable before using it. 
props danielbachhuber.
fixes #28932.

git-svn-id: https://develop.svn.wordpress.org/trunk@29215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 22:00:14 +00:00
Drew Jaynes (DrewAPicture) 6ddc1e5f6d Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.


git-svn-id: https://develop.svn.wordpress.org/trunk@29206 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-17 09:13:53 +00:00
Scott Taylor c6428ff1ba When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well. 
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.


git-svn-id: https://develop.svn.wordpress.org/trunk@29029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-07-08 17:47:53 +00:00
Scott Taylor 2371f75688 In deprecated media iframe code, attachment_fields_to_save filter should not be called twice after initial image upload in post. 
Props SergeyBiryukov.
Fixes #20720.


git-svn-id: https://develop.svn.wordpress.org/trunk@28871 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-27 21:31:28 +00:00
Andrew Ozz 38debafe60 Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28847 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 04:14:59 +00:00
Scott Taylor 95f3506532 In media_buttons(), add a static var $instance to increment the id attribute of insert-media-button-%d on each call. 
Props ericlewis.
Fixes #28090.


git-svn-id: https://develop.svn.wordpress.org/trunk@28837 602fd350-edb4-49c9-b593-d223f7449a82
 2014-06-26 01:04:32 +00:00
Drew Jaynes (DrewAPicture) dc96d99a70 Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php. 
Also add `@param` and `@return` descriptions.

See #28408.


git-svn-id: https://develop.svn.wordpress.org/trunk@28632 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-30 17:37:36 +00:00
Scott Taylor 5c3f7d5392 In media_sideload_image(), check the returned value of download_url() earlier to avoid attempting to unlink() an instance of WP_Error. 
Props georgestephanis. 
Fixes #28204.


git-svn-id: https://develop.svn.wordpress.org/trunk@28567 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 21:32:12 +00:00
Scott Taylor eef0d99ed8 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28497 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 01:58:28 +00:00
Scott Taylor 27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor 3f59b86ec5 In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.



git-svn-id: https://develop.svn.wordpress.org/trunk@28368 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:11:08 +00:00
Scott Taylor 7531fd0070 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 18:24:47 +00:00
Scott Taylor d92f5aa154 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:40:52 +00:00
Scott Taylor f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:44:56 +00:00
Andrew Ozz bff230b422 Plupload: restore the settings in media_upload_form(), see #27763 
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:40:45 +00:00
Drew Jaynes (DrewAPicture) 33acf29a46 Clarify PHPDoc return description for media_handle_upload(). 
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 22:32:47 +00:00
Scott Taylor d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys(). 
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-31 05:15:39 +00:00
Andrew Nacin 877ffc087f Cleanups for audio/video metadata, see [27862]. 
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 21:07:04 +00:00
Scott Taylor 149f36ed35 Metadata for audio and video files: 
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-30 19:27:31 +00:00
Drew Jaynes (DrewAPicture) 0e7a34444d Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.


git-svn-id: https://develop.svn.wordpress.org/trunk@27695 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-25 08:04:44 +00:00
Andrew Nacin 48391a7444 Use correct variable. see [27373]. 
props TobiasBg.
fixes #14424.


git-svn-id: https://develop.svn.wordpress.org/trunk@27675 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-24 03:24:33 +00:00
Andrew Ozz 263d9c7f33 Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle. 
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.

git-svn-id: https://develop.svn.wordpress.org/trunk@27662 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-23 23:44:20 +00:00
Dominik Schilling (ocean90) 9e92a95ec5 Remove "Show" prefix from filter dropdowns, see #26743. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27626 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-19 22:12:13 +00:00
Andrew Nacin 6aa60cf530 Assign correct variable. 
props nendeb55.
fixes #27351. see #14424, [27373].


git-svn-id: https://develop.svn.wordpress.org/trunk@27501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-11 13:23:14 +00:00
Andrew Nacin 4bbd5ef1d6 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata(). 
props kovshenin.
fixes #26825.


git-svn-id: https://develop.svn.wordpress.org/trunk@27441 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-06 19:33:32 +00:00
Mark Jaquith 7937358328 Eliminate some of our last remaining create_function() instances 
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424

git-svn-id: https://develop.svn.wordpress.org/trunk@27373 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 16:20:12 +00:00
Andrew Nacin f3a23fb43f Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.


git-svn-id: https://develop.svn.wordpress.org/trunk@27369 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-03 02:33:24 +00:00
Scott Taylor 07f14d6434 * Videos should always render at the same aspect ratio. 
* Don't force a pseudo-mime-type for `.m4v` files
* Uniformly adapt to `$content_width` when setting video dimensions on the front end
* Add the `height` attribute to the initial `<video>` in the video playlist JS template
* Add some defensive/responsive CSS for a/v on the Edit Media page

See #27243.



git-svn-id: https://develop.svn.wordpress.org/trunk@27328 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-28 21:27:40 +00:00
Andrew Ozz 11586e8ebe Upgrade Plupload to 2.1.1, props kovshenin, see #25663 
git-svn-id: https://develop.svn.wordpress.org/trunk@27316 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 20:00:55 +00:00
Scott Taylor d6cb8c399e Introduce maybe_regenerate_attachment_metadata( $attachment ). On the Edit Media screen, call it for Audio and Video files. 
The functions checks if the item is lacking metadata altogether. If a video or audio file was uploaded prior to 3.6, it does not have any metadata. This tries to fix it. Implements locking via a transient to protect against this running in parallel with another request.

This is the minimum viable product for #26825, but leaving the ticket open unless this function needs to be called in other places.

See #26825.



git-svn-id: https://develop.svn.wordpress.org/trunk@27127 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-07 22:40:32 +00:00
Andrew Ozz 88fecbeff9 Remove table cellspacing attribute from the admin, part-props MattyRob, fixes #22086. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27036 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-26 20:27:21 +00:00
Andrew Ozz 48d24f6bf5 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712. 
git-svn-id: https://develop.svn.wordpress.org/trunk@27029 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-24 19:05:15 +00:00
Drew Jaynes 00f318650d Inline documentation for hooks in wp-admin/includes/media.php. 
Props kpdesign, DrewAPicture.
Fixes #25375.


git-svn-id: https://develop.svn.wordpress.org/trunk@26908 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-06 05:47:51 +00:00
Scott Taylor 4aa0066736 Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata(). 
Props kovshenin.
See #23926.



git-svn-id: https://develop.svn.wordpress.org/trunk@25727 602fd350-edb4-49c9-b593-d223f7449a82
 2013-10-08 15:31:32 +00:00
Helen Hou-Sandi ab117ae99c Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170. 
git-svn-id: https://develop.svn.wordpress.org/trunk@25608 602fd350-edb4-49c9-b593-d223f7449a82
 2013-09-24 20:22:24 +00:00