vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-28 12:40:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
39,496 Commits 1 Branch 0 Tags
30caafae4081eac8276b3461d3dcafea2deef77c
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Dion Hulse 1d0963afbd Bump $wp_version to latest revision. 
https://core.trac.wordpress.org/ has been moved to new infrastructure, this is a test commit to verify that trunk builds continue to work as expected.

If you notice any breakage on Trac, please report it to https://meta.trac.wordpress.org/ticket/3526 - there's a number of known UI issues at present which will be resolved soon.


git-svn-id: https://develop.svn.wordpress.org/trunk@42970 602fd350-edb4-49c9-b593-d223f7449a82
 2018-04-11 02:58:45 +00:00
Dion Hulse f4d279af85 Bump $wp_version to latest revision. 
https://core.trac.wordpress.org/ has been moved to new infrastructure, this is a test commit to verify that trunk builds continue to work as expected.

If you notice any breakage on Trac, please report it to https://meta.trac.wordpress.org/ticket/3526 - there's a number of known UI issues at present which will be resolved soon.


git-svn-id: https://develop.svn.wordpress.org/trunk@42969 602fd350-edb4-49c9-b593-d223f7449a82
 2018-04-11 02:49:49 +00:00
Dion Hulse 36d237cc13 Plugins: Add support for plugins having an active_installs value larger than 1 million. 
WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future.

Fixes #43193.


git-svn-id: https://develop.svn.wordpress.org/trunk@42829 602fd350-edb4-49c9-b593-d223f7449a82
 2018-03-12 01:56:20 +00:00
Dion Hulse e04b4d47b4 Updates: Partially revert [42584], as this branch of code should always be run after a core update check. 
This code branch is responsible for running all autoupdates, including plugins and themes - which should run regardless of if there's a core autoupdate available.

This revert does not revert the `$timeout` changes, as these should still use cached data if it's available.
Ideally this should be decoupled from the core update check to allow background updates to operate even when the core update check is disabled or running more often than twice daily.

See #43103.


git-svn-id: https://develop.svn.wordpress.org/trunk@42653 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-06 11:03:55 +00:00
Dion Hulse 5789855ed1 XML-RPC: Add default values to IXR_Message for PHP 7.2 compatibility to avoid PHP Warnings. 
Fixes #43216 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42652 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-06 02:55:38 +00:00
Dion Hulse 212c880d71 Themes: Use api.wordpress.org/themes/info/1.2/ to query theme information. 
See #43192.


git-svn-id: https://develop.svn.wordpress.org/trunk@42632 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-01 05:18:54 +00:00
Dion Hulse e0d5a8ac54 Plugins: Use api.wordpress.org/plugins/info/1.2/ for querying plugins & plugin information. 
See #43192.
Fixes #29274.


git-svn-id: https://develop.svn.wordpress.org/trunk@42631 602fd350-edb4-49c9-b593-d223f7449a82
 2018-02-01 05:16:15 +00:00
Dion Hulse f35ed94605 Tests: Skip newly added tests from [42581] on PHP 5.2 as they require ReflectionMethod. 
See #42860.


git-svn-id: https://develop.svn.wordpress.org/trunk@42585 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-24 04:20:26 +00:00
Dion Hulse 67988d5b26 Updates: Only trigger Background Update processes from within the core update check when a core autoupdate is on offer. 
This change reduces the number of API calls which WordPress makes to api.wordpress.org during release windows.

Previously the background updates would run upon every core update transient refresh, however now they'll only run if there's an update available.
The change also increases the cache period for plugin & theme checks when running via the cron, from never-cache to 2 hours, which should hopefully reduce the number of needless API calls.

Fixes #43103 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42584 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-24 04:16:18 +00:00
Dion Hulse 5110f349a9 WPDB: Use a PCRE syntax which supports PCRE compiled between 2003 and 2006. 
This fixes a PHP Warning in `wpdb::parse_db_host()` when WordPress is used with (sometimes a modern) PHP that's compiled against an ancient PCRE version.

Fixes #43109 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42549 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-23 03:38:42 +00:00
Dion Hulse 2cb36cab72 General: Allow wp_list_pluck() to operate on arrays of references without overwriting the referenced items. 
Fixes #16895.


git-svn-id: https://develop.svn.wordpress.org/trunk@42527 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-18 05:17:23 +00:00
Dion Hulse ade2dd5dfe Tests: Remove redundant assertEquals() calls in listFilter tests. 
As these tests are already validating that two arrays match, checking that the counts also match before is redundant and makes it harder to debug when the test fails.

See #16895


git-svn-id: https://develop.svn.wordpress.org/trunk@42526 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-18 05:14:28 +00:00
Dion Hulse b938517860 Build: Bump the version of node used on Travis to match WordPress.org. 
Props netweb, dd32.
See #35105


git-svn-id: https://develop.svn.wordpress.org/trunk@42464 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-16 06:35:22 +00:00
Dion Hulse e157ce1ebf Build: Bump grunt-sass to v2.0.0 from v1.2.1 for Node 8.x support. 
Changes: https://github.com/sindresorhus/grunt-sass/compare/v1.2.1...v2.0.0

Props netweb.
See #35105.
Fixes #43097.


git-svn-id: https://develop.svn.wordpress.org/trunk@42463 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-16 06:32:54 +00:00
Dion Hulse 4dbc0b3987 External Libraries: Remove unnecessary / obsoleted MediaElement.js files. 
Props joemcgill.
Fixes #42720 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42462 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-16 06:27:48 +00:00
Dion Hulse 2eba5a98d9 Build: Use Node 8.x for trunk. 
Props netweb.
See #35105.


git-svn-id: https://develop.svn.wordpress.org/trunk@42461 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-16 03:56:01 +00:00
Dion Hulse 01d5469e73 Build: Switch package.json to using tabs for indents. 
Props netweb.
Fixes #43075.


git-svn-id: https://develop.svn.wordpress.org/trunk@42460 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-16 03:54:10 +00:00
Dion Hulse 91b3164ee5 Upgrade: When deleting old files, if deletion fails attempt to empty the file instead. 
Props joemcgill, dd32.
Fixes #42963 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42433 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-10 06:09:51 +00:00
Dion Hulse 70a92ca96e Streams: When checking in wp_is_stream() escape the stream wrapper names for PCRE to avoid PHP warnings when invalid stream wrappers are registered. 
Fixes #43054.


git-svn-id: https://develop.svn.wordpress.org/trunk@42432 602fd350-edb4-49c9-b593-d223f7449a82
 2018-01-10 02:49:49 +00:00
Dion Hulse 581b74cbed WP: Don't attempt to convert multiple-nested arrays to a string in WP->parse_request(). 
See #14330.
Fixes #42752.


git-svn-id: https://develop.svn.wordpress.org/trunk@42419 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-22 03:17:14 +00:00
Dion Hulse 64e3dc5bc8 i18n: Don't use esc_attr_e() on a variable. 
Props yoavf.
Fuxes #42935.


git-svn-id: https://develop.svn.wordpress.org/trunk@42413 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-20 05:34:05 +00:00
Dion Hulse f216215864 WPDB: Always use mysqli when available. 
This change makes WordPress use `mysqli` on PHP <5.5 when available, instead of only in PHP 5.5+ and development installs.

WPDB includes a fallback to `mysql` in the event that the database connection fails with `mysqli` so incompatibilities should be few and far between.

Fixes #42812 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42388 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-12 05:42:12 +00:00
Dion Hulse da689558a5 Filesystem: Allow wp_normalise_path() to handle PHP stream wrappers such as php:// correctly. 
Props calin, dd32.
Fixes #42837.


git-svn-id: https://develop.svn.wordpress.org/trunk@42387 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-12 04:15:54 +00:00
Dion Hulse 35c13730dd Docs: Correct some typos in the docs for wp_ajax_get_community_events(). 
Props Presskopp.
Fixes #42861.


git-svn-id: https://develop.svn.wordpress.org/trunk@42384 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-11 08:48:07 +00:00
Dion Hulse 9fed02f896 Posts: When using wp_update_post() on a attachment post_type item, pass the $wp_error parameter through to wp_insert_attachment(). 
Props MyThemeShop.
Fixes #41513.


git-svn-id: https://develop.svn.wordpress.org/trunk@42383 602fd350-edb4-49c9-b593-d223f7449a82
 2017-12-11 06:36:13 +00:00
Dion Hulse c52f6ba995 Users: Display partial names in the user listing tables. 
This allows showing a name when only the first or last name is provided.

Props shital-patel, antipole.
Fixes #42713.


git-svn-id: https://develop.svn.wordpress.org/trunk@42256 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-29 03:40:31 +00:00
Dion Hulse a825a181e1 Theme Editor: Translate the URL to the Child Themes Codex page. 
Props odysseygate, johnpgreen.
Fixes #42454.


git-svn-id: https://develop.svn.wordpress.org/trunk@42247 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-27 03:51:25 +00:00
Dion Hulse 44c75415b3 Theme Editior: Base the nonce on a simpler combination of fields, for easier debugging & reading. 
See #42609.
Fixes #42705.


git-svn-id: https://develop.svn.wordpress.org/trunk@42246 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-27 03:43:11 +00:00
Dion Hulse 6e0ba7864f Theme Editor: Validate files are editable based on their relative filenames, rather than full file path. 
This fixes theme editing on Windows platforms where `validate_file()` will return `2` on a full file path.

Fixes #42609.


git-svn-id: https://develop.svn.wordpress.org/trunk@42244 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-27 03:27:19 +00:00
Dion Hulse d00e74042b Docs: Update the documentation for get_post_meta() to clarify that $single has no effect when the $meta_key is not provided. 
Props chetan200891, titodevera.
Fixes #42687.


git-svn-id: https://develop.svn.wordpress.org/trunk@42227 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-26 03:16:55 +00:00
Dion Hulse b8c4faff72 WPDB: Fix the parsing of sockets which contain colons within the socket name (used on some cloud providers). 
Props natacado.
Fixes #42634 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42226 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-24 05:51:31 +00:00
Dion Hulse 555eab6391 Template: Don't output an empty <ul> in the_meta() when a post only has protected metas. 
Props campusboy1987, birgire.
Fixes #42629.


git-svn-id: https://develop.svn.wordpress.org/trunk@42225 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-24 05:20:39 +00:00
Dion Hulse 26fb077862 Filesystem: Use a more unique filename in wp_tempnam() and get_filesystem_method(). 
Using a filename which was generated from `time()` could cause two processes to try to use the same filename, causing unexpected behaviour.

Props jrchamp, bikecrazyy.
Fixes #42265.


git-svn-id: https://develop.svn.wordpress.org/trunk@42224 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-24 03:04:35 +00:00
Dion Hulse 2c1858a8c3 Upgrade: Fix updating plugins which include a numeric file/folder names. 
The fix in [41821] caused numeric folder names to be reindexed to 0..n when in the root directory (for example, `my-plugin/24/`).

Props edo888.
See #41524.
Fixes #42628 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@42214 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-21 04:14:33 +00:00
Dion Hulse 61904426e2 DB Repair: Only allow non-falsey values of WP_ALLOW_REPAIR to access the DB repair functionality. 
This allows defining the constant as `false` to prevent access (rather than requiring the constant to be removed entirely).

Props tiagohillebrandt, munklefish.
See #11717.
Fixes #42622.


git-svn-id: https://develop.svn.wordpress.org/trunk@42205 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-20 06:20:23 +00:00
Dion Hulse be70839966 Remove the svn:keywords property from files that don't need it. 
See #42594


git-svn-id: https://develop.svn.wordpress.org/trunk@42201 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-17 03:00:43 +00:00
Dion Hulse 21ad5a9e40 Remove the svn:executable property from files that don't need it. 
See #42594


git-svn-id: https://develop.svn.wordpress.org/trunk@42200 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-17 02:57:27 +00:00
Dion Hulse 56659638dc External Libraries: Update Random_Compat from 1.2.1 to 2.0.11. 
Notably this fixes PHP7 parse errors of the files and removes the OpenSSL functionality.
Full Changes: https://github.com/paragonie/random_compat/compare/v1.2.1...v2.0.11

Props jrdelarosa.
See #42439.


git-svn-id: https://develop.svn.wordpress.org/trunk@42130 602fd350-edb4-49c9-b593-d223f7449a82
 2017-11-08 11:47:04 +00:00
Dion Hulse eaa0c3ac04 Tests: Return an exit code of 1 in the event that the database server for tests is unavailable. 
This allows for automated scripts & test suites to handle the failure of the test suite easier.

Props danielbachhuber
Fixes #41916


git-svn-id: https://develop.svn.wordpress.org/trunk@41966 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-21 14:13:37 +00:00
Dion Hulse 899fb2f7f6 Transients: Clear expired transients from the database in a daily cron task. 
Fixes #41699


git-svn-id: https://develop.svn.wordpress.org/trunk@41963 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-21 13:21:24 +00:00
Dion Hulse 4b2b97a3b3 Upgrades: Remove the usage of each() from WP_Upgrader for PHP 7.2 compatibility. 
Props chrisvendiadvertisingcom, dd32.
Fixes #41524


git-svn-id: https://develop.svn.wordpress.org/trunk@41821 602fd350-edb4-49c9-b593-d223f7449a82
 2017-10-11 04:23:49 +00:00
Dion Hulse 2ff224a044 Standardise on performing api.WordPress.org requests over SSL when possible, falling back to non-SSL when appropriate. 
This also standardises the `User-Agent` used when communicating with WordPress.org, allowing for more consistent version detection.

Fixes #42004.


git-svn-id: https://develop.svn.wordpress.org/trunk@41605 602fd350-edb4-49c9-b593-d223f7449a82
 2017-09-27 07:59:14 +00:00
Dion Hulse dd065164f4 Embeds: Switch the Imgur oEmbed endpoint to use SSL as the HTTP version has been deprecated. 
Props swissspidy.
Fixes #41984.


git-svn-id: https://develop.svn.wordpress.org/trunk@41599 602fd350-edb4-49c9-b593-d223f7449a82
 2017-09-26 08:32:21 +00:00
Dion Hulse 82f99ca927 Media: Avoid PHP Warnings in get_post_galleries() when processing empty [gallery] shortcodes and avoid returning the incorrect results when the global $post does not match the provided post ID. 
Props dd32, joemcgill, seanchayes.
Fixes #39277, #39304.


git-svn-id: https://develop.svn.wordpress.org/trunk@40070 602fd350-edb4-49c9-b593-d223f7449a82
 2017-02-17 06:45:31 +00:00
Dion Hulse bfeda161b7 HTTP API: Restore backwards compatibility with the http_api_curl filter - it expects that the handle parameter is passed as a reference, however [39212] missed that. 
Props pento.
Fixes #39783.


git-svn-id: https://develop.svn.wordpress.org/trunk@40068 602fd350-edb4-49c9-b593-d223f7449a82
 2017-02-17 05:05:03 +00:00
Dion Hulse b1b4d49264 Update PHPMailer to 5.2.22. 
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.21...v5.2.22

Fixes #37210 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@39759 602fd350-edb4-49c9-b593-d223f7449a82
 2017-01-11 01:22:46 +00:00
Dion Hulse c1fc065ac4 Customizer: Don't query for postmeta for Custom CSS (for not-current-themes) and Customizer Changeset posts. 
Props dlh.
Fixes #39194.


git-svn-id: https://develop.svn.wordpress.org/trunk@39692 602fd350-edb4-49c9-b593-d223f7449a82
 2017-01-05 08:11:30 +00:00
Dion Hulse bc231804a3 Mail: In PHPMailer 5.2.7 the case of the Send() method changed to send(), update our call for consistency with the library. 
Props michalzuber.
Fixes #39469.


git-svn-id: https://develop.svn.wordpress.org/trunk@39691 602fd350-edb4-49c9-b593-d223f7449a82
 2017-01-05 08:09:06 +00:00
Dion Hulse 7cfb768da3 Updates: Properly define $filesystemForm to handle error in modals. 
Ammends [39657].
See #39057.


git-svn-id: https://develop.svn.wordpress.org/trunk@39689 602fd350-edb4-49c9-b593-d223f7449a82
 2017-01-05 07:23:10 +00:00
Dion Hulse 16e8d82c89 Updates: Show the Authentication key settings after selecting the SSH transport in both the modal, and also on the plugin/theme updates screen. 
Props afercia.
Fixes #39057 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@39657 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-30 07:43:41 +00:00
Dion Hulse 85ad040c97 Updates: Remove a stray " from a tag. 
Props afercia.
See #39057.


git-svn-id: https://develop.svn.wordpress.org/trunk@39656 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-30 07:41:45 +00:00
Dion Hulse 247e08e84a Mail: Ensure that any phpmailerException exceptions generated by setFrom() are caught to avoid PHP Fatal errors. 
This change avoids a PHP fatal error that can be encountered when the specified (or generated) source email is an invalid address, such as `wordpress@_`, it makes no effort to set a valid source, only avoid the fatal error.

See #25239 for correcting the email address.
Fixes #39360.


git-svn-id: https://develop.svn.wordpress.org/trunk@39655 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-30 06:43:07 +00:00
Dion Hulse e0531dcaa3 Upgrade PHPMailer from 5.2.14 to 5.2.21. 
The full list of changes is available here:
https://github.com/PHPMailer/PHPMailer/compare/v5.2.14...v5.2.21

Props sebastian.pisula, MattyRob, sfpt, dd32.
Fixes #37210 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@39645 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-29 02:52:08 +00:00
Dion Hulse 3a4aae8c20 Filesystem: Add return statement to WP_Filesystem_ftpsockets->rmdir 
Props tymvie.
Fixes #39405.


git-svn-id: https://develop.svn.wordpress.org/trunk@39644 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-28 03:51:29 +00:00
Dion Hulse a5bb301d0b Feeds: Replace the RSS2 lastBuildDate date field with the r date specifier. 
See #39141.


git-svn-id: https://develop.svn.wordpress.org/trunk@39614 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-16 06:41:45 +00:00
Dion Hulse 939e806ef1 Feeds: Do not translate the lastBuildDate field in RSS feeds. 
Props stevenkword, dd32.
Fixes #39141


git-svn-id: https://develop.svn.wordpress.org/trunk@39613 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-16 06:38:10 +00:00
Dion Hulse 0abe687fe8 Media: Move a variable definition outside of conditionals to ensure it's always available. 
This fixes cases where the URL to a PDF preview may be incorrectly calculated when no thumbnails were generated for the PDF (and avoids a PHP Notice at the same time).

Fixes #39250.


git-svn-id: https://develop.svn.wordpress.org/trunk@39612 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-16 06:20:40 +00:00
Dion Hulse 9e70bab188 Remove the WordPress version number from readme.html. 
See #35554 


git-svn-id: https://develop.svn.wordpress.org/trunk@39583 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-12 08:00:24 +00:00
Dion Hulse 24228daabf PDF Images: Avoid a PHP Warning when attempting to process a file without an extension. 
Props chandrapatel for initial patch.
Fixes #39195.


git-svn-id: https://develop.svn.wordpress.org/trunk@39580 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-12 06:18:30 +00:00
Dion Hulse caa1f1f88d Taxonomy: Restore the ability to use string-based $args in wp_get_object_terms(). 
Props tyxla.
Fixes #39215


git-svn-id: https://develop.svn.wordpress.org/trunk@39578 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-12 05:46:37 +00:00
Dion Hulse de13e89608 Bootstrap: Re-initialize any hooks added manually by object-cache.php. 
Prior to 3.1 if a object cache dropin wanted to add actions, they needed to use `$wp_filter` directly.

Props jorbin.
Fixes #39132.


git-svn-id: https://develop.svn.wordpress.org/trunk@39565 602fd350-edb4-49c9-b593-d223f7449a82
 2016-12-12 01:28:34 +00:00
Dion Hulse 2d854ef714 WP_Hook: Re-initialize any actions added directly to $wp_filter by advanced-cache.php. 
Props dd32, ocean90.
Fixes #38929.


git-svn-id: https://develop.svn.wordpress.org/trunk@39369 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-29 05:36:46 +00:00
Dion Hulse 6ade77e936 WP_HTTP: Map internal Requests hooks to WordPress actions. 
This change introduces a `requests-{$hook}` action which can be used to hook into Requests hooks, and restores the `http_api_curl` action.

Props rmccue.
Fixes #37843.


git-svn-id: https://develop.svn.wordpress.org/trunk@39212 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-13 10:35:15 +00:00
Dion Hulse 4404f32cb5 Updates: Allow background updates to update multiple plugins/themes in the same request. 
Due to the `clear_update_cache` parameter not being respected, update caches were being cleared incorrectly which prevented multiple plugins to be updated at the same time in background updates - failing with a `fs_unavailable` error message.

Fixes #38024


git-svn-id: https://develop.svn.wordpress.org/trunk@39211 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-13 09:52:49 +00:00
Dion Hulse 7e9960edad Posts, Post Types: Fix Quick Edit to correctly set the page template for non-hierarchical post types. 
Props dd32, swissspidy.
Fixes #38655.


git-svn-id: https://develop.svn.wordpress.org/trunk@39210 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-13 07:41:30 +00:00
Dion Hulse cacd16cf5d Themes: Update the unit tests to handle [39064] and #31550. 
`test_default_theme_in_default_theme_list()` was always being skipped after #31550, this causes it to once again check that the unit tests are up to date and include the latest default theme.
`test_default_themes_have_textdomain()` didn't play happy when a default theme wasn't installed on a site.

See #31550, #29925, #38551.


git-svn-id: https://develop.svn.wordpress.org/trunk@39065 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-01 03:13:27 +00:00
Dion Hulse b92ebd9e2d Upgrade: Install new themes upon upgrade again. 
This partially reverts [35738], which has shown to provide a bad user experience for users seeking to experiment with TwentySeventeen.

This will result in TwentySixteen being installed in addition to TwentySeventeen.

See #38551.


git-svn-id: https://develop.svn.wordpress.org/trunk@39064 602fd350-edb4-49c9-b593-d223f7449a82
 2016-11-01 01:23:17 +00:00
Dion Hulse 7e9848df2b Drop the requirement for the entry points to WordPress to be parsable by PHP4. 
Previously we ensured that the entry points to WordPress were parsable by PHP4 in order to display a friendly not-supported-php error message.
However, for the last two years the main entry points have not actually parsed, and we've only added extra parse errors since it last worked in 3.9, so it's time we just remove this 'feature'.
The PHP version checks are still there for PHP 5.0/5.1, and so it's inplace when we eventually drop PHP 5.2 support.

See #29489.


git-svn-id: https://develop.svn.wordpress.org/trunk@38899 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-25 03:14:31 +00:00
Dion Hulse 7aa09b6d24 Upgrade: Don't fail a core update just because readme.html or license.txt couldn't be modified. 
A number of locked down installs remove `readme.html` or make it inaccessible which would result in an update failure.

Props polevaultweb for the initial patch.
Fixes #31420.


git-svn-id: https://develop.svn.wordpress.org/trunk@38898 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-25 02:23:18 +00:00
Dion Hulse 7ae73a021a Revert the svn:ignore changes in [38394] which was missed in the original revert. 
See #36335


git-svn-id: https://develop.svn.wordpress.org/trunk@38896 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-25 01:12:03 +00:00
Dion Hulse 3df3b11e98 HTTP: Call mbstring_binary_safe_encoding() before making a request with Requests to avoid issues with mbstring.func_overload. 
Props SergeyBiryukov.
Fixes #38226.


git-svn-id: https://develop.svn.wordpress.org/trunk@38894 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-25 00:44:13 +00:00
Dion Hulse cedd323452 Docs: Correct a number of typos/spelling mistakes in inline comments. 
Props ottok.
Fixes #38464.


git-svn-id: https://develop.svn.wordpress.org/trunk@38893 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-25 00:37:50 +00:00
Dion Hulse 9ef4ac3567 Taxonomy: Avoid a fatal error in the_tags() in the event that get_the_term_list() returns a WP_Error. 
Props michalzuber.
See #37291.


git-svn-id: https://develop.svn.wordpress.org/trunk@38777 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-11 03:26:11 +00:00
Dion Hulse 0d33ec0b8e Updates: Remove the 'Download' button on the Updates screen. 
Props swissspidy.
Fixes #36811.


git-svn-id: https://develop.svn.wordpress.org/trunk@38736 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-06 01:05:15 +00:00
Dion Hulse b03af1ee40 HTTP: Document that the return value of wp_remote_retrieve_headers() changed from a simple array to an object which implements ArrayAccess. 
Props mrahmadawais, sudar, swissspidy.
Fixes #37722


git-svn-id: https://develop.svn.wordpress.org/trunk@38730 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-05 03:50:54 +00:00
Dion Hulse 1bd6d19f80 Plugins: Display 'Less Than 10' active installs of a plugin rather than '0+' active installs. 
Props ovann86.
Fixes #37509.


git-svn-id: https://develop.svn.wordpress.org/trunk@38729 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-05 03:32:41 +00:00
Dion Hulse 3586523daf HTTP: Update Requests to master (0048f3c) which fixes a number of outstanding issues. 
Fixes #38070, #37733 by reverting part of [38429] and using the fix in Requests.
Fixes #37992 allowing for connecting to SSL resources on ports other than 443.
Fixes #37991 by not sending default ports in the `Host:` header.
Fixes #37839 to match and decode Chunked responses correctly.
Fixes #38232 allowing a SSL connection to ignore the hostname of the certificate when verification is disabled.


git-svn-id: https://develop.svn.wordpress.org/trunk@38727 602fd350-edb4-49c9-b593-d223f7449a82
 2016-10-05 03:23:54 +00:00
Dion Hulse 0b67b63857 Query: Use AND in a SQL query rather than &&. 
This appears to have been the only instance of `&&` being used in SQL, so for consistency lets remove it.

Props scrappy@hub.org.
Fixes #37903.


git-svn-id: https://develop.svn.wordpress.org/trunk@38491 602fd350-edb4-49c9-b593-d223f7449a82
 2016-09-01 05:10:07 +00:00
Dion Hulse 9d70a4495d Bootstrap: Check that ini_get_all() exists before calling it, allows us to work around hosts who disable the function for "security purposes". 
Fixes #37680 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@38431 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-29 02:58:25 +00:00
Dion Hulse e916b9e14c HTTP: Accept non-string values in cookies, fixing a regression since 4.5. 
Props swissspidy.
Fixes #37768 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@38430 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-29 02:41:56 +00:00
Dion Hulse 7f2a81061a HTTP: Handle an edgecase within the URI parsing library included in Requests, where if a double slash exists at the start of the path the URL is passed to cURL malformed. 
Props flixos90 for initial patch.
Fixes #37733 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@38429 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-29 02:32:48 +00:00
Dion Hulse 7b275f6a07 i18n: Retire another remaining wp-includes/locale.php require, and instead load the required WP_Locale class directly. 
See #37827.


git-svn-id: https://develop.svn.wordpress.org/trunk@38404 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-27 15:12:18 +00:00
Dion Hulse e353179ce5 Bootstrap: Revert [38399] as it's broken /build/ and subsequently core.svn.wordpress.org. 
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.

See #36335


git-svn-id: https://develop.svn.wordpress.org/trunk@38402 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-27 14:36:42 +00:00
Dion Hulse 1e15f01687 Requests: Update to Requests master (fb5b517) which corrects a logic inversion in the cURL transport checks. 
Previously if a host had only disabled one of `curl_init()` or `curl_exec()` it wouldn't get detected correctly by Requests, which caused cURL warnings for users on an affecte dhost.

Fixes #37700 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@38274 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-18 03:47:55 +00:00
Dion Hulse 140f4914f2 Requests: Merge handling for custom HTTP methods. 
This merges the latest changes to Requests from upstream to add support for custom HTTP methods.
See https://github.com/rmccue/Requests/commit/1b5ffd8501503e0641b7fa0c555ccf99973135e2

Props Ipstenu, ocean90.
Fixes #37503 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@38191 602fd350-edb4-49c9-b593-d223f7449a82
 2016-08-04 07:13:41 +00:00
Dion Hulse dd472b7d2e Updates: Only use the filename component of URLs to form part of the temporary filename. 
Previously we were passing the entire URL to `wp_tempnam()` (incorrectly) which caused the query string to be used as part of the temporary filename.
We now only use the file component of a url such as `https://example.com/filename.zip?arg1=1&arg2=2....&arg100=100` to prevent a long filename.

Fixes #34938


git-svn-id: https://develop.svn.wordpress.org/trunk@37598 602fd350-edb4-49c9-b593-d223f7449a82
 2016-05-31 02:20:58 +00:00
Dion Hulse 5d9cdca116 IXR: Use a strict comparison to ensure that a non-numerically-indexed array is not incorrectly matched as a numeric array. 
See #36586


git-svn-id: https://develop.svn.wordpress.org/trunk@37244 602fd350-edb4-49c9-b593-d223f7449a82
 2016-04-19 06:12:42 +00:00
Dion Hulse 11082eea97 Tests: Remove debug from [36882]. 
git-svn-id: https://develop.svn.wordpress.org/trunk@36883 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-08 07:07:56 +00:00
Dion Hulse adcb0b5a4a Tests: Merge the two different wp_normalize_path() tests. 
See #35996, [36881].


git-svn-id: https://develop.svn.wordpress.org/trunk@36882 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-08 07:06:12 +00:00
Dion Hulse 8d9b0a9d22 Filesystem: Support Windows shares/DFS roots in wp_normalize_path(). 
Props rilwis for initial patch.
Fixes #35996.


git-svn-id: https://develop.svn.wordpress.org/trunk@36881 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-08 05:59:45 +00:00
Dion Hulse d32216787e oEmbed: During discovery, only request the first 150kb of linked content to avoid timouts requesting larger documents. 
Fixes #35979.


git-svn-id: https://develop.svn.wordpress.org/trunk@36880 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-08 05:57:13 +00:00
Dion Hulse e9dbf32553 Setup config: Generate the default secret keys & salts from the local CSPRNG if available, falling back to the WordPress.org API and a backup psuedo random source. 
Props diddledan.
Fixes #35290


git-svn-id: https://develop.svn.wordpress.org/trunk@36872 602fd350-edb4-49c9-b593-d223f7449a82
 2016-03-07 06:31:18 +00:00
Dion Hulse d707453bbc HTTP API: Certificate bundle: Attempt to move a certificate lower in the file to allow older OpenSSL versions to parse it & communicate with WordPress.org securely again. 
The OpenSSL version which was failing in this case was `OpenSSL 0.9.8e 23 Feb 2007`.

See #35637 #30434 #25007


git-svn-id: https://develop.svn.wordpress.org/trunk@36570 602fd350-edb4-49c9-b593-d223f7449a82
 2016-02-18 08:20:42 +00:00
Dion Hulse 3964f0ef33 Update Random_Compat to the latest version (1.1.6). 
See #35665


git-svn-id: https://develop.svn.wordpress.org/trunk@36421 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-30 00:56:07 +00:00
Dion Hulse b27ed68003 Menus: Remove a redundant and unused 0 parameter from the Delete Menu link on the nav menus admin screen. 
Fixes #35641.


git-svn-id: https://develop.svn.wordpress.org/trunk@36419 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-28 06:13:38 +00:00
Dion Hulse 51aee5ab1b Upgrade: Switch the locking mechanism to using static methods so that it can be accessed from other upgrade-classes. 
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36370 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-21 01:21:52 +00:00
Dion Hulse 65267f09fb Emoji: Work around a mod_security rule which prevents pages with 4 or more instances of String.fromCharCode( from being served. 
Fixes #35412 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@36359 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-20 07:39:47 +00:00
Dion Hulse 078b93863d Build Tools: Revert to using a human readable timestamp rather than the unix timestamp in [36315]. 
Fixes #28722


git-svn-id: https://develop.svn.wordpress.org/trunk@36351 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-20 02:01:57 +00:00
Dion Hulse b9e62671f6 Core Upgrader: Add a locking mechanism to avoid two concurrent updates of WordPress occuring. 
Fixes #34878


git-svn-id: https://develop.svn.wordpress.org/trunk@36349 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-19 05:06:46 +00:00
Dion Hulse 1dbc5b2918 CSS: Reference the original location of the CSS rule being overridden. 
See #35229


git-svn-id: https://develop.svn.wordpress.org/trunk@36342 602fd350-edb4-49c9-b593-d223f7449a82
 2016-01-18 09:58:21 +00:00