Commit Graph

42977 Commits

Author SHA1 Message Date
Sergey Biryukov
4a4d46fbe3 Docs: Use typed array notation for the $size parameter of embed_defaults filter.
Previously committed in [42876], accidentally reverted in [44154].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49698 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 12:12:46 +00:00
Peter Wilson
0addc4ac04 Build/Test Tools: Use dataProviders for some kses tests.
Refactor several kses tests to use dataProviers rather than looping through assertions.

See #51802.


git-svn-id: https://develop.svn.wordpress.org/trunk@49697 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 04:49:04 +00:00
Peter Wilson
95751aeec2 Build/Test Tools: Remove unused posts from AJAX test setUp().
Removes the creation of five posts from the AJAX test suite `setUp()` function, replacing it with a shared fixture only where required.

See #51802.


git-svn-id: https://develop.svn.wordpress.org/trunk@49696 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 04:09:41 +00:00
Robert Anderson
a86bedfc92 Editor: Remove render_block hooks from WP_Block
Reverts the move of pre_render_block, render_block_data, and
render_block_context to WP_Block.

This change has more implications than first thought so will be revisted later
in 5.7.

Reverts [49609,49608].
See #51612.


git-svn-id: https://develop.svn.wordpress.org/trunk@49695 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-25 01:18:25 +00:00
John Blackbourn
c8f7440c6a Docs: Upgrade more parameters in docblocks to used typed array notation.
See #51800, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@49693 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 21:25:46 +00:00
John Blackbourn
f2c9d2851c Docs: Various docblock corrections relating to parameter types.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49692 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 21:20:36 +00:00
Sergey Biryukov
c869ef617e Tests: Ignore EOL differences in WP_List_Table::get_bulk_items() test for optgroups.
This avoids a misleading failure due to Unix vs. Windows EOL style mismatches and allows the test to pass on Windows.

Follow-up to [46612], [49190].

See #19278.

git-svn-id: https://develop.svn.wordpress.org/trunk@49691 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 20:41:13 +00:00
Sergey Biryukov
d9976e94e2 Docs: Clarify that the $class argument of wp_list_bookmarks() can accept an array.
Follow-up to [32906].

See #51855, #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49688 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-24 12:27:49 +00:00
Sergey Biryukov
cf6c201446 Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.
Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Fixes #51813.

git-svn-id: https://develop.svn.wordpress.org/trunk@49685 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-23 19:33:48 +00:00
Sergey Biryukov
617097260d Plugins: Check if _error_nonce is set before attempting to verify it.
This avoids a PHP notice on the Plugins screen when `error` query string is added to the URL.

Props wponlinesupport.
Fixes #43876.

git-svn-id: https://develop.svn.wordpress.org/trunk@49683 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-23 13:34:21 +00:00
Sergey Biryukov
31315dd401 Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards.
Follow-up to [49677].

See #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49681 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:57:19 +00:00
Sergey Biryukov
8d7651fde1 Docs: Add documentation for the $type and $mime_type properties in WP_Customize_Image_Control.
Follow-up to [20319], [30309], [31698], [32023], [49679].

Props subrataemfluence.
Fixes #44411.

git-svn-id: https://develop.svn.wordpress.org/trunk@49680 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:50:35 +00:00
Sergey Biryukov
d8007597b3 Docs: Add documentation for the $type, $mime_type, and $button_labels properties in WP_Customize_Upload_Control.
Follow-up to [20319], [30309], [31698], [32023].

Props subrataemfluence.
See #44411.

git-svn-id: https://develop.svn.wordpress.org/trunk@49679 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:49:48 +00:00
Sergey Biryukov
dea4db7176 Docs: Correct @since tag for the class-wp-widget-area-customize-control.php file.
Per the documentation standards, the file header `@since` tag is supposed to specify when the file was introduced.

Follow-up to [35389].

See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49678 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 15:10:55 +00:00
Andrew Ozz
8e7ca8320e Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state.
Props jamesros161, pbiron, audrasjb, azaozz.
Fixes #51827.

git-svn-id: https://develop.svn.wordpress.org/trunk@49677 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-22 13:01:46 +00:00
Sergey Biryukov
6511b5817f Site Health: Check if $core_updates is an array before iterating on it.
This avoids a PHP warning if `get_core_updates()` returns `false`.

Props paulschreiber.
Fixes #51818.

git-svn-id: https://develop.svn.wordpress.org/trunk@49676 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 14:37:44 +00:00
Sergey Biryukov
b304faf343 Docs: Add missing @since tags for WP_Upgrader_Skin methods.
See #51800.

git-svn-id: https://develop.svn.wordpress.org/trunk@49675 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 12:06:34 +00:00
ryelle
23a8d5bcb2 Help/About: Clarify accessibility features.
* Captions are uploaded in the block editor, and not created in the editor.
* Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site.

Follow-up to [49640].
Props joedolson.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49674 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-21 00:11:48 +00:00
Sergey Biryukov
4f28c68eb6 Docs: Correct $fire_after_hooks parameter name in @since tags.
Follow-up to [49172], [49173].

See #45114.

git-svn-id: https://develop.svn.wordpress.org/trunk@49673 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-20 11:56:08 +00:00
John Blackbourn
a47e8924b0 Docs: Document parameters that accept an array of integers using typed array notation.
While many of these parameters also technically accept an array of numerical strings, they are all ultimately cast to an array of integers. Documenting them as such assists developers in understanding the expected types.

See #51800, #41756


git-svn-id: https://develop.svn.wordpress.org/trunk@49672 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 18:22:02 +00:00
John Blackbourn
4eeb1c3acf Docs: Add missing @since tags.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49671 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 17:52:52 +00:00
John Blackbourn
8b70c78281 Docs: Clarify and standardise on terminology used for rewrite rule endpoint masks.
See #51800


git-svn-id: https://develop.svn.wordpress.org/trunk@49670 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 16:13:54 +00:00
Sergey Biryukov
dff0ccf60a Docs: Use more specific type in parameter descriptions for in_category() and is_object_in_term().
This better aligns with `is_category()` and other conditional tags and their `WP_Query` counterpart methods.

Follow-up to [47402].

Props princeahmed.
Fixes #51825.

git-svn-id: https://develop.svn.wordpress.org/trunk@49669 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 15:18:28 +00:00
Sergey Biryukov
6884e1340d Coding Standards: Remove redundant isset() check in core_upgrade_preamble().
`isset()` can be safely used to check properties and subproperties of objects directly.

Follow-up to [49638].

See #51799.

git-svn-id: https://develop.svn.wordpress.org/trunk@49668 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-19 12:03:11 +00:00
Sergey Biryukov
72fe9fb127 Help/About: Correct placeholder for the accessibility statement feature plugin link.
Add missing translator comment.

Props audrasjb.
See #51415.

git-svn-id: https://develop.svn.wordpress.org/trunk@49651 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 15:49:31 +00:00
Sergey Biryukov
ab202d0148 Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Fixes #51815.

git-svn-id: https://develop.svn.wordpress.org/trunk@49650 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 15:02:07 +00:00
Andrew Ozz
874c87138e External Libraries: Update jQuery Migrate to 3.3.2.
Props mgol, azaozz.
Fixes #50564.

git-svn-id: https://develop.svn.wordpress.org/trunk@49649 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-18 09:04:26 +00:00
Helen Hou-Sandi
1f5ff2f169 Trunk is now really 5.7-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@49645 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:55:11 +00:00
Helen Hou-Sandi
b73f9fc5f6 Trunk is now 5.7-alpha.
git-svn-id: https://develop.svn.wordpress.org/trunk@49644 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:50:57 +00:00
Helen Hou-Sandi
af54a08642 Post WordPress 5.6 RC 1 version bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49642 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 22:37:48 +00:00
Helen Hou-Sandi
6d71eb492a WordPress 5.6 RC 1.
git-svn-id: https://develop.svn.wordpress.org/trunk@49641 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:59:53 +00:00
ryelle
efb664735f Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.



git-svn-id: https://develop.svn.wordpress.org/trunk@49640 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 21:32:16 +00:00
Sergey Biryukov
1a338a859b I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.

git-svn-id: https://develop.svn.wordpress.org/trunk@49639 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:50:21 +00:00
Helen Hou-Sandi
8372bbdfa5 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49638 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:26:32 +00:00
Sergey Biryukov
2486c13ee7 Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.

git-svn-id: https://develop.svn.wordpress.org/trunk@49637 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:07:57 +00:00
Jonathan Desrosiers
f6e265070d Build/Test Tools: Update the package.json engines to point to the new LTS versions of Node/NPM.
Props mkaz, jorbin.
Fixes #51749.

git-svn-id: https://develop.svn.wordpress.org/trunk@49636 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:28:21 +00:00
Sergey Biryukov
ee3585ac1e General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.

git-svn-id: https://develop.svn.wordpress.org/trunk@49635 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:19:37 +00:00
Jonathan Desrosiers
01ab2e9060 Build/Test Tools: Update several NPM dependencies.
These updates were applied when running `npm install`.

See #50769.

git-svn-id: https://develop.svn.wordpress.org/trunk@49634 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:17:29 +00:00
Jonathan Desrosiers
4f66a69d9e Twenty Twenty-One: Sync the latest changes for 5.6 RC1.
For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49633 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 18:58:52 +00:00
Sergey Biryukov
99d692ddfe App Passwords: Regenerate the .htaccess file to add a new rule.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.

git-svn-id: https://develop.svn.wordpress.org/trunk@49632 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 17:22:32 +00:00
Sergey Biryukov
62d0303bb1 Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique.
Follow-up to [48374].

Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai.
Fixes #51256.

git-svn-id: https://develop.svn.wordpress.org/trunk@49631 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 16:46:30 +00:00
Sergey Biryukov
22e4cb5266 Docs: Further remove tautology from comments in recurse_dirsize() tests.
Follow-up to [49212], [49616], [49628].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49630 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:48:07 +00:00
Sergey Biryukov
205c025c63 Multisite: Rename the calculate_current_dirsize filter to pre_recurse_dirsize.
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49629 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:42:57 +00:00
Sergey Biryukov
025ad3469b Docs: Adjust comments for recurse_dirsize() and related tests per the documentation standards.
Follow-up to [49212], [49616].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49628 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:36:02 +00:00
Sergey Biryukov
eb9fb00ee6 App Passwords: Add missing i18n for an error message.
Follow-up to [49617].

See #51513.

git-svn-id: https://develop.svn.wordpress.org/trunk@49627 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:19:29 +00:00
Sergey Biryukov
41decddb7f Docs: Document the $args parameter of wp_oembed_get().
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.

git-svn-id: https://develop.svn.wordpress.org/trunk@49626 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:09:12 +00:00
Robert Anderson
6b6a643b0b Customize: Temporary fix for autosave restore notice not being removed
Fixes the "There is a more recent autosave of your changes" notice from not
being removed when the dismiss button is clicked.

The problem is caused by the notice being initialized twice: once by the
`common` script and then again by the `customize-controls` script.

This temporary fix prevents `customize-controls` from initializing a notice if
it has already been initialized.

A better fix would be to not initialize notices twice. This can be done by
removing `common` as a dependency of `updates` when `deprecateL10nObject` is
removed.

When this happens (est: 5.7), this temporary fix should be reverted.

Fixes #51425.
See #51317.
Props karthikbhatb, dlh, SergeyBiryukov.


git-svn-id: https://develop.svn.wordpress.org/trunk@49625 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:43:33 +00:00
Robert Anderson
ac71fffac0 Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.


git-svn-id: https://develop.svn.wordpress.org/trunk@49624 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:29:02 +00:00
Robert Anderson
3b2097317e Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.


git-svn-id: https://develop.svn.wordpress.org/trunk@49623 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:11:04 +00:00
Peter Wilson
64ad8eb332 Permalinks: Prevent attachment pages 404ing following [49563].
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49622 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 03:27:07 +00:00