Gary Pendergast
7217a4f6e5
WPDB: ::strip_text_from_query() doesn't pass a length to ::strip_invalid_text(), which was causing queries to fail when they contained characters that needed to be sanity checked by MySQL.
...
Props dd32, mdawaffe, pento.
Fixes #32279 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33310 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 07:06:33 +00:00
Gary Pendergast
bea2bf1502
WPDB: Remove some of the complexities in ::strip_invalid_text() associated with switching character sets between queries. Instead of trying to dynamically change connection character sets, we now rely on the value of ::charset. This also fixes the case where queries were being blocked when DB_CHARSET was utf8, but the column character set was non-utf8.
...
Fixes #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33308 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-17 06:33:36 +00:00
Andrew Ozz
ce14a75784
wpLink: fix vertical alignment of the fields labels.
...
Part props daniluk4000. Fixes #32829 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33300 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 23:57:27 +00:00
Ella Iseulde Van Dorpe
c2c5c5ac27
Editor: word count: exclude shortcodes
...
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386 . See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33299 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 21:08:05 +00:00
Ella Iseulde Van Dorpe
03653fa600
Editor: Add Media should be a button
...
Props afercia.
Fixes #32969 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33298 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:37:07 +00:00
Helen Hou-Sandi
c40301f1a0
Customizer: Ensure consistent margins in sections.
...
Since the customizer dynamically changes, `nth-child` selectors are not always a great idea.
props afercia.
fixes #32902 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33297 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 19:14:31 +00:00
Boone Gorges
cddbfd2727
Improve function description for wp_transition_post_status().
...
The documentation should make it clear that the function does not modify the
post object in the database, but only fires hooks related to the transition.
Props AramZS.
Fixes #33014 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33296 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 14:34:42 +00:00
Ella Iseulde Van Dorpe
51e2bc173d
Editor: word count: remove redundant script enqueuing
...
It is now a dependency of `post`.
Part props johnjamesjacoby.
Fixes #31766 . See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33295 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 12:40:51 +00:00
Ella Iseulde Van Dorpe
795b2211fb
TinyMCE: inline toolbar: fix memory leaks
...
Part props ungestaltbar.
Fixes #32873 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33294 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 11:10:28 +00:00
Ella Iseulde Van Dorpe
524225187f
Editor: DFW: hide udate message
...
Props miqrogroove.
Fixes #32674 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33293 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 10:37:44 +00:00
Ella Iseulde Van Dorpe
129a3affe5
Editor: word count: exclude more characters
...
Also only exclude these characters for the `words` type. They should be counted for other types.
Add the ASCIIOnly option to the uglify config to preserve escaped unicode characters.
See #30966 . Fixes #27391 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33292 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-16 09:44:43 +00:00
Ella Iseulde Van Dorpe
4b975d8278
Editor: word count: update translator message
...
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33291 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:51:41 +00:00
iseulde
e1242b6979
Editor: word count: add all type
...
This type will count all characters including spaces.
See #30966 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33290 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:47:02 +00:00
Ella Iseulde Van Dorpe
302a039de1
TinyMCE: fix visual regressions (2)
...
See #32801 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33289 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 23:34:40 +00:00
Konstantin Obenland
149ab85049
4.3-beta3-33288
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33288 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:50:34 +00:00
Konstantin Obenland
ef95b71523
4.3-beta3
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33287 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:42:47 +00:00
Andrew Ozz
dc3565a6a1
TinyMCE, keyboard shortcuts help: make the popup wider to easily accommodate translations.
...
Part props ocean90. See #31441 ;
git-svn-id: https://develop.svn.wordpress.org/trunk@33286 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:33:45 +00:00
Ella Iseulde Van Dorpe
c0e3449295
TinyMCE: fix visual regressions
...
See #32801 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33285 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 21:30:09 +00:00
Helen Hou-Sandi
9c9b61e7da
Toolbar: Ensure icons are colored correctly in alternate schemes.
...
props ryelle.
fixes #32931 . see #29906 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33284 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:13:47 +00:00
Weston Ruter
bfe9cce7f2
Customizer: Defer updating nav menu item tabIndex attributes until pane is reflowed.
...
Introduces `pane-contents-reflowed` Customizer event.
Props valendesigns, westonruter.
Fixes #32943 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33283 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 20:04:41 +00:00
Weston Ruter
d9fcddae25
Customizer: Hide the transport list when it's empty, especially for screen readers.
...
Also prevent invalid markup for `.customize-section-description`.
Props valendesigns.
Fixes #32843 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33282 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:58:42 +00:00
Konstantin Obenland
8c36e7b3c4
Feeds: Revert [32765] because of objections raised in #4575 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@33281 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:57:47 +00:00
Konstantin Obenland
9352eb41fb
Customize: Provide a default way to save cropped images.
...
Allows plugins and themes to use `WP_Customize_Cropped_Image_Control` without
having to define their own way of saving the cropped image.
Props celloexpressions for initial patch.
Fixes #29211 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33280 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 19:53:23 +00:00
Weston Ruter
87b556a77a
Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
...
Also restores box shadow on focus.
Props valendesigns.
Fixes #32740 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33279 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 18:43:50 +00:00
Konstantin Obenland
140ff5cb9b
Properly clean up header image data when the attachment is deleted.
...
Props CreativeInfusion.
Fixes #33005 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33278 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 16:27:17 +00:00
Gary Pendergast
c160106af1
WPDB: When checking that text isn't too long to insert into a column, LONGTEXT columns could fail, as their length is longer than PHP_INT_MAX. Treating their length as a float instead of an int fixes this.
...
See #32165 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33276 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 04:32:55 +00:00
Konstantin Obenland
bd6c09724e
Update password meter to match new color guidelines.
...
See: https://make.wordpress.org/design/handbook/foundations/colors/
Props melchoyce.
Fixes #32986 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33275 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-15 00:11:50 +00:00
Drew Jaynes
c928758054
Docs: Update the DocBlock descriptions for a variety of template functions to better reflect that the dynamic $type_template hook can be used to filter the template path.
...
It's important to reference the actual dynamic hook name instead of an alias for purposes of auto-linking in the Code Reference.
Affects the docs for:
* `get_index_template()`
* `get_404_template()`
* `get_archive_template()`
* `get_post_type_archive_template()`
* `get_author_template()`
* `get_category_template()`
* `get_tag_template()`
* `get_taxonomy_template()`
* `get_date_template()`
* `get_home_template()`
* `get_page_template()`
* `get_paged_template()`
* `get_search_template()`
* `get_single_template()`
* `get_singular_template()`
* `get_attachment_template()`
See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33274 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 22:26:32 +00:00
Drew Jaynes
b55154c579
Docs: Clarify the hook docs for the {$type}_template hook to mention that non-alphanumeric characters delimiting words will also be removed from the passed $type parameter.
...
Also remove a now-unnecessary inline `@see` tag from the return description.
See #32246 . See #32989 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33273 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 22:11:52 +00:00
Drew Jaynes
7b91a81c4a
Update the descriptions for get_front_page_template() and get_comments_popup_template() to reference the correct dynamic hook names.
...
Part props @birgire.
Fixes #32989 . See #32246 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33272 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 21:58:16 +00:00
Scott Taylor
3d1f8f292a
After [33148]:
...
Don't nest `esc_attr()` and `htmlspecialchars()` when escaping the post title on the edit post screen.
Unrevert parts of [32851] and [32850].
Adds/alters unit tests.
Props miqrogroove.
Fixes #17780 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33271 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:55:07 +00:00
Scott Taylor
aee18d2d38
List Tables:
...
* In `->handle_row_actions()`, bail immediately if `$primary` and `$column_name` do not match. Saves us a nesting level and avoids declaring code that is unusable.
* In `WP_List_Table::single_row_columns()`, allow `_column_{$name}` to be called dynamically by core to avoid having to override the entirety of `->single_row_columns()` in `WP_MS_Users_List_Table` and `WP_Posts_List_Table`
* In `WP_MS_Sites_List_Table`, `id` is not a column.
Props wonderboymusic, paulwilde.
Fixes #29881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33270 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:46:13 +00:00
Konstantin Obenland
32bcd95e37
Media: Don't indent action links if there is no media icon.
...
See #32254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33269 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:45:55 +00:00
Konstantin Obenland
8ff5bc6f53
Media: Reduce link noise between icons and titles in list view.
...
Props afercia.
Fixes #32254 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33268 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 17:23:42 +00:00
Scott Taylor
b762b7da92
Monkey patch MediaElement to include a PR that restores responsive videos in Firefox:
...
https://github.com/johndyer/mediaelement/pull/1531
Props joemcgill.
Fixes #32722 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33267 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:29:37 +00:00
Helen Hou-Sandi
d651f599bf
List tables: Even more robust fallback for the primary column.
...
Since `WP_List_Table::get_default_primary_column()` can be overridden in a subclass and columns can be further filtered, it is possible to end up with a primary column that no longer exists. This is particularly evident in list tables for custom post types that have been altered via filter.
props ocean90.
fixes #32996 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33266 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:17:06 +00:00
Konstantin Obenland
f645e3767a
Login: Reflect new password flow in registration form.
...
Props Ipstenu.
Fixes #32428 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33265 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 16:07:46 +00:00
Konstantin Obenland
0db2e4e6f1
Use default parameter when getting the default avatar type.
...
Props johnjamesjacoby.
Fixes #32997 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33264 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:38:02 +00:00
Konstantin Obenland
3a696d7d91
Media: Remove post_type variable, unused since [32676].
...
Fixes #32948 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33263 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 15:05:29 +00:00
Boone Gorges
ce4b40d794
In wp_unique_post_slug(), only prevent date archive conflicts when the slug is being changed.
...
This prevents existing posts with numeric slugs from having their permalinks
changed on update.
Fixes #5305 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33262 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 12:27:11 +00:00
Boone Gorges
c718849baa
When creating a new post with an empty post_name and post_title, don't generate a post_name that conflicts with a date archive permalink.
...
See #5305 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33261 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 12:27:03 +00:00
Gary Pendergast
7711b72639
WPDB: When extracting the table name from a query, we had a 1000 character limit on the SQL string that would be searched. This was a hangover from when the code was imported from HyperDB, and isn't appropriate for Core, where a wider range of queries are likely to be run.
...
Fixes #32763
git-svn-id: https://develop.svn.wordpress.org/trunk@33259 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 10:18:57 +00:00
Dion Hulse
56c51da216
Updates: When performing an ajax plugin update, rely upon wp_update_plugins() to check the contents of the transient and return early if no request needs to be made.
...
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk
git-svn-id: https://develop.svn.wordpress.org/trunk@33257 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 08:00:31 +00:00
Weston Ruter
65f5a16611
Customizer: Improve performance of menus by caching results of wp_setup_nav_menu_item() calls.
...
Also fixes property list in phpdoc for `wp_setup_nav_menu_item()`.
Fixes #32769 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33256 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 07:08:40 +00:00
Jeremy Felt
33be338e9f
Tests: Use a data provider when testing site flags in update_blog_details().
...
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33255 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 06:38:19 +00:00
Jeremy Felt
76ef07903d
Tests: Use a data provider when testing path slashing in update_blog_details().
...
Trims down 11 tests to 1 clean area of testing and makes for a much saner read.
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33254 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 05:51:05 +00:00
Jeremy Felt
e3e828c608
Tests: Move update_blog_details() tests to their own file.
...
Reduce some of the clutter in `tests/multisite/site.php` and introduce `tests/multisite/updateBlogDetails.php`. Tests moved over are verbatum at this point.
See #32988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33253 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 05:49:28 +00:00
Konstantin Obenland
3bafaf7983
Editor: Center-align Publish/Update spinner on small-screen devices.
...
Props tywayne for initial patch.
Fixes #32947 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33252 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 04:01:10 +00:00
Konstantin Obenland
8560ac41f1
Password: Improve display of password meter on login screen.
...
Fixes #32925 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33251 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 03:31:35 +00:00
Boone Gorges
04237900a6
Require dependencies when appropriate in some unit test files.
...
Previously, attempting to run certain test files in isolation would resultin
fatal errors, as the parent classes had not been loaded.
Props isaacchapman.
Fixes #32984 .
git-svn-id: https://develop.svn.wordpress.org/trunk@33250 602fd350-edb4-49c9-b593-d223f7449a82
2015-07-14 03:07:13 +00:00