vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-28 20:50:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
30,870 Commits 1 Branch 0 Tags
797b6c4d7c15a3fe7835bcff81eedc7faf3d94de
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Dion Hulse 466500743f WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 
This fixes the 'The update cannot be installed because we will be unable to copy some files.' error encountered during updates by skipping the write test completely.

Props jobst.
Fixes #33480 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33688 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-21 11:42:04 +00:00
Dion Hulse f0ec4d5a7b Upgrades: When upgrading via FTP, use LIST -a to detect if a file exists. 
`LIST` & `NLST` by default on some servers require the `-a` flag to view hidden files (ie. `.maintenance`)
Although we could simply pass the `-a` flag to `NLST`, opting to use `LIST` which we use elsewhere should mean less chance of server incompatibilities.

Props jcroucher.
Fixes #28013.


git-svn-id: https://develop.svn.wordpress.org/trunk@33648 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 12:37:56 +00:00
Dion Hulse 63fd3a32dd Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33646 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 11:30:42 +00:00
Dion Hulse 26e7094951 Fix PHP notice after [33492] when updating themes. 
Props bobbingwide.
See #33208.
Fixes #33427.


git-svn-id: https://develop.svn.wordpress.org/trunk@33645 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-19 10:34:51 +00:00
Dion Hulse 7ef82c235a Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206


git-svn-id: https://develop.svn.wordpress.org/trunk@33597 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-09 02:21:11 +00:00
Dion Hulse 7a35bff916 Fix do_shortcode('<[shortcode]') edge case. 
Props miqrogroove.
Merges [33499] trunk.
See #33116.


git-svn-id: https://develop.svn.wordpress.org/trunk@33594 602fd350-edb4-49c9-b593-d223f7449a82
 2015-08-07 02:49:31 +00:00
Dion Hulse f9ec35ddab Switch to a more performant query in meta_form(). 
Props lumaraf, swissspidy, rarylson, pento
Fixes #24498


git-svn-id: https://develop.svn.wordpress.org/trunk@33390 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-23 05:16:04 +00:00
Dion Hulse 534386fcaf Allow HTML/entities in the Active Theme Name in the themes.php & Customizer templates. 
Props iCaleb
Fixes #33036


git-svn-id: https://develop.svn.wordpress.org/trunk@33327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-20 01:45:08 +00:00
Dion Hulse 56c51da216 Updates: When performing an ajax plugin update, rely upon wp_update_plugins() to check the contents of the transient and return early if no request needs to be made. 
This works around a bug where custom update handlers are injecting an update into an empty transient, malforming the transient and causing update failures.
Fixes #32198 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33257 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-14 08:00:31 +00:00
Dion Hulse 70ab756043 Ensure that Custom Links in menu's are marked as current regardless of their scheme. 
Props McGuive7, marsjaninzmarsa.
Fixes #32221


git-svn-id: https://develop.svn.wordpress.org/trunk@33103 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-07 09:56:19 +00:00
Dion Hulse 12168b78d5 Press This: Rewrite WP_Press_This::fetch_source_html() to utilise the HTTP API better without the need for a local temporary file. 
This reverts [33061] but keeps it's custom UA string.

See #32864


git-svn-id: https://develop.svn.wordpress.org/trunk@33062 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-03 12:00:10 +00:00
Dion Hulse 2fbb13be21 Don't upgrade global tables to utf8mb4 when wp_should_upgrade_global_tables() says not to. 
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154


git-svn-id: https://develop.svn.wordpress.org/trunk@33058 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-03 05:43:28 +00:00
Dion Hulse 947825f326 Introduce wp_should_upgrade_global_tables() to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines. 
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@33057 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-03 04:33:14 +00:00
Dion Hulse e709e91218 Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally. 
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@33055 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-03 03:25:07 +00:00
Dion Hulse 1cccb02930 Split upgrade_430() into two so that split_all_shared_terms() runs when upgrade_430_fix_comments() bails early. 
See [32814], #30261, [32364], #32165


git-svn-id: https://develop.svn.wordpress.org/trunk@33020 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 07:34:26 +00:00
Dion Hulse 5b58664439 Expire password reset links after 24 hours (by default). This causes existing password reset links to become invalid. 
Props markjaquith, voldemortensen, johnbillion, MikeHansenMe, dd32
See #32429


git-svn-id: https://develop.svn.wordpress.org/trunk@33019 602fd350-edb4-49c9-b593-d223f7449a82
 2015-07-01 06:32:07 +00:00
Dion Hulse 2959d58c91 XML-RPC: Only escape what we need to in wp.editPage, this allows for passwords with the special characters "' to work in a request. 
Props redsweater for initial Patch.
Fixes #32703


git-svn-id: https://develop.svn.wordpress.org/trunk@32993 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-29 02:06:25 +00:00
Dion Hulse b7127176a1 Remove an undeeded space concatenation from wpmu_validate_user_signup(). 
This was previously used to prevent `strpos()` returning 0, which is not needed after r32942.
See #32444


git-svn-id: https://develop.svn.wordpress.org/trunk@32950 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-26 01:38:25 +00:00
Dion Hulse b1b9db161f WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923. 
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32924 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-24 04:51:16 +00:00
Dion Hulse fc52d9cbb1 WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments 
Props mnelson4 for initial patch.
Fixes #29548


git-svn-id: https://develop.svn.wordpress.org/trunk@32923 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-24 04:48:18 +00:00
Dion Hulse 9c0750ac52 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process. 
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921


git-svn-id: https://develop.svn.wordpress.org/trunk@32854 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-19 03:48:55 +00:00
Dion Hulse 4ff7f27c83 Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32852 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-19 03:17:12 +00:00
Dion Hulse f5a914218d Add a filter to wp_safe_redirect() for the fallback URL. 
Props anubisthejackle. Fixes #22612


git-svn-id: https://develop.svn.wordpress.org/trunk@32793 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-16 05:25:32 +00:00
Dion Hulse 9f2ad2538e Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key. 
Props mordauk. Fixes #31784


git-svn-id: https://develop.svn.wordpress.org/trunk@32784 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 06:25:58 +00:00
Dion Hulse 8455dd10da Updats: Add a filter for the options params for the update being performed. 
Props nofearinc. Fixes #27754


git-svn-id: https://develop.svn.wordpress.org/trunk@32783 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 05:34:52 +00:00
Dion Hulse 5b607d7ff6 Updates: Allow the update row to include the active border styling post-ajax update. 
Props TobiasBg. Fixes #32129


git-svn-id: https://develop.svn.wordpress.org/trunk@32782 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 05:12:41 +00:00
Dion Hulse 4f8b348c9b Updates: Remove redundant title tags from update outputs. 
Props afercia. Fixes #32530


git-svn-id: https://develop.svn.wordpress.org/trunk@32781 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 05:08:48 +00:00
Dion Hulse 672f394b57 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin. 
Props magicroundabout. Fixes #32110 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@32780 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 04:27:37 +00:00
Dion Hulse a5ed63c86f Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners. 
Fixes #32435, #32473


git-svn-id: https://develop.svn.wordpress.org/trunk@32779 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 03:47:54 +00:00
Dion Hulse 5a33c20515 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message. 
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32778 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 03:31:40 +00:00
Dion Hulse 7805a509f3 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler. 
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32777 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 03:19:30 +00:00
Dion Hulse d72005f6d0 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers. 
See #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32776 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-15 02:47:19 +00:00
Dion Hulse 671218ac1d SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions. 
See #32345


git-svn-id: https://develop.svn.wordpress.org/trunk@32726 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-12 06:30:58 +00:00
Dion Hulse 306d8b6a1e WP_HTTP: ensure that the temporary file is created within the temporary directly when stream is specified without a filename parameter. 
Fixes #32549


git-svn-id: https://develop.svn.wordpress.org/trunk@32712 602fd350-edb4-49c9-b593-d223f7449a82
 2015-06-09 03:54:49 +00:00
Dion Hulse d8dc5d9f63 Updates: Correctly identify more failed update cases. This checks for a WP_Error being raised during an individual update, in addition to just the bootstrap error cases. 
The error message in these cases is still not displayed in the UI.

See #32473, #32435


git-svn-id: https://develop.svn.wordpress.org/trunk@32571 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 08:44:09 +00:00
Dion Hulse 8d64dc4e6b Shiny Updates: Handle the case where the plugin is installed into a different directory than it previously existed in. 
A good example of this is when the plugin being updated is currently installed as 'Plugin-Name' but the canonical directory is 'plugin-name', but it can also occur when the plugin is installed in 'super-cool-plugin' and it's canonical name is 'average-plugin'.

Fixes #32465 for trunk


git-svn-id: https://develop.svn.wordpress.org/trunk@32570 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-24 08:04:55 +00:00
Dion Hulse 047c2fdadd Allow plugins to activate other plugins within their Activation hook. Fixes #32368 
git-svn-id: https://develop.svn.wordpress.org/trunk@32504 602fd350-edb4-49c9-b593-d223f7449a82
 2015-05-14 06:57:47 +00:00
Dion Hulse 342989657f When creating a temporary file treat the / directory properly, to prevent it ending up in an endless self-calling loop. 
Props hnle, taka2. Fixes #32135. See #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@32322 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-29 03:16:06 +00:00
Dion Hulse 248c73b1cf Plugins Browser: Replace the download count with the number of Active installs of the plugin. 
Fixes #31865


git-svn-id: https://develop.svn.wordpress.org/trunk@31990 602fd350-edb4-49c9-b593-d223f7449a82
 2015-04-02 23:48:26 +00:00
Dion Hulse 9ce354f534 Tests: Clean up the resulting /tmp/foo* files from the tempnam call. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31937 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-31 02:10:52 +00:00
Dion Hulse 842d6a9b39 Add some logic into wp_tempnam to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress. 
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811


git-svn-id: https://develop.svn.wordpress.org/trunk@31936 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-31 02:10:06 +00:00
Dion Hulse b179fe8e95 When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL. 
Fixes #31758. See #23367


git-svn-id: https://develop.svn.wordpress.org/trunk@31882 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-25 04:31:21 +00:00
Dion Hulse f0849242d3 Upgrader: When creating a temporary working directory, strip off .tmp as well as .zip incase we end up using that directory as the items main directory. 
Fixes #30945


git-svn-id: https://develop.svn.wordpress.org/trunk@31863 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-23 04:39:56 +00:00
Dion Hulse 9eb9342a54 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified. 
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121


git-svn-id: https://develop.svn.wordpress.org/trunk@31862 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-23 02:13:50 +00:00
Dion Hulse 1f90e70b7d Fix the editable_slug hook documentation, the PHPDoc must come directly before the hook call, with no HTML inbetween. 
Props DrewAPicture. Fixes #31569


git-svn-id: https://develop.svn.wordpress.org/trunk@31687 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-09 06:42:58 +00:00
Dion Hulse b96b1db015 SSH2 Upgrade transport: Trim the trailing newline character from the ouput of pwd to avoid a PHP Segfault. 
Fixes #30802 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31686 602fd350-edb4-49c9-b593-d223f7449a82
 2015-03-09 04:31:21 +00:00
Dion Hulse ced1630496 Upgrades: Specifically pass the 'version' and 'locale' POST vars through the Core Update FTP credentials form. 
This bug was introduced with [30384] / #30245
Fixes #31378 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31527 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-24 03:00:54 +00:00
Dion Hulse afef491a75 Avoid a PHP Warning when add_args is passed as false to paginate_links(). 
Props boonebgorges for the unit test.
See #30831 [31203].


git-svn-id: https://develop.svn.wordpress.org/trunk@31432 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-12 01:38:26 +00:00
Dion Hulse d17168583d Prevent IE9 and lower displaying the download file dialogue when attempting to upload using the html4 Plupload handler. 
The HTML4 Plupload handler uses a hidden iframe to POST the upload form,
Unfortunately Internet Explorer 9 doesn't support the `application/json` 
content-type which `wp_send_json_success()` and requires `text/html` instead.

This partially reverts [30354], keeping the better error messages.

Fixes #31037 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31429 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-12 01:14:47 +00:00
Dion Hulse 0d65892e29 Updates: Display plugin update rows even for plugins which are not hosted by WordPress.org or the HTTP request times out on. 
See #29583.
Fixes #30767 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@31382 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-09 06:31:18 +00:00
Dion Hulse 5811dcbcd6 Remove an extra indent from most of media-new.php. 
git-svn-id: https://develop.svn.wordpress.org/trunk@31328 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-03 07:46:21 +00:00
Dion Hulse 4ed2d89ced WP_Upgrader: Remove references to non-existant variables that have never existed. 
Props jdgrimes. Fixes  #29087


git-svn-id: https://develop.svn.wordpress.org/trunk@31327 602fd350-edb4-49c9-b593-d223f7449a82
 2015-02-03 06:17:05 +00:00
Dion Hulse db3a49f8c8 HTTP API: Fix an issue where the limit_response_size parameter wasn't working properly with large documents and the cURL transport. 
Fixes #31172


git-svn-id: https://develop.svn.wordpress.org/trunk@31290 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-29 03:57:42 +00:00
Dion Hulse 32b020bf05 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.


git-svn-id: https://develop.svn.wordpress.org/trunk@31160 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:32:35 +00:00
Dion Hulse 0aaa2f0f32 The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns


git-svn-id: https://develop.svn.wordpress.org/trunk@31159 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-12 04:30:01 +00:00
Dion Hulse d0767caf54 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis


git-svn-id: https://develop.svn.wordpress.org/trunk@31089 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-08 06:46:55 +00:00
Dion Hulse 8cce0f1607 Preinitialize WP_User::$data to an object in the event an empty user object is created. Avoids a "Creating default object from empty value" PHP Warning. 
Fixes #28019


git-svn-id: https://develop.svn.wordpress.org/trunk@31049 602fd350-edb4-49c9-b593-d223f7449a82
 2015-01-05 01:40:43 +00:00
Dion Hulse c34913eae6 Add a revision number to $wp_version for nightly update purposes. See [30411] 
git-svn-id: https://develop.svn.wordpress.org/trunk@31007 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-31 05:34:07 +00:00
Dion Hulse 1e721a144b Add braces around a Docblock in an if statement, although not required by PHP, this is required by our coding standards for readability. 
Introduced in 3.9 with r27365
See #25905


git-svn-id: https://develop.svn.wordpress.org/trunk@30886 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-16 05:51:49 +00:00
Dion Hulse 28e22a4ec4 Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API. 
See #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30860 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-15 14:07:35 +00:00
Dion Hulse 8a5ea24f61 In the links_add_base() callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems. 
Fixes #29950


git-svn-id: https://develop.svn.wordpress.org/trunk@30766 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 03:18:06 +00:00
Dion Hulse 1a43dda77b WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites. 
See #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@30765 602fd350-edb4-49c9-b593-d223f7449a82
 2014-12-07 03:12:14 +00:00
Dion Hulse 01b2c45025 Fix the PHPDoc example for _split_str_by_whitespace(). 
Props voldemortensen. Fixes #30504


git-svn-id: https://develop.svn.wordpress.org/trunk@30575 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-26 03:51:48 +00:00
Dion Hulse 1c11d73f72 Update the bundled root CA's used for outgoing HTTPS requests. 
Fixes #30434


git-svn-id: https://develop.svn.wordpress.org/trunk@30491 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-21 03:02:11 +00:00
Dion Hulse 54dff60079 Bump the $wp_version. 
This version string controls more than you might first imagine, but the important thing to note for now, is that this needs to contain a revision number in order for nightly builds to include a revision number.
If a nightly build doesn't include a revision number, Background Updates won't occur for Development users (after all, 4.1-beta1 == 4.1-beta1, which is already installed).
See #30405


git-svn-id: https://develop.svn.wordpress.org/trunk@30411 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-20 11:35:07 +00:00
Dion Hulse 9d0c957410 Background Updates: Introduce support to take advantage of Group Writable (or World Writable) to Core Background updates. 
This is only enabled when new files will not be installed during the update (as indicated by the WordPress.org API), and does not apply to Plugin/Theme/Translation Background Updates.

Additionally, the code to determine if the 'direct' filesystem transport should be used has been tweaked for wider support (where getmyuid() was unavailalbe) which fixes #10424

See #10205, #30245


git-svn-id: https://develop.svn.wordpress.org/trunk@30384 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-19 05:39:52 +00:00
Dion Hulse 42c5d77b8c Remove a stray translator comment for a non-translatable string added in [30209] See #27238 
git-svn-id: https://develop.svn.wordpress.org/trunk@30365 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-17 04:35:36 +00:00
Dion Hulse e542c7f7b6 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628 
git-svn-id: https://develop.svn.wordpress.org/trunk@30311 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-12 10:43:09 +00:00
Dion Hulse 14d164397a Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally. 
See #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@30310 602fd350-edb4-49c9-b593-d223f7449a82
 2014-11-12 03:05:31 +00:00
Dion Hulse f2b727f333 Filesystem: Fix the move() method of the SSH2 transport, which was using the SSH2 link rather than the SFTP link. 
Props nobleclem. Fixes #29405


git-svn-id: https://develop.svn.wordpress.org/trunk@29970 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 07:45:52 +00:00
Dion Hulse 98c438048d Avoid a PHP Notice in the PemFTP Library by adding a missing function parameter. This parameter is unused by WordPress. 
Props hugodelgado. Fixes #29628


git-svn-id: https://develop.svn.wordpress.org/trunk@29969 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 07:40:41 +00:00
Dion Hulse 5bcbdefd2e HTTP API: Support both the 'limit_response_size' and 'stream' parameters at the same time, allowing a partial file download. 
Fixes #26726


git-svn-id: https://develop.svn.wordpress.org/trunk@29968 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-20 07:31:45 +00:00
Dion Hulse 8ff133f232 Add some unit tests for WP_HTTP::parse_url() to cover the <PHP 5.4.7 compatibility alterations. 
These unit tests cover the expected vehaviour of certain combinations of URL's, but makes no attempt to test invalid URL structures, as PHP's behavious for invalid URL's is undefined (Some will be treated as paths, others fail, and it varies between PHP 5.4.7+ and <5.4.7).
This change also makes WP_HTTP::parse_url() protected in order to allow unit testing.
See #28001, #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29864 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-09 03:00:16 +00:00
Dion Hulse c8b53c2d1a Handle deficiencies in PHP's parse_url in older versions of PHP (<5.4.7) in WP_HTTP::make_absolute_url(). 
In older versions of PHP:
- parse_url() will fail to parse a url where the scheme break (://) is present in a relative URL's path
- parse_url() will include the hostname of a schemeless URL in the path component

This handles those two types of URL's by correcting the response from parse_url().

Fixes #28001, #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29861 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-09 01:10:25 +00:00
Dion Hulse eb39c8f75d Avoid a PHP Notice when requesting a url without a path component (http://example.com) in the Streams HTTP component. 
Props barrykooij for inital patch; Fixes #27668


git-svn-id: https://develop.svn.wordpress.org/trunk@29853 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 06:43:14 +00:00
Dion Hulse 45cd55bfc4 When making a HTTP request to a non-standard port, include the port in the Host header for the Streams HTTP transport. This bring parity to the cURL transport and respects the HTTP RFC. 
Props kamelkev for the initial patch; Fixes #28982


git-svn-id: https://develop.svn.wordpress.org/trunk@29852 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 06:14:58 +00:00
Dion Hulse 4ae1397f96 Correctly support Schemeless URLs in WP_HTTP::make_absolute_url() by respecting the 'host' field if present in the relative url. 
Fixes #29886


git-svn-id: https://develop.svn.wordpress.org/trunk@29851 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 05:57:15 +00:00
Dion Hulse e4268adfde Correctly handle url's containing url's in WP_HTTP::make_absolute_url(). 
A valid relative URL could be mistaken for an absolute url if it contained a :// in any position of the url.
Fixes #28001


git-svn-id: https://develop.svn.wordpress.org/trunk@29850 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 05:37:56 +00:00
Dion Hulse 60b8ed120a Always cast the 'code' server response to an int, this provides consistency between both of the HTTP transports. 
Previously cURL would return an int and Streams a numeric string.
Fixes #28887


git-svn-id: https://develop.svn.wordpress.org/trunk@29849 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 05:20:01 +00:00
Dion Hulse 2ed0d6cae0 Return the correct server response for the 'message' response field from the server. 
Previously this would use the generic message corresponding to the response code, which isn't always accurate. Since we're already parsing the headers, we can simply return that directly (This also has the benefit that it's the same code for both Streams and Curl header handling).
Fixes #28919


git-svn-id: https://develop.svn.wordpress.org/trunk@29848 602fd350-edb4-49c9-b593-d223f7449a82
 2014-10-08 05:18:22 +00:00
Dion Hulse a01096b872 Language Pack Upgrader: Remove ALL pre-existing filters before performing a translation update these filters may act in an unexpected way during the upgrade process. 
See #29230. Fixes #29425.


git-svn-id: https://develop.svn.wordpress.org/trunk@29685 602fd350-edb4-49c9-b593-d223f7449a82
 2014-09-03 05:37:33 +00:00
Dion Hulse 60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 10:56:56 +00:00
Dion Hulse ce76432676 Background Updates: Fix a PHP Warning caused by a Upgrader instance being passed into the Theme & Plugin $extra_stats parameter. See #27633 
git-svn-id: https://develop.svn.wordpress.org/trunk@27928 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 05:32:02 +00:00
Dion Hulse c86d9021c5 Background Updates: Fix two variable typos in r27905 
git-svn-id: https://develop.svn.wordpress.org/trunk@27906 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 13:12:28 +00:00
Dion Hulse 48025fabd5 Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
git-svn-id: https://develop.svn.wordpress.org/trunk@27905 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-02 13:04:30 +00:00
Dion Hulse 526bf7d352 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
git-svn-id: https://develop.svn.wordpress.org/trunk@27546 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-15 03:08:47 +00:00
Dion Hulse db9eb328e3 Upgrader: Remove more debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27339 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:05:02 +00:00
Dion Hulse e98848a3c6 Upgrader: Remove some debug from r27336. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27338 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:03:55 +00:00
Dion Hulse 18364c9625 Upgrader: Remove two stray spaces. See #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27337 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:01:28 +00:00
Dion Hulse 14b4579d98 Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860 
git-svn-id: https://develop.svn.wordpress.org/trunk@27336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-03-01 06:00:47 +00:00
Dion Hulse 6cc978fed7 WP_HTTP: Update the Root Certificate bundle used for SSL communication by WP_HTTP. 
This file has been generated from the latest mozilla release NSS.
Fixes #27017


git-svn-id: https://develop.svn.wordpress.org/trunk@27307 602fd350-edb4-49c9-b593-d223f7449a82
 2014-02-27 02:32:57 +00:00
Dion Hulse 3428afee5a Uploads: Fix the Order of Operations for wp_mkdir_p() which caused this branch to never be hit. Props fboender. Fixes #26781 for trunk. See #25822 
git-svn-id: https://develop.svn.wordpress.org/trunk@26926 602fd350-edb4-49c9-b593-d223f7449a82
 2014-01-08 23:12:37 +00:00
Dion Hulse 457e59656a Cron: Fix a case where a cache inconsistency can cause wp_clear_scheduled_hook() to enter an infinite loop. This unravels the function from using other cron api functions to looping over the cron array directly. See #25773 
git-svn-id: https://develop.svn.wordpress.org/trunk@26782 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-07 09:12:51 +00:00
Dion Hulse 22738bc3d5 Remove the experimental RSS.JS feed, and move it to a plugin for feature development. Unprops pento. See #25639 
git-svn-id: https://develop.svn.wordpress.org/trunk@26644 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-04 22:23:02 +00:00
Dion Hulse 49c57fa9b9 Themes: Update the CSS definitions in the SCSS files to be as specific as the base CSS rules. See #25948, #25966 
git-svn-id: https://develop.svn.wordpress.org/trunk@26551 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-03 02:10:29 +00:00
Dion Hulse dd5f228729 Themes: Update notifiations shouldn't be a <a> if they're not links, data.update already contains <p> tags. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26524 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 08:37:58 +00:00
Dion Hulse 4a62bbe5d8 Themes: Standardise on dot notation for object access in the Templates. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26523 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:33:57 +00:00
Dion Hulse ca6e76914f Themes: Remove some HTML from a new string and put it in the replacement value instead. See #25948 
git-svn-id: https://develop.svn.wordpress.org/trunk@26522 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:19:40 +00:00
Dion Hulse 63a4a1b10c Themes: Bail if the search term matches the currently rendered themes, Fixes the events being clobbered. Props jblz. Fixes #26347 
git-svn-id: https://develop.svn.wordpress.org/trunk@26521 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:15:14 +00:00
Dion Hulse 91b903fb6d Themes: Indent the HTML for proper indentation after r26519 added an extra div. See #25961, #26192 
git-svn-id: https://develop.svn.wordpress.org/trunk@26520 602fd350-edb4-49c9-b593-d223f7449a82
 2013-12-02 07:13:11 +00:00