vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-05-25 21:54:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,001 Commits 1 Branch 0 Tags
81acc423619ca357d17f5f7dbf158b039b68aa9b
Commit Graph

519 Commits

Author SHA1 Message Date
Scott Taylor
3ed59ca164 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28305 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:26:47 +00:00
Scott Taylor
74ad050063 In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28304 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:20:10 +00:00
Scott Taylor
fb1054340f In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28303 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:13:30 +00:00
Scott Taylor
b64da2cb60 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28302 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 17:10:41 +00:00
Scott Taylor
5d2b452351 In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28301 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:59:29 +00:00
Scott Taylor
ffa620b972 In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28300 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:54:10 +00:00
Scott Taylor
e518d0d652 In update_option_new_admin_email(), $email is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28299 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:47:56 +00:00
Scott Taylor
ee13be0315 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28298 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:44:38 +00:00
Scott Taylor
d92f5aa154 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28297 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 16:40:52 +00:00
Scott Taylor
fc624a4298 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28296 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:32:16 +00:00
Scott Taylor
1e68b7dab4 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28295 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:29:22 +00:00
Scott Taylor
36abe7909c In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28293 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:26:32 +00:00
Scott Taylor
41d1eb8f56 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28292 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 15:18:42 +00:00
Sergey Biryukov
4b8b0e7178 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.

git-svn-id: https://develop.svn.wordpress.org/trunk@28287 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 12:33:08 +00:00
Scott Taylor
555937dc43 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28279 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:07 +00:00
Scott Taylor
f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:44:56 +00:00
Scott Taylor
e42ec45553 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:21:35 +00:00
Scott Taylor
f97deae591 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:44:30 +00:00
Scott Taylor
4c6f405ee7 Remove a dead variable, $start, from wp_dashboard_recent_comments(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:34:22 +00:00
Andrew Nacin
4b6d5b10d4 Move 'home' option to the top of populate_options(). 
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 21:56:11 +00:00
Sergey Biryukov
819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 10:23:16 +00:00
Sergey Biryukov
3e482eb905 Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.

git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 08:25:46 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
379f725bde Ensure the wp_edit_nav_menu_walker filter is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28213 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:49:48 +00:00
Drew Jaynes (DrewAPicture)
7a0eb63a19 Ensure the nav_menu_meta_box_object filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28207 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:13:15 +00:00
Andrew Nacin
77c11f6cc9 Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28163 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:17:12 +00:00
Andrew Nacin
aeef0e992a Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:37:59 +00:00
Dion Hulse
60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 10:56:56 +00:00
Andrew Nacin
0437f710a5 Allow the API to add text to auto update emails. 
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:51:23 +00:00
Andrew Nacin
7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:15:43 +00:00
Andrew Nacin
32721b8347 Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 07:47:10 +00:00
Andrew Ozz
bff230b422 Plupload: restore the settings in media_upload_form(), see #27763 
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:40:45 +00:00
Andrew Nacin
c43b8b063d Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:59:01 +00:00
Andrew Nacin
7a25da5240 The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28093 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:52:35 +00:00
Andrew Nacin
863116a5d2 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28090 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:12 +00:00
Andrew Nacin
6c0420348e Update $_old_files for 3.9. see #27775. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28085 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:26:25 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Andrew Nacin
2d9949bf91 Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@28072 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:09:35 +00:00
Drew Jaynes (DrewAPicture)
93b19f682e Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.


git-svn-id: https://develop.svn.wordpress.org/trunk@28040 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 06:25:56 +00:00
Andrew Nacin
d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-08 04:30:01 +00:00
Drew Jaynes (DrewAPicture)
4d4921a9ac Use the correct parameter variables in the hook docs for wp_upgrade. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27998 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:13:00 +00:00
Drew Jaynes (DrewAPicture)
3b7d881f3c Align parameters in the hook docs for the attachment_thumbnail_args filter. 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27997 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:10:01 +00:00
Drew Jaynes (DrewAPicture)
95294a170e Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count(). 
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27996 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 20:01:35 +00:00
Andrew Nacin
06152cbe6f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27990 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-07 17:58:37 +00:00
Andrew Nacin
3fbe1ba7b7 Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27975 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-06 22:07:02 +00:00
Drew Jaynes (DrewAPicture)
789305948e Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.


git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 22:29:41 +00:00
Andrew Nacin
14d96748c7 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-05 21:18:44 +00:00
Sergey Biryukov
96563b4143 Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:22 +00:00
Sergey Biryukov
a97e9018c4 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-04 00:02:12 +00:00
Sergey Biryukov
ed139644be Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.

git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-03 09:45:44 +00:00