Commit Graph
10937 Commits
Author SHA1 Message Date
Helen Hou-Sandi 8372bbdfa5 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.


git-svn-id: https://develop.svn.wordpress.org/trunk@49638 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:26:32 +00:00
Sergey Biryukov 2486c13ee7 Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.

git-svn-id: https://develop.svn.wordpress.org/trunk@49637 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 20:07:57 +00:00
Sergey Biryukov ee3585ac1e General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.

git-svn-id: https://develop.svn.wordpress.org/trunk@49635 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 19:19:37 +00:00
Sergey Biryukov 99d692ddfe App Passwords: Regenerate the .htaccess file to add a new rule.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems.

This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6.

Follow-up to [49534].

Props pbiron, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51723.

git-svn-id: https://develop.svn.wordpress.org/trunk@49632 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 17:22:32 +00:00
Sergey Biryukov 205c025c63 Multisite: Rename the calculate_current_dirsize filter to pre_recurse_dirsize.
Set the default value to `false`. This brings some consistency with the `pre_get_space_used` filter.

Follow-up to [49212], [49616], [49628].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49629 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:42:57 +00:00
Sergey Biryukov 025ad3469b Docs: Adjust comments for recurse_dirsize() and related tests per the documentation standards.
Follow-up to [49212], [49616].

See #19879.

git-svn-id: https://develop.svn.wordpress.org/trunk@49628 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 15:36:02 +00:00
Sergey Biryukov eb9fb00ee6 App Passwords: Add missing i18n for an error message.
Follow-up to [49617].

See #51513.

git-svn-id: https://develop.svn.wordpress.org/trunk@49627 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:19:29 +00:00
Sergey Biryukov 41decddb7f Docs: Document the $args parameter of wp_oembed_get().
Link to `wp_oembed_get()` as the canonical source when documenting additional arguments in various `WP_oEmbed` methods.

Follow-up to [49620].

See #51269.

git-svn-id: https://develop.svn.wordpress.org/trunk@49626 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 10:09:12 +00:00
Robert Anderson ac71fffac0 Customize: Ensure multiple CSS classes are passed to nav_menu_link_attributes as an array
When multiple CSS classes are added to a menu item, the nav_menu_link_attributes
filter should be called with $item->classes set to an array of CSS class names.

When previewing in the Customizer, however, a single string was being passed to
$item->classes because WP_Customize_Nav_Menu_Item_Setting::preview() bypasses
wp_update_nav_menu_item() and instead uses filter_wp_get_nav_menu_items().

The fix is to make filter_wp_get_nav_menu_items() match what
wp_update_nav_menu_item() does and split the string into an array.

Fixes #43113.
Props dlh.


git-svn-id: https://develop.svn.wordpress.org/trunk@49624 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:29:02 +00:00
Robert Anderson 3b2097317e Editor: Update WordPress packages for RC1
@wordpress/block-directory: 1.17.3 -> 1.17.4
@wordpress/block-library: 2.26.3 -> 2.26.4
@wordpress/edit-post: 3.25.3 -> 3.25.4

Fixes #51793.
Props isabel_brison.


git-svn-id: https://develop.svn.wordpress.org/trunk@49623 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 04:11:04 +00:00
Peter Wilson 64ad8eb332 Permalinks: Prevent attachment pages 404ing following [49563].
This largely reverts [49563] due to attachment pages returning 404: File not found errors when they use the `inherit` status.

Permalink changes to attachment pages are retained when they are descendants of trashed or deleted posts.

Props Toro_Unit, helen, johnbillion, peterwilsoncc.
Fixes #51776.
See #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49622 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 03:27:07 +00:00
Jonathan Desrosiers 828ee6c1ed Code Modernization: Only call libxml_disable_entity_loader() in PHP < 8.
This function has been deprecated in PHP 8.0 because in libxml 2.9.0, external entity loading is disabled by default, so this function is no longer needed to protect against XXE attacks.

This change fixes an instance of `libxml_disable_entity_loader()` within the getID3 library that has not yet been included in a tagged release for the library.

Props jrf, hellofromtonya.
Fixes #50898.

git-svn-id: https://develop.svn.wordpress.org/trunk@49621 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-17 00:58:33 +00:00
Helen Hou-Sandi 4fcdd01f33 Embeds: Document $args in wp_oembed_get().
Props hellofromTonya, audrasjb, SergeyBiryukov.
Fixes #51269.


git-svn-id: https://develop.svn.wordpress.org/trunk@49620 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 23:11:21 +00:00
Jake Spurlock 4b8faba8db Feeds: Add an early exit when calling RSS functions directly.
While this file is depracated, it shouldn't throw errors when called directly.

Fixes #35835.

Props thib3113, dd32, TheGP, flymike, zodiac1978, williampatton.


git-svn-id: https://develop.svn.wordpress.org/trunk@49619 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:50:03 +00:00
Timothy Jacobs ba8de96fc6 App Passwords: Unify availability language.
Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available".

Additionally, we now use a 501 status code when indicating that App Passwords is not available.

Props SergeyBiryukov, ocean90, TimothyBlynJacobs.
Fixes #51513.


git-svn-id: https://develop.svn.wordpress.org/trunk@49617 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:40:11 +00:00
Helen Hou-Sandi 56ffe940b0 Multisite: More consistency for clean_dirsize_cache().
Props SergeyBiryukov.
Fixes #19879.


git-svn-id: https://develop.svn.wordpress.org/trunk@49616 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 22:29:42 +00:00
Sergey Biryukov 740d99daf4 Script Loader: Correct version for jQuery Migrate.
Follow-up to [49338].

See #51621, #50564.

git-svn-id: https://develop.svn.wordpress.org/trunk@49615 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 21:34:56 +00:00
Helen Hou-Sandi 271702cd27 Media: Avoid fatal error in `wp_prepare_attachment_for_js().
In certain contexts, in particular on the front-end, `get_media_states()` is not availble.

Props rebasaurus.
Fixes #51791.


git-svn-id: https://develop.svn.wordpress.org/trunk@49613 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 19:18:51 +00:00
Sergey Biryukov 2c7b5c37db Docs: Fix typo in wp_get_object_terms filter DocBlock.
Follow-up to [49597].

See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49612 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 17:26:42 +00:00
Sergey Biryukov 10208c1e35 Docs: Add missing full stop for a comment in create_initial_rest_routes().
Follow-up to [49154].

Props david.binda.
Fixes #51788.

git-svn-id: https://develop.svn.wordpress.org/trunk@49611 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 16:46:27 +00:00
John Blackbourn 10deb31dd6 Docs: Corrections and improvements to inline docs relating to the REST API.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49610 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 11:02:32 +00:00
Sergey Biryukov 568e208e67 Docs: Drop src/ from pre_render_block duplicate hook reference.
Follow-up to [49608].

See #51612.

git-svn-id: https://develop.svn.wordpress.org/trunk@49609 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 10:51:19 +00:00
Robert Anderson 7a42314c8b Editor: Move pre_render_block, render_block_data, render_block_context
Move the pre_render_block, render_block_data, and render_block_context
filters from render_block() to WP_Block. This ensures that they are
called for all blocks, including nested blocks, not just top-level
blocks.

Fixes #51612.
Props gaambo, gziolo, TimothyBlynJacobs.


git-svn-id: https://develop.svn.wordpress.org/trunk@49608 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-16 00:45:55 +00:00
John Blackbourn 356f5664a7 Docs: For clarity, add some information about the return types of get_option().
Props ReneHermi, johannadevos

See #51278


git-svn-id: https://develop.svn.wordpress.org/trunk@49600 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 17:00:31 +00:00
John Blackbourn c19f56747f Docs: Various docblock corrections and improvements.
See #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49597 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 16:33:52 +00:00
Sergey Biryukov 637a3e8b5d Docs: Clarify that get_pages() returns an array of pages, not an HTML list.
Props ben.meredith@gmail.com, ovenall, johannadevos.
Fixes #39049. See #51768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49595 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-14 15:00:00 +00:00
Helen Hou-Sandi 3b1a27cfd1 Post-WordPress 5.6 Beta 4 bump.
git-svn-id: https://develop.svn.wordpress.org/trunk@49590 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:43:40 +00:00
Helen Hou-Sandi 7f4a7ef5f7 WordPress 5.6 Beta 4, for real.
git-svn-id: https://develop.svn.wordpress.org/trunk@49589 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:06:31 +00:00
Helen Hou-Sandi 43a370a723 WordPress 5.6 Beta 4.
git-svn-id: https://develop.svn.wordpress.org/trunk@49588 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 23:00:38 +00:00
John Blackbourn 0ad0c55a28 General: Convert wp_array_get() to a "private" function and add tests.
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720


git-svn-id: https://develop.svn.wordpress.org/trunk@49580 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:18:08 +00:00
Sergey Biryukov e0f55936d9 Editor: Update packages.
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.

git-svn-id: https://develop.svn.wordpress.org/trunk@49579 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:34:55 +00:00
Sergey Biryukov 5f5c04d46b Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8.
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.

git-svn-id: https://develop.svn.wordpress.org/trunk@49572 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:53:41 +00:00
Anthony Burchell d70214528e Media: Allow users to switch from media grid to list mode in media library.
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.


git-svn-id: https://develop.svn.wordpress.org/trunk@49568 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 15:44:58 +00:00
Dominik Schilling 4006c07417 I18N: Revert [49236] for now to investigate alternative implementations.
See #39210, #51678, #26511.

git-svn-id: https://develop.svn.wordpress.org/trunk@49566 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:41:19 +00:00
Sergey Biryukov e8e031d2dd Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later.
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.

git-svn-id: https://develop.svn.wordpress.org/trunk@49565 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:34:33 +00:00
Sergey Biryukov ea136a3af6 Coding Standards: Pass an empty string instead of null as the $replacement parameter to _deprecated_file().
Follow-up to [48327].

See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49564 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 11:15:49 +00:00
Peter Wilson 8b2aa594e3 Canonical: Prevent ID enumeration of private post slugs.
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.

Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49563 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 04:14:44 +00:00
Sergey Biryukov 98e774ee2e Docs: Clarify sprintf() usage for the before_widget argument of register_sidebar().
Follow-up to [49203], [49560].

See #19709.

git-svn-id: https://develop.svn.wordpress.org/trunk@49561 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-11 10:37:33 +00:00
Helen Hou-Sandi 9a14f55ace Widgets: Do not use wrapping container in the admin.
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.


git-svn-id: https://develop.svn.wordpress.org/trunk@49560 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:38:59 +00:00
Helen Hou-Sandi 2a7d1e2394 Editor: Display short description from block directory in results.
Props dd32, ryelle.
Fixes #51212.


git-svn-id: https://develop.svn.wordpress.org/trunk@49559 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:24:38 +00:00
Sergey Biryukov 4a5c2857da TinyMCE: Update to 4.9.11.
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt

A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11

See #51051.

git-svn-id: https://develop.svn.wordpress.org/trunk@49557 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 10:42:04 +00:00
Helen Hou-Sandi 6411c0953c Feeds: Don't treat media URLs with fragments as unique for enclosures.
Props archduck, dshanske.
Fixes #47421.


git-svn-id: https://develop.svn.wordpress.org/trunk@49552 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 20:26:18 +00:00
Timothy Jacobs d519284b5c App Passwords: Further accessibility improvements.
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.

Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes #51580.


git-svn-id: https://develop.svn.wordpress.org/trunk@49549 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 18:03:57 +00:00
Sergey Biryukov 2e01c76841 Coding Standards: Use consistent formatting for error messages in WP_Image_Editor_Imagick::write_image() and ::strip_meta().
See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49546 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:33:51 +00:00
John Blackbourn 8e25b92b63 Docs: Docblock corrections relating to WP_Post objects.
See #51373, #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49544 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:13:56 +00:00
John Blackbourn e4f47125ab Media: Restore the ability of WP_Image_Editor_Imagick->save() to create a missing directory when needed.
Props eemitch, mikeschroder, hellofromTonya, p00ya, johnbillion

Fixes #51665


git-svn-id: https://develop.svn.wordpress.org/trunk@49542 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 13:16:54 +00:00
Sergey Biryukov 6b76c5222d I18N: Merge duplicate "Column" strings, remove unnecessary context.
Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259.

git-svn-id: https://develop.svn.wordpress.org/trunk@49541 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 11:15:06 +00:00
Sergey Biryukov 52f6f7b64f Coding Standards: Adjust formatting in WP_Block::render() for better readability.
Follow-up to [49310], [49539].

See #51606.

git-svn-id: https://develop.svn.wordpress.org/trunk@49540 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 10:59:06 +00:00
Sergey Biryukov aac637dcdc Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.
Standardize on "Go to..." as a more appropriate option for most cases.

Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235.

git-svn-id: https://develop.svn.wordpress.org/trunk@49539 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 10:51:52 +00:00
Sergey Biryukov 31831c74d9 Networks and Sites: Assign the array of site or network data returned from filters to the respective class property:
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.

This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.

This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.

Follow-up to [46086], [48990].

Props yakimun, spacedmonkey.
Fixes #51333.

git-svn-id: https://develop.svn.wordpress.org/trunk@49538 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-08 11:45:36 +00:00