Commit Graph
754 Commits
Author SHA1 Message Date
Scott Taylor f95a4c70be In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed.
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28271 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:44:56 +00:00
Scott Taylor e42ec45553 Dead code in wp-admin/includes/file.php:
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28268 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:21:35 +00:00
Scott Taylor f97deae591 Remove unused variable setting for $revisions in wp_prepare_revisions_for_js().
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28264 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:44:30 +00:00
Scott Taylor 4c6f405ee7 Remove a dead variable, $start, from wp_dashboard_recent_comments().
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28263 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:34:22 +00:00
Andrew Nacin 4b6d5b10d4 Move 'home' option to the top of populate_options().
fixes #28141.


git-svn-id: https://develop.svn.wordpress.org/trunk@28260 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 21:56:11 +00:00
Sergey Biryukov 819ad5babc Deprecate unused argument of delete_plugins(). Clarify @return value.
props jdgrimes for initial patch.
fixes #28111.

git-svn-id: https://develop.svn.wordpress.org/trunk@28256 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 10:23:16 +00:00
Sergey Biryukov 3e482eb905 Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
props GaVrA.
fixes #28124.

git-svn-id: https://develop.svn.wordpress.org/trunk@28253 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 08:25:46 +00:00
Drew Jaynes (DrewAPicture) 609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter.
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture) 379f725bde Ensure the wp_edit_nav_menu_walker filter is only documented once.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28213 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:49:48 +00:00
Drew Jaynes (DrewAPicture) 7a0eb63a19 Ensure the nav_menu_meta_box_object filter hook is only documented once.
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28207 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:13:15 +00:00
Andrew Nacin 77c11f6cc9 Theme Installer: Proper redirection and action links post-install in multisite.
fixes #27869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28163 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:17:12 +00:00
Andrew Nacin aeef0e992a Translate a string added in 3.7.1 but never translated previously.
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:37:59 +00:00
Dion Hulse 60f6968d80 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815
git-svn-id: https://develop.svn.wordpress.org/trunk@28137 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 10:56:56 +00:00
Andrew Nacin 0437f710a5 Allow the API to add text to auto update emails.
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 08:51:23 +00:00
Andrew Nacin 7ed14feff1 Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.


git-svn-id: https://develop.svn.wordpress.org/trunk@28126 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 01:15:43 +00:00
Andrew Nacin 32721b8347 Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.


git-svn-id: https://develop.svn.wordpress.org/trunk@28113 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 07:47:10 +00:00
Andrew Ozz bff230b422 Plupload: restore the settings in media_upload_form(), see #27763
git-svn-id: https://develop.svn.wordpress.org/trunk@28110 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 00:40:45 +00:00
Andrew Nacin c43b8b063d Fix feature pointer RTL placement.
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 23:59:01 +00:00
Andrew Nacin 7a25da5240 The widgets pointer requires the edit_theme_options capability.
(It's hypothetically possible to have only switch_themes.)

see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28093 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 20:52:35 +00:00
Andrew Nacin 863116a5d2 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4.
see #27777.


git-svn-id: https://develop.svn.wordpress.org/trunk@28090 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 20:47:12 +00:00
Andrew Nacin 6c0420348e Update $_old_files for 3.9. see #27775.
git-svn-id: https://develop.svn.wordpress.org/trunk@28085 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 18:26:25 +00:00
Drew Jaynes (DrewAPicture) b5612f8b80 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:00:32 +00:00
Andrew Nacin 2d9949bf91 Account for new cropping settings in the image editor.
props Otto42, SergeyBiryukov.
fixes #19393.


git-svn-id: https://develop.svn.wordpress.org/trunk@28072 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-11 03:09:35 +00:00
Drew Jaynes (DrewAPicture) 93b19f682e Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php.
Fixes #27711.


git-svn-id: https://develop.svn.wordpress.org/trunk@28040 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 06:25:56 +00:00
Andrew Nacin d5c3a966be Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns.
see #27055.


git-svn-id: https://develop.svn.wordpress.org/trunk@28037 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 04:30:01 +00:00
Drew Jaynes (DrewAPicture) 4d4921a9ac Use the correct parameter variables in the hook docs for wp_upgrade.
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27998 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:13:00 +00:00
Drew Jaynes (DrewAPicture) 3b7d881f3c Align parameters in the hook docs for the attachment_thumbnail_args filter.
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27997 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:10:01 +00:00
Drew Jaynes (DrewAPicture) 95294a170e Add missing parameter descriptions to the PHPDocs for WP_Upgrader_Skin::decrement_update_count() and Bulk_Upgrader_Skin::decrement_update_count().
See #27700.


git-svn-id: https://develop.svn.wordpress.org/trunk@27996 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:01:35 +00:00
Andrew Nacin 06152cbe6f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
props kovshenin.
see [27964], see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27990 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 17:58:37 +00:00
Andrew Nacin 3fbe1ba7b7 Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27975 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 22:07:02 +00:00
Drew Jaynes (DrewAPicture) 789305948e Inline documentation for remaining hooks in wp-admin/includes/upgrade.php.
Props jackreichert, vancoder.
Fixes #27646.


git-svn-id: https://develop.svn.wordpress.org/trunk@27965 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 22:29:41 +00:00
Andrew Nacin 14d96748c7 Better checks for contributors when saving posts.
props dd32, kovshenin, plocha.
see #27452.


git-svn-id: https://develop.svn.wordpress.org/trunk@27964 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 21:18:44 +00:00
Sergey Biryukov 96563b4143 Clarify tooltips on Edit Image screen.
props siobhan.
fixes #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27939 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:22 +00:00
Sergey Biryukov a97e9018c4 Fix typo in verify_file_md5() description. see [25541].
props siobhan.
see #27651.

git-svn-id: https://develop.svn.wordpress.org/trunk@27938 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 00:02:12 +00:00
Sergey Biryukov ed139644be Use multiplication sign instead of a colon for selection size when editing an image.
props siobhan.
fixes #27652.

git-svn-id: https://develop.svn.wordpress.org/trunk@27931 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 09:45:44 +00:00
Andrew Nacin 66f20812b9 Remove old links_recently_updated_* DB options that never had a UI.
fixes #27649.


git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:09:59 +00:00
Dion Hulse 48025fabd5 Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633
git-svn-id: https://develop.svn.wordpress.org/trunk@27905 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 13:04:30 +00:00
Drew Jaynes (DrewAPicture) 33acf29a46 Clarify PHPDoc return description for media_handle_upload().
Props jdgrimes.
Fixes #27519.


git-svn-id: https://develop.svn.wordpress.org/trunk@27880 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 22:32:47 +00:00
Scott Taylor d8d26a4f79 Cleanup up the display, escaping, and handling of ID3 data for media. Rename wp_get_relevant_id3_keys() to wp_get_attachment_id3_keys().
Props nacin.
See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27869 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-31 05:15:39 +00:00
Andrew Nacin 70beef6c31 Use correct formatting function. see [27864], see #27574.
git-svn-id: https://develop.svn.wordpress.org/trunk@27866 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 22:11:58 +00:00
Andrew Nacin 877ffc087f Cleanups for audio/video metadata, see [27862].
see #27574.


git-svn-id: https://develop.svn.wordpress.org/trunk@27864 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 21:07:04 +00:00
Scott Taylor 2846655164 In wp_generate_attachment_metadata(), when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a _cover_hash value in post meta that matches the md5 representation of the bits.
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 


git-svn-id: https://develop.svn.wordpress.org/trunk@27863 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 20:53:21 +00:00
Scott Taylor 149f36ed35 Metadata for audio and video files:
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.



git-svn-id: https://develop.svn.wordpress.org/trunk@27862 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-30 19:27:31 +00:00
Andrew Nacin 1c3f9e542b Restyle the image editor so it looks way less hideous.
props avryl.
see #27544.


git-svn-id: https://develop.svn.wordpress.org/trunk@27842 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-29 08:50:57 +00:00
Drew Jaynes (DrewAPicture) a2d810d024 The sidebar_admin_setup hook should only be documented once in wp-admin/widgets.php. All others are duplicates.
See #25374, #25501, #27531.


git-svn-id: https://develop.svn.wordpress.org/trunk@27823 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 19:46:26 +00:00
Dominik Schilling (ocean90) 2d4b606e14 Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets.
see #27504.
props westonruter.


git-svn-id: https://develop.svn.wordpress.org/trunk@27816 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 14:06:10 +00:00
Andrew Nacin 98ac075d8b Always decode special characters for email subjects.
props tlovett1, jeremyfelt.
fixes #25346.


git-svn-id: https://develop.svn.wordpress.org/trunk@27801 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-28 02:43:04 +00:00
Andrew Nacin ab787f2f57 Proper IDs for the custom fields box.
props SergeyBiryukov.
fixes #14376.


git-svn-id: https://develop.svn.wordpress.org/trunk@27776 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 06:55:51 +00:00
Andrew Nacin 50d900aa5f Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189, #27188.
git-svn-id: https://develop.svn.wordpress.org/trunk@27769 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 02:01:29 +00:00
Scott Taylor 3acb8fcdf6 The bulk editor and post format meta box should use the same checks for available post formats.
Props eightface.
Fixes #27187.



git-svn-id: https://develop.svn.wordpress.org/trunk@27762 602fd350-edb4-49c9-b593-d223f7449a82
2014-03-27 00:05:14 +00:00