Scott Taylor
27ff2a1cd0
Eliminate use of extract() in get_media_item().
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:45:01 +00:00
Scott Taylor
da440f54fd
Eliminate use of extract() in wp_list_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0
Eliminate use of extract() in _walk_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff
Eliminate use of extract() in get_bookmarks().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275
Eliminate use of extract() in Walker_Page::start_el().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9
Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:21:20 +00:00
Scott Taylor
e4a800238f
Eliminate use of extract() in wp_dropdown_pages().
...
Adds unit tests to: `tests/post/template.php`.
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c
Eliminate use of extract() in wp_link_pages().
...
Adds unit tests to a new file: `tests/post/template.php`.
There were previously no unit tests for `wp_link_pages()`.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e
Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-14 22:28:08 +00:00
Scott Taylor
540826e4e3
Eliminate use of extract() in wp_list_authors().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 06:01:33 +00:00
Scott Taylor
ba8e36f94c
Eliminate use of extract() in the_title_attribute().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28383 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:47:11 +00:00
Scott Taylor
42d6b5dd1e
Eliminate use of extract() in trackback_url_list().
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:43:22 +00:00
Scott Taylor
671b47ef73
Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php.
...
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28381 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:39:17 +00:00
Scott Taylor
77731c03fc
Eliminate use of extract() in wp_get_archives().
...
Adds unit tests: `tests/functions/getArchives.php`.
All other unit tests pass.
Props MikeHansenMe, wonderboymusic.
See #22400 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:56 +00:00
Drew Jaynes (DrewAPicture)
3c80d5f86a
Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28378 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:28:30 +00:00
Drew Jaynes (DrewAPicture)
e2219e3d48
Add a complete short description to the get_attached_media filter documentation.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28377 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-13 04:20:12 +00:00
Scott Taylor
961f52d367
Add xps and oxps extensions to list of supported document types.
...
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification
Fixes #15697 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:18:06 +00:00
Scott Taylor
8dc4b88fcf
In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true.
...
Props adamsilverstein.
Fixes #23954 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 07:02:05 +00:00
Scott Taylor
e8b8e881b2
Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath.
...
Props Otto42 for the initial patch.
Fixes #25243 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28370 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:24:58 +00:00
Scott Taylor
e1b341cc59
In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border.
...
Props avryl.
Fixes #27949 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 06:18:02 +00:00
Scott Taylor
4826c12c47
Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors.
...
Props celloexpressions.
Fixes #27516 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28365 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:22:42 +00:00
Scott Taylor
9705736cdf
When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.
...
Fixes #27971 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28364 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 02:06:36 +00:00
Scott Taylor
487da46928
Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge.
...
Fixes #27368 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28363 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 01:27:29 +00:00
Scott Taylor
b70967302b
In get_the_author_posts(), if there is no current $post, return 0 and bail.
...
Props krogsgard, aaroncampbell.
Fixes #27998 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28362 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:25:29 +00:00
Scott Taylor
8998c015b3
MediaElement players need clear: both to play nice with adjacent floated elements.
...
Fixes #27385 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28361 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-11 00:13:49 +00:00
Scott Taylor
2808673b0c
Remove the title attribute from markup generated in wp-includes/category-template.php:
...
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`
Props joedolson.
Fixes #26557 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28359 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:56:12 +00:00
Scott Taylor
a398f38024
First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
cb5852a813
Add inline documentation of the default arguments for wp_list_pages().
...
Props garza for the initial patches.
Fixes #11338 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28357 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-10 08:01:13 +00:00
Scott Taylor
7531fd0070
Leverage size_format() when displaying max_upload_size:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 18:24:47 +00:00
Scott Taylor
bfe7d38650
audio, video, and playlist shortcodes:
...
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur
See #22400 , #27881 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28342 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 17:35:09 +00:00
Scott Taylor
4bddd84276
In wpdb, remove dead code:
...
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28339 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:55:32 +00:00
Scott Taylor
e47eb14575
In WP_Widget::update_callback(), $sidebars_widgets is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28338 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:51:31 +00:00
Scott Taylor
f945487f45
In wp-includes/theme.php, break is unreachable after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28337 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:49:19 +00:00
Scott Taylor
b99dead052
In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28336 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:46:11 +00:00
Scott Taylor
b62ca9c298
In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28335 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:44:06 +00:00
Scott Taylor
f63b6cde3a
In wp-includes/revision.php - remove dead code:
...
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28334 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-07 03:37:45 +00:00
Scott Taylor
098a5145c5
In WP_Query, remove duplicate variable setting:
...
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28333 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:42:28 +00:00
Scott Taylor
16a58e34a2
In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
...
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:38:23 +00:00
Scott Taylor
11e65eb200
In wp_get_attachment_link(), $post_title is set and then not used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28331 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:34:10 +00:00
Scott Taylor
b626b11590
In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28330 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:32:25 +00:00
Scott Taylor
3f2a078f5e
In get_network_by_path(), $exact_domains is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28329 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:31:14 +00:00
Scott Taylor
24b03d819b
In update_metadata_by_mid(), $original_value is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28328 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:28:02 +00:00
Scott Taylor
e95edb29aa
In edit_post_link(), $post_type_obj is unused.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28327 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:26:20 +00:00
Scott Taylor
5cf2a50dba
In paginate_links(), break is unreachable after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:24:22 +00:00
Scott Taylor
ef5998eabb
In wp-includes/functions.php, remove dead code:
...
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:22:22 +00:00
Scott Taylor
5e90fb1b3e
In wp_set_comment_status(), the default case returns, so no default value for $status is needed.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28324 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:16:42 +00:00
Scott Taylor
5530fe4c11
In wp-includes/comment-template.php, remove dead code:
...
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28323 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:14:35 +00:00
wonderboymusic
2b1c764ec7
In Walker::walk() and Walker::paged_walk(), $id_field is set and never used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28322 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 21:08:02 +00:00
Sergey Biryukov
18916debfd
Update deleted site message in ms_site_check().
...
props boonebgorges.
fixes #28150 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28321 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:45:54 +00:00
Scott Taylor
0f4f941900
In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28320 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:36:34 +00:00
Scott Taylor
9ad07c8c28
In wp-includes/class-wp-customize-setting.php, break is unreachable after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28319 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:33:03 +00:00
Scott Taylor
376125e0b7
In wp-includes/class-wp-admin-bar.php, break is unreachabled after return.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:28:46 +00:00
Scott Taylor
c5463c5cb2
In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well.
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28317 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:26:00 +00:00
Scott Taylor
5df63351b2
In wp-includes/bookmark.php, remove dead code:
...
* In `get_bookmarks()`, `$cache` is set twice before it is used.
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 18:21:50 +00:00
Sergey Biryukov
d7a159bf81
Add a filter for wp_list_comments() arguments.
...
props greenshady, hlashbrooke.
fixes #19581 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 11:57:36 +00:00
Drew Jaynes (DrewAPicture)
8764f791f1
Where a filter no longer exists, it need not be notated.
...
Fixes #24444 . See r28258.
git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:37:17 +00:00
Andrew Nacin
cb022f4957
Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression.
...
props jeremyfelt.
fixes #27927 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28280 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:31:12 +00:00
Andrew Nacin
7839dd671c
Multisite: Fix case sensitivity regressions in 3.9.
...
props jeremyfelt.
fixes #27866 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28276 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 05:23:56 +00:00
Scott Taylor
a1c6a10489
In general-template.php - remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:57:22 +00:00
Andrew Nacin
7ada7af9d0
Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers.
...
props rzen, ehg.
fixes #27848 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28266 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 04:13:52 +00:00
Scott Taylor
eda51bf856
Remove duplicate variable setting for $link in wp_list_authors().
...
See #27882 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28265 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-06 03:51:42 +00:00
Scott Taylor
2b1619329e
Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement.
...
Props joedolson.
Fixes #27643 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 20:07:53 +00:00
Scott Taylor
5c306af76d
When $type is atom in get_the_category_rss(), use get_bloginfo_rss( 'url' ) when setting the scheme attribute for the <category> node.
...
Props ejdanderson.
Fixes #24444 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28258 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 19:04:39 +00:00
Scott Taylor
fc4dfba1b8
Remove by-reference modifiers from arguments in wp_remote_retrieve_* functions.
...
Props jesin.
Fixes #27687 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28257 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-05 18:45:14 +00:00
Scott Taylor
89ecbcc7cb
In WP_Date_Query::get_sql_for_subquery(), don't parse duplicate parameters - only parse one of w and week or month and monthnum.
...
Adds unit tests.
Props oso96_2000, ChriCo.
Fixes #25835 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28252 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 23:06:07 +00:00
Scott Taylor
61765b8efd
Set the proper value for wp_title() when is_author() and is_post_type_archive() are both true. post_type should always win due to the precedence indicated in get_queried_object().
...
Props mordauk.
Fixes #25398 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28251 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 22:20:47 +00:00
Sergey Biryukov
ece95a0257
Prevent 'paged-*' from being added to body classes on 404 error pages.
...
props psoluch.
see #16468 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28249 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-04 13:16:13 +00:00
Drew Jaynes (DrewAPicture)
5ad1751132
Improve inline documentation for the wpdb::$show_errors property.
...
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.
Props ericlewis.
Fixes #16615 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28243 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 12:18:07 +00:00
Sergey Biryukov
da6a3d1745
Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu().
...
props Tmeister.
fixes #27745 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28242 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:58:51 +00:00
Sergey Biryukov
6c401709f6
Correct 'show_in_menu' parameter description in register_taxonomy().
...
fixes #27943 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28241 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:28:05 +00:00
Sergey Biryukov
b9834e8275
Correct @return value for current_time().
...
props arnee.
fixes #27940 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28240 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 11:24:23 +00:00
Dominik Schilling (ocean90)
cb9480b4eb
Update jQuery to 1.11.1.
...
fixes #28103 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28238 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-02 09:28:55 +00:00
Sergey Biryukov
2558cf0139
Fix arrow positioning in "Insert/edit link" modal.
...
props avryl, sergej.mueller.
fixes #28096 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28236 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 21:20:16 +00:00
Andrew Nacin
790cb99b27
Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets.
...
props gcorne.
props Clorith, jorbin for tests.
see #27907 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28223 602fd350-edb4-49c9-b593-d223f7449a82
2014-05-01 03:36:27 +00:00
Andrew Nacin
e18e93bb80
Improve TinyMCE string for paste command browser support.
...
props ebinnion.
fixes #27988 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28220 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 21:19:35 +00:00
Dominik Schilling (ocean90)
a13b695fbd
Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width.
...
Add tests.
see #27936 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28219 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 20:24:28 +00:00
Dominik Schilling (ocean90)
fd26def119
Revert [28217].
...
Misfired commit for #27936 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28218 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 20:17:59 +00:00
Dominik Schilling (ocean90)
5d8f69e0c5
Recent Posts Widget: Use ob_end_flush() instead of ob_flush().
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28217 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 14:20:05 +00:00
Drew Jaynes (DrewAPicture)
609cf29058
Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter.
...
Also adds braces missed in [25535].
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
9c66e66ac5
Ensure the wp_set_comment_status action hook is only documented once.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28214 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:54:33 +00:00
Drew Jaynes (DrewAPicture)
bf8c70a4ee
Ensure the style_loader_tag filter hook is only documented once.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28209 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:28:19 +00:00
Drew Jaynes (DrewAPicture)
9da8915408
Ensure the register filter hook is only documented once.
...
See #26869 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28208 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 06:23:31 +00:00
Mark Jaquith
c4dd499979
Use '— Select —' instead of '-- Select --' for nav menus. Looks nicer.
...
see #27878
git-svn-id: https://develop.svn.wordpress.org/trunk@28205 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-25 00:34:20 +00:00
Mark Jaquith
65b0b658d7
Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX
...
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.
fixes #27878 for trunk. props westonruter
git-svn-id: https://develop.svn.wordpress.org/trunk@28197 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 20:44:32 +00:00
Dominik Schilling (ocean90)
0202625937
Recent Posts Widget: Use ob_end_flush() instead of ob_flush().
...
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.
props m_i_n.
see #28009 for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28195 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 19:47:09 +00:00
John Blackbourn
2d3568380b
Remove some unnecessary abstraction introduced in [28191]. See #27985 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28194 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 11:54:31 +00:00
Andrew Ozz
fff29139b5
TinyMCE: update the 'paste' plugin to the latest dev. version. Included changes: 1b7c41cd7b and 7998b8025d. See #27909 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28192 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-24 00:58:13 +00:00
johnbillion
34b0686be1
Avoid an expensive attachment counting query on the post editing screen. See #27985 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28191 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 22:04:03 +00:00
Andrew Ozz
a6de675d14
TinyMCE: when adding a caption to an image that is in a paragraph with other text, move the caption node above the paragraph instead of below. See #27922 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28190 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 20:41:59 +00:00
Andrew Ozz
c602aac562
Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28189 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-23 20:34:43 +00:00
Andrew Ozz
a528be21ad
Run WP_Editors::enqueue_scripts() on admin_print_footer_scripts priority 1 (later), instead of admin_footer. Fixes incompatibility with the customizer. Props feedmeastraycat, see #27853 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28187 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 22:40:33 +00:00
Andrew Ozz
db22ae4e32
TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847 , for trunk.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28185 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 21:10:14 +00:00
Scott Taylor
77c156631a
Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe.
...
See #27893 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28184 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 20:28:35 +00:00
Scott Taylor
4507f1e04f
Persisting <track> elements as the body of a [video] shortcode in MCE Views:
...
* When generating the view's HTML, ensure that the shortcode's `content` is added to the model
* Add a `PostProcess` event in the `wpview` plugin to properly return the shortcode when the editor mode is toggled, ensuring that elements in the body are not dropped.
Props azaozz, wonderboymusic.
See #27915 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28183 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 18:20:54 +00:00
Scott Taylor
97c497abc2
Refinements for asynchronous rendering in wp.mce.media.PlaylistView:
...
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.
Props gcorne, wonderboymusic.
See #27899 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28182 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 17:52:06 +00:00
Andrew Nacin
620fc6660c
TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink.
...
props azaozz.
see #27963 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28181 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 13:49:28 +00:00
Andrew Nacin
adf4aa7393
Editor: Shrink the font size for the chosen format so it fits in more locales.
...
props SergeyBiryukov.
see #27903 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28180 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-22 13:23:29 +00:00
Scott Taylor
8c6b77a4da
Use the proper translated string for Video Playlist "drag info" - the text displayed above the playlist's sortable attachments.
...
See #27937 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28178 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-21 19:36:21 +00:00
Andrew Nacin
5295d232af
Remove version string from Thickbox so it assumes the WP core version. Bust some caches.
...
props celloexpressions.
see #27861 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28176 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-21 05:06:54 +00:00
Scott Taylor
99ca08fb55
Add calc() rules for max-width of playlist caption.
...
Props celloexpressions.
See #27923 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28174 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-20 05:09:47 +00:00
Scott Taylor
a39eb76bc5
Support RTL properly when displaying playlists.
...
Props SergeyBiryukov.
See #27924 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28173 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-20 04:26:59 +00:00
Scott Taylor
22c3cc1fec
Properly account for text overflow in .wp-playlist-caption by adding display: block.
...
Props celloexpressions.
See #27923 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28172 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-20 04:24:53 +00:00
Scott Taylor
47d8ce50b0
Add a compatibility layer in wp-playlist.js to avoid VM errors from MediaElement's plugin bridge in the TinyMCE views for playlists by suppressing playback for files whose mime-type is not supported in the user's browser natively.
...
This is similar to how audio and video shortcodes are handled: file types are whitelisted for native playback.
See #27892 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28171 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-20 03:52:57 +00:00
Andrew Nacin
55a3551646
Customizer: Correct reference to the 'Add new image' button.
...
props jjeaton.
see #27890 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28170 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 19:44:43 +00:00
Scott Taylor
29a1d6fe13
Don't show textareas that have "hidden" as a class in the media modal.
...
See #27915 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28169 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:33:42 +00:00
Andrew Nacin
9ed158cc8c
Properly translate 'Select Poster Image'.
...
props dimadin.
see #27845 , for trunk.
git-svn-id: https://develop.svn.wordpress.org/trunk@28168 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:27:51 +00:00
Andrew Nacin
9223056bb3
Fix logic inversion in [28124] to ensure widgets stay with themes during a theme switch.
...
fixes #27897 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28161 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-19 18:11:24 +00:00
Scott Taylor
6ccd360ff4
Don't set the poster image for videos in a playlist if the image is the video mime-type icon blown up.
...
See #27892 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28158 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-18 17:38:53 +00:00
Andrew Nacin
18f073cde0
Trunk is now 4.0-alpha.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28157 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 19:36:35 +00:00
Andrew Nacin
91f1a42b6a
WordPress 3.9.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28153 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 18:00:26 +00:00
Mark Jaquith
3127edf4c8
Prevent customizer header image list from listing user images twice when no theme-specified images exist
...
fixes #27839 . props mcsf
git-svn-id: https://develop.svn.wordpress.org/trunk@28152 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 18:00:10 +00:00
Andrew Nacin
bd9e4f4f30
Final about page.
...
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713 , #27837 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28150 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 17:39:18 +00:00
Mark Jaquith
e05574bcf9
Ensure that wp.media.view.settings.post is set before accessing the post's id
...
Avoids JS error in cases where media-editor is loaded individually
instead of with the whole `wp_enqueue_media()` process.
fixes #27836 . props nacin
git-svn-id: https://develop.svn.wordpress.org/trunk@28149 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 15:25:35 +00:00
Andrew Nacin
aeef0e992a
Translate a string added in 3.7.1 but never translated previously.
...
props SergeyBiryukov.
fixes #27819 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:37:59 +00:00
Andrew Nacin
51882f8707
Graceful failures for TinyMCE views of video/audio playlists.
...
props gcorne.
fixes #27821 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28144 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:22:28 +00:00
Andrew Nacin
6ac55e5a83
Widgets: Remove create_function() from the customizer class.
...
props westonruter.
fixes #27805 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28143 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:10:09 +00:00
Andrew Nacin
6196b0811e
Add missing string translation in widgets.
...
see #27453 , #27112 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28140 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-16 00:00:33 +00:00
Andrew Nacin
85925b39ad
Cast wp_count_attachments() before iterating it to avoid a notice when items exist without a mime type.
...
props bobbingwide.
fixes #27802 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28139 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 23:59:48 +00:00
Andrew Nacin
31a847bb9c
3.9-RC2
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28135 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 08:58:01 +00:00
Andrew Nacin
0437f710a5
Allow the API to add text to auto update emails.
...
fixes #27812 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 08:51:23 +00:00
Drew Jaynes (DrewAPicture)
ecbe6226fa
Inline documentation for three remaining hooks in wp-includes/general-template.php.
...
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.
That's 184/184 hook docs files complete. Boom!
Props kpdesign, DrewAPicture.
Fixes #27719 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28131 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 04:41:37 +00:00
Drew Jaynes (DrewAPicture)
c91efaa74c
Inline documentation for hooks in wp-includes/general-template.php.
...
Props jesin, kpdesign.
See #27719 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28130 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 04:00:48 +00:00
Andrew Nacin
61cb5d3e49
Add a TTL to core update checks to allow us to narrow the 12-hour update window.
...
props dd32.
fixes #27772 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28129 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 02:22:07 +00:00
Drew Jaynes (DrewAPicture)
93443ecd13
Inline documentation for hooks in wp-includes/media.php.
...
Props scottlee for the initial patch. Props kpdesign, DrewAPicture.
Fixes #27718 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28128 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-15 01:35:49 +00:00
Andrew Nacin
16490ce89c
Image Details modal: Remember the last state of the advanced toggle.
...
props gcorne.
fixes #27366 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28125 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 23:55:04 +00:00
Andrew Nacin
a8efcb993f
Customizer: Properly handle widget settings when activating a previewed theme.
...
props westonruter, ocean90, gcorne.
fixes #27767 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28124 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 22:45:40 +00:00
Drew Jaynes (DrewAPicture)
6a8889ea8c
Inline documentation for hooks in wp-includes/class-wp-customize-widgets.php
...
Fixes #27531 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28117 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 18:40:29 +00:00
Andrew Ozz
cd356b6404
DFW:
...
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709
git-svn-id: https://develop.svn.wordpress.org/trunk@28116 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 08:14:01 +00:00
Andrew Nacin
e1c90794e5
TinyMCE: Always load translations, even in English, as we modify some strings.
...
Move a setting to after the translations filter, and remove unused strings.
see #24067 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28112 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 03:22:38 +00:00
Drew Jaynes (DrewAPicture)
7c57669ec2
Inline documentation for hooks in wp-includes/link-template.php.
...
Props johnbillion, DrewAPicture.
Fixes #27716 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28111 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 02:12:48 +00:00
Drew Jaynes (DrewAPicture)
11f2a0dc31
Inline documentation for hooks in wp-includes/functions.php.
...
Props jesin, GaryJ.
Fixes #27715 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28109 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 00:19:37 +00:00
Andrew Nacin
5b4cd4b027
Plupload: Restore 3.8 handles and filenames to avoid breaking plugins.
...
fixes #27763 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28108 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-14 00:06:03 +00:00
Andrew Nacin
c43b8b063d
Fix feature pointer RTL placement.
...
props SergeyBiryukov, ocean90.
fixes #27778 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 23:59:01 +00:00
Drew Jaynes (DrewAPicture)
d2e679179b
Part II of inline documentation for hooks in wp-includes/post.php.
...
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.
Props nacin for several hook descriptions.
Fixes #25376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28106 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 23:05:20 +00:00
Andrew Nacin
8e6a1f479b
Customizer: Fix header image cropping when working with huge images. Affected Firefox in particular.
...
props ehg.
fixes #27790 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28101 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 18:19:55 +00:00
Andrew Nacin
e164ec2461
Customizer: Account for a sidebar with no container to which classes can be added.
...
props ocean90.
fixes #27780 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28100 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 16:40:07 +00:00
Andrew Nacin
f7d4569c8d
Add context to string added in [28097].
...
props azaozz.
fixes #27785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28099 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 16:34:13 +00:00
Andrew Nacin
42f6f43c35
Add missing 'Address' string for TinyMCE.
...
props pavelevap, ocean90.
fixes #27785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28097 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 16:20:54 +00:00
Andrew Nacin
985727f256
RTL for login screen.
...
props yoavf.
fixes #27784 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28096 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 16:05:16 +00:00
Andrew Ozz
07885ba6c9
Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal.
...
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698
git-svn-id: https://develop.svn.wordpress.org/trunk@28095 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 04:01:53 +00:00
Andrew Ozz
3396375d47
RTL for TinyMCE:
...
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773
git-svn-id: https://develop.svn.wordpress.org/trunk@28094 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-13 00:22:56 +00:00
Andrew Nacin
36f7e292d2
Add an explanation for 'Paste from Word' in the 'Paste from Text' dialog.
...
fixes #27777 . see #27160 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28091 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 20:47:59 +00:00
Andrew Ozz
027f0872bd
Update the TinyMCE paste plugin to the latest development version. It includes a fix for pasting from Word: removes inline comments and change tracking.
...
Changeset: f8cffdf342
Fixes #27771
git-svn-id: https://develop.svn.wordpress.org/trunk@28089 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 20:00:52 +00:00
Andrew Nacin
aa08fb55ce
User Query: Don't blindly re-append new meta queries for capabilities.
...
fixes #21119 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28087 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 19:03:56 +00:00
Andrew Nacin
9defa138a4
Custom Headers: Allow for longer strings.
...
props ehg.
see #27755 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28086 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 18:39:46 +00:00
Andrew Ozz
17a90fff8b
TinyMCE wpViews:
...
- Prevent undo steps from being added when the body of a wpview changes.
- Add unbind() to handle cleanup on DOM rebuilding in TinyMCE.
- Ensure that MediaElement's cleanup routine is run on every player in all instances of the editor.
- Initialize the players after some delay to ensure CSS is loaded.
Props gcorne and wonderboymusic, fixes #27389
git-svn-id: https://develop.svn.wordpress.org/trunk@28084 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:45:48 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80
Priority fixes for various existing hook documentation.
...
Props kpdesign.
See #26869
git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-12 00:00:32 +00:00
Andrew Nacin
8f0329b452
Translate custom header customize control strings. Remove final added before beta to see what breakage we might cause by refactoring this class.
...
see #21785 . fixes #27738 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28082 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-11 23:24:32 +00:00
Andrew Ozz
8aacd10a8c
Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28081 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-11 22:16:01 +00:00
Andrew Nacin
5dd9108e48
Editor: Ensure the link dialog does not display when styles are missing.
...
props mattheu.
fixes #27605 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28071 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-11 03:08:23 +00:00
Scott Taylor
824830ca01
Bump MediaElement.js to 2.14.2. Release Notes: 743f446523.
...
Fixes #27582 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28068 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-10 21:31:24 +00:00
Andrew Ozz
2883034c6a
Update TinyMCE to the current development version, 4.0.21.1. Fixes #27744
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28066 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-10 21:08:41 +00:00
Andrew Nacin
3e6d8864a9
XML-RPC: Fix bracing of conditionals around doc blocks.
...
props redsweater, DrewAPicture.
fixes #27506 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28065 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-10 21:03:29 +00:00
Andrew Ozz
c90a2a5d3b
TinyMCE Views in IE8 and 7: change deselect event only for old IE, props gcorne, fixes #27546
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28063 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-09 15:28:17 +00:00
Andrew Ozz
b253355d2c
Fix TinyMCE Views in IE8 and 7:
...
- Add fallback background images for dashicons.
- Fix hiding the clipboard while still allowing the contents to be selected.
- Work around lack of border-box in gallery styles.
(Includes precommit cleanup for theme.js)
Props gcorne, fixes 27546
git-svn-id: https://develop.svn.wordpress.org/trunk@28062 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-09 00:57:46 +00:00
Andrew Ozz
0d6b3f3e3f
TinyMCE: make sure vertical resizing and menubar show/hide are set to default for each instance, fixes #27724
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28059 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 18:57:18 +00:00
Andrew Nacin
244eca7982
3.9-RC1
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28058 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 18:18:03 +00:00
Andrew Nacin
3234ade164
Harden HMAC verification. props duck_.
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28053 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 18:05:42 +00:00
Andrew Nacin
402bb6208b
Don't show featured images for image attachments. Remove abstractions for now.
...
fixes #27673 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28051 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 17:39:58 +00:00
Andrew Nacin
248151298c
Escape playlist data in templates.
...
props wonderboymusic.
fixes #27710 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28050 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 17:39:06 +00:00
Scott Taylor
468c9d2ac7
Restore GalleryAdd() and GalleryEdit() in media-views.js to ensure back-compat.
...
See [27362].
git-svn-id: https://develop.svn.wordpress.org/trunk@28048 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 15:53:42 +00:00
Dominik Schilling (ocean90)
82ac1009c4
Move toolbar declaration after the :visible check, like it was before [28019].
...
props kovshenin.
fixes #24859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28046 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 11:20:34 +00:00
Andrew Ozz
0e44baa89e
Precommit cleanup for theme.js, editor.css amd wpdialogs/plugin.js, See #27055 , #26907 , #16284
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28045 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 08:28:57 +00:00
Dominik Schilling (ocean90)
ff78684898
Widget Customizer: Fix widget filtering.
...
props westonruter.
fixes #27451 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28044 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 08:11:33 +00:00
Andrew Ozz
61d17c2163
DFW:
...
- Move the word count and "Just Write" to a fixed bar at the bottom.
- Fix responsive mode to 480px. Narrower screens will have a scroll bar.
- Hide the Help button on screens < 480px, move the Save button to the right, make it bigger to match the others, and other responsive mode fixes.
Fixes #26907 , see #27709
git-svn-id: https://develop.svn.wordpress.org/trunk@28043 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 07:48:55 +00:00
Drew Jaynes (DrewAPicture)
54e59a0290
Clarify documentation for hooks in sanitize_post_field().
...
* `edit_post_{$field}` pairs with `edit_{$field}`
* `pre_post_{$field}` pairs with `pre_{$field}`
* `post_{$field}` pairs with `{$field}`
As the above pairs' docs are unnecessarily duplicative, the second sets of docs have been removed. Also, the "duplicates" are purposely not marked as such in this case as the hook names differ. Also remove `@deprecated` tags mistakenly left in in [28041].
See #25376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28042 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 07:40:30 +00:00
Drew Jaynes (DrewAPicture)
a3d04ec9ed
Part I of inline documenation for hooks in wp-includes/post.php.
...
Adds docs for the following hooks:
* `get_attached_file`
* `update_attached_file`
* `_wp_relative_upload_path`
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `edit_post_{$field}`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `pre_post_{$field}`
* `{$field}_pre`
* `$field`
* `post_{$field}`
* `wp_count_posts`
* `wp_count_attachments`
* `post_mime_types`
* `wp_insert_post_empty_content`
See #25376 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28041 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 06:48:32 +00:00
Andrew Nacin
92381845b8
Media Templates: More escaping rather than interpolation. see #21785 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28039 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 05:27:44 +00:00
Andrew Nacin
288b1fd4f3
Nuke the TinyMCE help dialog as it is duplicated by help tabs. This leaves just Keyboard Shortcuts.
...
fixes #27100 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28032 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 02:31:02 +00:00
Andrew Nacin
9875f51f1f
Header Images: Add suggested dimensions to the media workflow.
...
This updates [28030] to the latest patch.
props gcorne.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28031 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:56:42 +00:00
Andrew Nacin
d29a5cee5f
Header Images: Add suggested dimensions to the media workflow.
...
props ehg, gcorne.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28030 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:54:44 +00:00
Andrew Nacin
e0989568d2
TinyMCE help: Break up strings changed in [28027] for ease of changing later.
...
Restores a not inaccurate paragraph to reduce churn.
see #27100 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28028 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-08 01:18:15 +00:00
Andrew Ozz
4360d117e2
TinyMCE help modal:
...
- Don't load the old tiny_mce_popup.js.
- Add the shortcut for <code> and the second shortcut for link to the shortcuts listing.
- Update some of the text.
See #27100
git-svn-id: https://develop.svn.wordpress.org/trunk@28027 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 23:52:55 +00:00
Drew Jaynes (DrewAPicture)
c386c17457
Improve hook docs for the wp_enqueue_editor hook, added in 3.9.
...
See #16284 , #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28026 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 23:08:46 +00:00
Andrew Ozz
e28f610ead
Fix typo and add more text to the error shown when 'wpdialogs' is not enqueued. Add 'wp_enqueue_editor' action fired when scripts and styles for the editor are being enqueued, fixes #16284
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28024 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:54:13 +00:00
Scott Taylor
0d6acf5b5b
Make playlist tracks keyboard-accessible.
...
Fixes #27644 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28023 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:27:06 +00:00
Andrew Nacin
82bc9c1142
Rename USE_EXT_MYSQL to WP_USE_EXT_MYSQL. see #21663 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28022 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:26:19 +00:00
Andrew Nacin
9bb79a1a97
Clean up deprecated format_to_post() docs. see #27700 .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28021 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:23:00 +00:00
Drew Jaynes (DrewAPicture)
0bd5e6c02e
More formatting for functions deprecated in 3.9.
...
Props kpdesign.
Fixes #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28020 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:16:37 +00:00
Helen Hou-Sandi
784d1dc9bf
Only show the media library loading spinner if we're scrolled toward the bottom. Prevents the spinner from flashing a second time when first loading the library due to a second query firing after initial load.
...
props kovshenin. fixes #24859 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28019 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:14:01 +00:00
Drew Jaynes (DrewAPicture)
8b9371e915
Even deprecated functions can use a little PHPDoc formatting, time to time.
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28018 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:11:55 +00:00
Drew Jaynes (DrewAPicture)
aba414af7e
PHPDoc fixes for functionality in wp-includes/wp-db.php added in 3.9.
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28016 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 22:01:37 +00:00
Drew Jaynes (DrewAPicture)
7736833039
PHPDoc fixes for wp_validate_logged_in_cookie(), introduced in 3.9.
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28015 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:43:00 +00:00
Drew Jaynes (DrewAPicture)
ef4d73dafc
Fix PHPDoc formatting for WP_Rewrite::add_endpoint().
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28014 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:38:34 +00:00
Andrew Ozz
5706a463bd
TinyMCE: show an error in the console when a plugin attempts to use the 'wpdialogs' plugin but wpdialog.js is not enqueued, fixes #16284
...
git-svn-id: https://develop.svn.wordpress.org/trunk@28012 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:34:18 +00:00
Drew Jaynes (DrewAPicture)
f96adcea2d
Add a missing @since 3.9.0 to the PHPDoc for wp_register_plugin_realpath().
...
See #16953 , #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28011 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:33:30 +00:00
Drew Jaynes (DrewAPicture)
18d6713716
Improve inline documentation for functionality in wp-includes/plugin.php added in 3.9.
...
See #14994 , #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28010 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:29:04 +00:00
Andrew Nacin
55d6cc4e1d
Formally deprecate wpmu_current_site().
...
props jeremyfelt.
fixes #27702 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28009 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:27:13 +00:00
nacin
5404d9933f
Gallery Views: Avoid JS errors when image attachments lack metadata.
...
props gcorne.
fixes #27691 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28008 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:24:02 +00:00
Drew Jaynes (DrewAPicture)
c765ed8832
Inline documentation fixes related to the determine_current_user filter
...
See #26706 , #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28007 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 21:17:44 +00:00
Drew Jaynes (DrewAPicture)
372e6c5c94
Inline documentation improvements in wp-includes/ms-load.php for 3.9 functionality.
...
Clarifies some mixed type parameters, spacing and comment style, and language fixes.
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28006 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:58:11 +00:00
Drew Jaynes (DrewAPicture)
9131bc6cbf
General PHPDoc improvements in wp-includes/media.php for 3.9 functionality.
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28004 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:37:17 +00:00
Drew Jaynes (DrewAPicture)
3011b3efef
Space vs tab in function descriptions for wp_underscore_audio_template() and wp_underscore_video_template().
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28003 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:28:05 +00:00
Andrew Nacin
f9e150c068
wpdb: Don't pass a second argument to mysqli_fetch_field().
...
props pento.
fixes #27693 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28002 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:21:16 +00:00
DrewAPicture
9415376529
Improve PHPDoc formatting for get_the_permalink().
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28001 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:21:02 +00:00
Drew Jaynes (DrewAPicture)
c48069343d
Use suggested language conventions in the hook docs description for the theme_page_templates filter.
...
See #27700 .
git-svn-id: https://develop.svn.wordpress.org/trunk@28000 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:17:55 +00:00
Andrew Nacin
e724e1b06f
Don't try to resolve symlinks for single-file plugins. plugins_url() should not be used in this context anyway.
...
props rmccue.
fixes #16953 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27999 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 20:14:34 +00:00
Dominik Schilling (ocean90)
51d6831f14
Update Dashicons.
...
New icons: `.dashicons-external`, `.dashicons-editor-contract` and `.dashicons-universal-access-alt`.
Updated icons: `.dashicons-code`, `.dashicons-universal-access`, `.dashicons-arrow-x-alt` and `.dashicons-arrow-x-alt2`.
Restores also `.dashicons-post-trash` as an alias for `.dashicons-trash`, which is the new one.
props melchoyce, empireoflight.
see #26936 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27989 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 17:51:44 +00:00
Scott Taylor
4322e0c50a
Browsers other than Firefox need a timeout when parsing audio and video shortcodes into MCE views.
...
See [27655].
git-svn-id: https://develop.svn.wordpress.org/trunk@27987 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 15:11:04 +00:00
Dominik Schilling (ocean90)
da677f34aa
Widget Customizer: Move WidgetCustomizer to wp.customize.Widgets. First pass.
...
see #27690 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27985 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 09:03:18 +00:00
Dominik Schilling (ocean90)
b0ba84a25c
Remove trailing whitespace from [27982].
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27984 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 09:02:06 +00:00
Andrew Ozz
8b3f6ef9fa
TinyMCE: couple more small css tweaks for the menubar and tabs in native modals, see #27279
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27983 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 07:10:14 +00:00
Andrew Ozz
658b5a5e15
Add a note that wpView is "experimental", see #26959
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27982 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:58:58 +00:00
Andrew Ozz
9c3da74353
Heartbeat: no longer "experimental", see #25272
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27981 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:32:52 +00:00
Scott Taylor
f48e74e789
Only set the poster attribute automatically for videos when the image does not match the default mime-type icon. wp_prepare_attachment_for_js() is used in multiple contexts. This context requires disambiguation.
...
See [27659].
git-svn-id: https://develop.svn.wordpress.org/trunk@27980 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:19:51 +00:00
Scott Taylor
d11d19a2b7
[27640] supported a caption for audio and video shortcodes as part of a UX iteration for the related MCE views. These captions have since be excluded, so the extra code should be removed (it was there for this sole reason).
...
See #27320 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27979 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 06:12:06 +00:00
Andrew Ozz
53ce07bf36
TinyMCE:
...
- Tighten up button styles, add :hover for .mce-active buttons.
- Pad only the first toolbar row and remove the padding in both toolbars if the editor doesn't have a DFW mode.
Part props avryl, see #27279
git-svn-id: https://develop.svn.wordpress.org/trunk@27978 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-07 01:09:38 +00:00
Scott Taylor
5d3e7be690
When dynamically instantiating MediaElementPlayer instances in JS, preload="metadata" is extremely wonky. preload="none" lets the file play right away.
...
This has already been addressed for audio|video shortcodes, but also needs to be the case for playlists. When loading a playlist from a DOM cache or via AJAX, and when the sources match those already pre-loaded, the browser will sometimes donkey-punch the HTTP request for the first cached track selected.
Set `preload="none"` for the empty `<audio|video>` tag for playlists.
See commits related to #26779 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27974 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 21:33:00 +00:00
Dominik Schilling (ocean90)
e4d4e0020b
Widget Customizer: Remove leading/trailing whitespace to prevent jQuery migrate warning.
...
props gcorne.
fixes #27689 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27973 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 20:39:33 +00:00
Dominik Schilling (ocean90)
020e3ef811
Update TinyMCE help for pasting content.
...
props chiragswadia.
see #27100 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27972 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:45:07 +00:00
Dominik Schilling (ocean90)
0e8bd0b455
Header images: Revert unnecessary tabindex="0" from [27947].
...
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27971 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:35:24 +00:00
Dominik Schilling (ocean90)
2f0a34dbb8
Header images: Improve accessibility of Randomize buttons.
...
props ehg.
see #27598 , #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27970 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 19:27:40 +00:00
Dominik Schilling (ocean90)
8708a44d4a
Widget Customizer: Minor code cleanup.
...
* Remove type hinting from `WP_Customize_Widgets`
* Rename `inject_preview_css` to `print_preview_css`
* Remove stray `@todo`
fixes #27534 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27968 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:53:31 +00:00
Dominik Schilling (ocean90)
bccc4ea750
Fix whitespace around $GLOBALS['_wp_deprecated_widgets_callbacks'] .
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27967 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:49:48 +00:00
Dominik Schilling (ocean90)
a2c020e068
WP_Widget: Introduce is_preview() method.
...
With the Widget Customizer it's possible that previewed widgets can leak data outside of Customizer, when the widget uses the cache API.
The Customizer calls the regular update callback which should already refresh the cache. Since cache additions aren't blocked yet the cache can be filled with preview data.
To prevent this issue `WP_Widget::is_preview()` will return true, when `$wp_customize->is_preview()` returns true. If `is_preview()` is true, cache additions are suspended via `wp_suspend_cache_addition()`. Make sure your object cache drop-in has implemented `wp_suspend_cache_addition()`.
`is_preview()` can/should also be used inside `WP_Widget::widget()`, see WP_Widget_Recent_Posts or WP_Widget_Recent_Comments for examples.
For more info see IRC logs: http://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-04-02&sort=asc#m824279
props westonruter.
fixes #27538 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27966 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-06 18:47:46 +00:00
Scott Taylor
1ff1343a82
Revert the changes made to data.title in playlist Underscore templates in [27869]. {{ data.title }} causes the title to be double-encoded on the front end.
...
See #27574 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27960 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 20:05:04 +00:00
Andrew Nacin
631b55ac0b
Don't pass variables by reference.
...
props markjaquith.
fixes #27656 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27957 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 18:16:45 +00:00
Sergey Biryukov
4a197c45a2
Avoid an undefined index notice in wp_http_validate_url().
...
props jesin.
fixes #27684 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27953 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 12:44:19 +00:00
Drew Jaynes (DrewAPicture)
6c7aabda19
Fix a typo in the PHPDoc description for the WP_Http_Curl->max_body_length property.
...
Props eightface.
Fixes #27681 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27952 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 05:47:54 +00:00
Andrew Ozz
36f0a60829
Throw a user notice when the editor ID used for TinyMCE contains brackets, props nacin, fixes #27601
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27950 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-05 01:10:19 +00:00
Andrew Ozz
548772fcc1
TinyMCE: update the default style for html5-captions, props obenland fixes #26642
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27949 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 23:11:21 +00:00
Andrew Ozz
63bf25ec1f
Edit image modal: check if full size exists before trying to use it for setting aspect ratio, props gcorne, see #27366
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27948 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 18:00:04 +00:00
Andrew Nacin
6ec7a5a52b
Header images: Accessibility and style improvements. Headers no longer jump around when chosen.
...
props mcsf, ehg.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27947 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:48:34 +00:00
Andrew Nacin
96e15acb2e
Header images: Handle cropping failures.
...
props ehg.
see #21785 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27946 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 15:47:43 +00:00
Andrew Nacin
996a502103
Add missing space between strings.
...
props rachelbaker.
fixes #27597 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27945 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 13:16:15 +00:00
Andrew Ozz
48269a7c29
TinyMCE: add image backgrounds for more and nextpage tags (also jshint fix for theme.js). Fixes #27106
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27944 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 05:22:47 +00:00
Drew Jaynes (DrewAPicture)
e9f0de0951
Remove a blank line and @global reference in the PHPDoc for comment_author_email_link().
...
Props norcross, ocean90.
Fixes #27655 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27943 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 04:35:20 +00:00
Andrew Ozz
ee33326f32
Edit image modal:
...
- Make the calculation of the aspect ratio more robust.
- Better getting of the image height and width.
Props gcorne, see #27366
git-svn-id: https://develop.svn.wordpress.org/trunk@27942 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-04 01:48:24 +00:00
Andrew Nacin
ccb4f3714a
Database: Fall back from ext/mysqli to ext/mysql if the connection fails.
...
This allows us to avoid breaking a site that works under ext/mysql but is misconfigured for ext/mysqli.
props pento.
see #21663 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27935 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 21:57:22 +00:00
Andrew Ozz
641f9f9a93
TinyMCE: improve setting disabled/enabled/activated states on the Unlink button, fixes #27309
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27934 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 20:04:44 +00:00
Dominik Schilling (ocean90)
de2c9e23cf
Plupload wrapper: Call init callback on PostInit event.
...
Fixes the background image uploader in Customizer, which was broken after [27316].
fixes #27620 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27933 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 19:43:53 +00:00
Dion Hulse
ce76432676
Background Updates: Fix a PHP Warning caused by a Upgrader instance being passed into the Theme & Plugin $extra_stats parameter. See #27633
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27928 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 05:32:02 +00:00
Andrew Ozz
f57853519f
TinyMCE: update translatable strings, see #27453 , #24067
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27927 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 05:15:59 +00:00
Andrew Nacin
0faaacc7c8
Database: Add $allow_bail argument to wpdb::check_connection() to match the connect method.
...
props DrProtocols, pento.
fixes #27240 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27925 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 04:05:31 +00:00
Andrew Ozz
74ec183ee7
TinyMCE:
...
- Bring back loading of /langs/[locale].js and /langs/[locale]_dlg.js from PHP. Prevents errors with missing translation files when custom plugins use requireLangPack() without second argument.
- Back to using ISO 639-1 (two letter) locales as the locale is used as part of the translation file name.
See #24067 , fixes #27610
git-svn-id: https://develop.svn.wordpress.org/trunk@27922 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:39:21 +00:00
Andrew Ozz
26391af850
Edit Image modal:
...
- Fix issue with adding a link to an image that didn't have one previously.
- Adjust the look-and-feel of the advance options toggle so that it becomes a section heading that can be open/closed.
- Add a Custom Size option to the size drop-down that reveals fields for soft-resizing the image inserted into the post.
Props gcorne, and props sdasse for the design help, see #27366
git-svn-id: https://develop.svn.wordpress.org/trunk@27918 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:20:40 +00:00
Andrew Nacin
66f20812b9
Remove old links_recently_updated_* DB options that never had a UI.
...
fixes #27649 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27916 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-03 03:09:59 +00:00
Andrew Nacin
87bc851561
Remove <br> elements for HTML5 galleries.
...
props obenland.
fixes #27637 , see #26697 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27914 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 21:49:38 +00:00
Dominik Schilling (ocean90)
c65af080fd
Update suggest.min.js for [26333].
...
see #26110 , #27599 .
fixes #27621 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27911 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 19:04:56 +00:00
Dominik Schilling (ocean90)
b0fae8aa2a
Widget Customizer: Remove leading underscores from public methods.
...
Fix also an incorrect hook name in `stop_capturing_option_updates()`.
props DrewAPicture.
see #27534 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27910 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 18:30:06 +00:00
Scott Taylor
f17d9491b1
Fix a regression caused by [27622] in prepend_attachment() by passing all attachments that are not audio or video to the else clause.
...
Fixes #27634 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27908 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 17:13:09 +00:00
Dominik Schilling (ocean90)
b5780fa7b8
Widget Customizer: Improve plugin compatibility.
...
Some plugins are using custom scripts and styles for there widgets. These are available on the Widgets screens, but not in the Customizer yet.
Scripts and styles can be enqueued via:
* `admin_enqueue_scripts`
* `admin_print_scripts` and `admin_print_scripts-widgets.php`
* `admin_print_styles` and `admin_print_styles-widgets.php`
* `admin_print_footer_scripts` and `admin_footer-widgets.php`
All this hooks are now called in the Customizer too.
Previously we have add the `#widgets-right` ID to a container div via jQuery. Remember: `#widgets-right` exists on the Widgets screen and is used by many plugins to do event delegation from that element.
But since our script files are loaded in the footer, the JavaScript way is a bit late for some plugins.
We have decided to add a `div#widgets-right` container element to customizer. "Less hacky hack."
props westonruter, ocean90. Thanks dpe415 for testing.
fixes #27619 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27907 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 17:03:14 +00:00
Dion Hulse
c86d9021c5
Background Updates: Fix two variable typos in r27905
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27906 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 13:12:28 +00:00
Dion Hulse
48025fabd5
Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27905 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 13:04:30 +00:00
Drew Jaynes (DrewAPicture)
adf5fb1fe1
Coding standards and readability spacing for WP_Customize_Widgets.
...
Also explicitly re-mark `_capture_filter_pre_update_option()` and `_capture_filter_pre_get_option()` as public.
See #27534 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27904 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 06:11:49 +00:00
Drew Jaynes (DrewAPicture)
0db976f610
Second-pass inline documentation improvements for WP_Customize_Widgets.
...
See #27534 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27903 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 05:44:54 +00:00
Drew Jaynes (DrewAPicture)
d615eb4ee2
Improve some inline documentation for class properties in WP_Customize_Section.
...
Props leewillis77 for the initial patch.
Fixes #26245 .
git-svn-id: https://develop.svn.wordpress.org/trunk@27902 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 03:01:31 +00:00
Andrew Ozz
7b272d3a26
Drag and drop files on the editor to upload: add new argument to wp_editor() to enable, fixes #27465
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27901 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:41:24 +00:00
Andrew Ozz
c28fff3b65
wpLink: fix spinners selectors and add some throttling when searching with AJAX while the user is typing, fixes #27615
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27900 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:26:12 +00:00
Andrew Ozz
c5f7f95979
Gallery preview: add a "No items found" state which is displayed when rendering the gallery wpview and no attachments are found. Props gcorne, fixes #27558
...
git-svn-id: https://develop.svn.wordpress.org/trunk@27899 602fd350-edb4-49c9-b593-d223f7449a82
2014-04-02 02:17:39 +00:00