vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,386 Commits 1 Branch 0 Tags 243 MiB
dfffa2cffd
Commit Graph

1731 Commits

Author SHA1 Message Date
Drew Jaynes (DrewAPicture)
f228c5b16e Improve inline documentation of default arguments for the_title_attribute(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28498 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 02:27:08 +00:00
Scott Taylor
1b4e4e665a hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' ) 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28479 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 20:51:44 +00:00
Drew Jaynes (DrewAPicture)
b5fdb2dc06 Improve inline documentation for default arguments in wp_get_archives(). 
See #28298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28476 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-18 17:19:56 +00:00
Scott Taylor
5eecd2e62b Eliminate the use of extract() in MO::import_from_reader(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28472 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 17:20:26 +00:00
Scott Taylor
7205796cec Eliminate the use of extract() in get_pages(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28471 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 17:11:23 +00:00
Scott Taylor
b76a0d791b Eliminate the use of extract() in wp_insert_attachment(). 
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28470 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 16:53:44 +00:00
Scott Taylor
9787ea4e2a Eliminate the use of extract() in wp_insert_post(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28469 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 15:52:11 +00:00
Scott Taylor
ff8ae69fce Eliminate the use of extract() in wp_delete_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28466 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:54:03 +00:00
Scott Taylor
06c87f681a Eliminate the use of extract() in get_terms(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28465 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:46:07 +00:00
Scott Taylor
02066d4241 Eliminate the use of extract() in wp_insert_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28464 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-17 14:15:40 +00:00
Scott Taylor
b1b30ad58c Eliminate use of extract() in wp_update_term(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28461 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 21:28:05 +00:00
Scott Taylor
54bc77cb93 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around. 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28460 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 21:08:15 +00:00
Scott Taylor
cb3341c03d (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28459 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 20:51:23 +00:00
Scott Taylor
8d22270bc1 Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28458 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 19:32:05 +00:00
Scott Taylor
59f8ba6c9e Eliminate use of extract() in wp_insert_comment(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28457 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:51:41 +00:00
Andrew Ozz
6fa89637e5 DFW: fix closing only the wpLink or media modal when pressing Esc. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28455 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:16:59 +00:00
Scott Taylor
0d92bb2552 Eliminate use of extract() in wp_insert_user(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28454 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:15:00 +00:00
Scott Taylor
61d2e52e4b In wp_xmlrpc_server::mw_editPost, also set $post_type = $postdata['post_type']. 
See #22400, [28448].



git-svn-id: https://develop.svn.wordpress.org/trunk@28453 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 18:05:21 +00:00
Scott Taylor
8a25c0ea1e Eliminate use of extract() in wp_widget_rss_form(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28449 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 15:37:53 +00:00
Scott Taylor
cf3574516a Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all). 
A lot of the extracted variables are overwritten by being explicitly set later. 
Only set variables that would otherwise not be present with `compact()` is called.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28448 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 15:18:17 +00:00
Sergey Biryukov
4585195977 Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings. 
props GaVrA.
fixes #23800.

git-svn-id: https://develop.svn.wordpress.org/trunk@28444 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 11:09:28 +00:00
Sergey Biryukov
6100833f0c DFW: Properly handle Esc key when the content is focused or when switching browser tabs. 
props avryl.
fixes #28279.

git-svn-id: https://develop.svn.wordpress.org/trunk@28443 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-16 10:42:03 +00:00
Sergey Biryukov
e76bfbefbd Don't include caption tags in gallery template when there is no caption. 
props avryl.
fixes #28089.

git-svn-id: https://develop.svn.wordpress.org/trunk@28442 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 21:02:04 +00:00
Scott Taylor
ae938f524e Eliminate use of extract() in wp_get_object_terms(). 
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28441 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 19:57:57 +00:00
Scott Taylor
1b93413580 Eliminate use of extract() in wp_widget_rss_output(). 
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback). 
Every other default arg has a default value of `0`.

`items` is expected to always be passed to this function.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28440 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 19:41:41 +00:00
Scott Taylor
ce6f3de8ff Eliminate use of extract() in WP_Widget_RSS::widget(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28439 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 19:35:31 +00:00
Scott Taylor
5c28e2986c In Walker_Category::start_el(), $title might not be set when $args are passed multiple levels into walk_category_tree(). 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28438 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 19:13:45 +00:00
Scott Taylor
ce5a31cd62 Eliminate use of extract() in wp_allow_comment(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28437 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 18:09:09 +00:00
Scott Taylor
737ad1a878 Eliminate use of extract() in Walker_Category::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28436 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 17:57:13 +00:00
Scott Taylor
cc64187e28 Eliminate use of extract() in wp_generate_tag_cloud(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28435 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 17:47:21 +00:00
Scott Taylor
7793a90fd1 Eliminate use of extract() in wp_list_categories(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28434 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 17:27:18 +00:00
Scott Taylor
812493f259 Eliminate use of extract() in default-widgets.php. 
Props rzen, wonderboymusic.

See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28433 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 16:32:18 +00:00
Scott Taylor
29efc53b6a Eliminate use of extract() in wp_dropdown_categories(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28432 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 15:47:43 +00:00
Scott Taylor
4aa28e9cdc Eliminate use of extract() in get_comment_reply_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28431 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 15:34:37 +00:00
Scott Taylor
7d8a053aeb Eliminate use of extract() in WP_Ajax_Response::add(). Just set most of the properties to variables to avoid interpolation churn. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28430 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 15:24:21 +00:00
Scott Taylor
e06aa222ea Eliminate the use of extract() in get_post_reply_link(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28429 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:48:16 +00:00
Scott Taylor
2a5a75e6d3 Eliminate the use of extract() in wp_list_comments(). All unit tests pass. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28428 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:42:19 +00:00
Scott Taylor
95394c6e7e Eliminate the use of extract() in wp_update_comment(). All unit tests pass. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28427 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:36:17 +00:00
Scott Taylor
bb4ea7ae3f Eliminate the use of extract() in wp_check_filetype_and_ext(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28426 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:21:51 +00:00
Scott Taylor
6dd449551e Eliminate the use of extract() in wp_mail(). Check the filtered array for each value before re-setting variables. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28425 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:16:34 +00:00
Scott Taylor
3c418d4b57 Eliminate the use of extract() in wp_validate_auth_cookie(). 
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28424 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 06:10:21 +00:00
Scott Taylor
034de7f1de Eliminate the use of extract() in get_objects_in_term(). Only one property (order) was extracted. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28423 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:42:55 +00:00
Scott Taylor
e00ce3ae95 Eliminate the use of extract() in WP_Tax_Query::get_sql(). All unit tests still pass. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28422 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:40:40 +00:00
Scott Taylor
17edee17af Eliminate the use of extract() in the_taxonomies(). Adds unit test. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28421 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:24:54 +00:00
Scott Taylor
a3c9e611a8 Eliminate the use of extract() in wp_dropdown_users(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28420 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:17:12 +00:00
Scott Taylor
f116de6203 Set @param back to $output, not $html, in the inline filter docs. This was a copy/paste mistake. 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28419 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 05:07:18 +00:00
Scott Taylor
3e54a1fab5 Eliminate use of extract() in get_the_taxonomies(). Adds unit test. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28415 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:50:46 +00:00
Scott Taylor
e135cc2076 Eliminate use of extract() in gallery_shortcode(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28414 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:40:46 +00:00
Scott Taylor
e9f929443f Update the inline docs for add_shortcode() to eliminate suggestion to use extract(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28413 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:27:17 +00:00
Scott Taylor
9d873771b7 Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28412 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 03:24:40 +00:00
Scott Taylor
27ff2a1cd0 Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28407 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:45:01 +00:00
Scott Taylor
da440f54fd Eliminate use of extract() in wp_list_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28405 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:17:52 +00:00
Scott Taylor
30564338b0 Eliminate use of extract() in _walk_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28404 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 02:04:50 +00:00
Scott Taylor
0dd9d3aeff Eliminate use of extract() in get_bookmarks(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28403 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:57:24 +00:00
Scott Taylor
61faf32275 Eliminate use of extract() in Walker_Page::start_el(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28402 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:40:48 +00:00
Scott Taylor
c96d4a94b9 Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28401 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:21:20 +00:00
Scott Taylor
e4a800238f Eliminate use of extract() in wp_dropdown_pages(). 
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28399 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 01:11:21 +00:00
Scott Taylor
21e0370e5c Eliminate use of extract() in wp_link_pages(). 
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28398 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-15 00:43:40 +00:00
Scott Taylor
9e07b1037e Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28397 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-14 22:28:08 +00:00
Scott Taylor
540826e4e3 Eliminate use of extract() in wp_list_authors(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28392 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 06:01:33 +00:00
Scott Taylor
ba8e36f94c Eliminate use of extract() in the_title_attribute(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28383 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:47:11 +00:00
Scott Taylor
42d6b5dd1e Eliminate use of extract() in trackback_url_list(). 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28382 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:43:22 +00:00
Scott Taylor
671b47ef73 Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28381 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:39:17 +00:00
Scott Taylor
77731c03fc Eliminate use of extract() in wp_get_archives(). 
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28379 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:28:56 +00:00
Drew Jaynes (DrewAPicture)
3c80d5f86a Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28378 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:28:30 +00:00
Drew Jaynes (DrewAPicture)
e2219e3d48 Add a complete short description to the get_attached_media filter documentation. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28377 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-13 04:20:12 +00:00
Scott Taylor
961f52d367 Add xps and oxps extensions to list of supported document types. 
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.



git-svn-id: https://develop.svn.wordpress.org/trunk@28372 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 07:18:06 +00:00
Scott Taylor
8dc4b88fcf In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true. 
Props adamsilverstein.
Fixes #23954.



git-svn-id: https://develop.svn.wordpress.org/trunk@28371 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 07:02:05 +00:00
Scott Taylor
e8b8e881b2 Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath. 
Props Otto42 for the initial patch.
Fixes #25243.



git-svn-id: https://develop.svn.wordpress.org/trunk@28370 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:24:58 +00:00
Scott Taylor
e1b341cc59 In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border. 
Props avryl.
Fixes #27949.



git-svn-id: https://develop.svn.wordpress.org/trunk@28369 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 06:18:02 +00:00
Scott Taylor
4826c12c47 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. 
Props celloexpressions.
Fixes #27516.



git-svn-id: https://develop.svn.wordpress.org/trunk@28365 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 02:22:42 +00:00
Scott Taylor
9705736cdf When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. 
Fixes #27971.



git-svn-id: https://develop.svn.wordpress.org/trunk@28364 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 02:06:36 +00:00
Scott Taylor
487da46928 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge. 
Fixes #27368.



git-svn-id: https://develop.svn.wordpress.org/trunk@28363 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 01:27:29 +00:00
Scott Taylor
b70967302b In get_the_author_posts(), if there is no current $post, return 0 and bail. 
Props krogsgard, aaroncampbell.
Fixes #27998.



git-svn-id: https://develop.svn.wordpress.org/trunk@28362 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:25:29 +00:00
Scott Taylor
8998c015b3 MediaElement players need clear: both to play nice with adjacent floated elements. 
Fixes #27385.



git-svn-id: https://develop.svn.wordpress.org/trunk@28361 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-11 00:13:49 +00:00
Scott Taylor
2808673b0c Remove the title attribute from markup generated in wp-includes/category-template.php: 
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	



git-svn-id: https://develop.svn.wordpress.org/trunk@28359 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:56:12 +00:00
Scott Taylor
a398f38024 First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28358 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 23:35:08 +00:00
Drew Jaynes (DrewAPicture)
cb5852a813 Add inline documentation of the default arguments for wp_list_pages(). 
Props garza for the initial patches.
Fixes #11338.


git-svn-id: https://develop.svn.wordpress.org/trunk@28357 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-10 08:01:13 +00:00
Scott Taylor
7531fd0070 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28343 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 18:24:47 +00:00
Scott Taylor
bfe7d38650 audio, video, and playlist shortcodes: 
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.



git-svn-id: https://develop.svn.wordpress.org/trunk@28342 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 17:35:09 +00:00
Scott Taylor
4bddd84276 In wpdb, remove dead code: 
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28339 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:55:32 +00:00
Scott Taylor
e47eb14575 In WP_Widget::update_callback(), $sidebars_widgets is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28338 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:51:31 +00:00
Scott Taylor
f945487f45 In wp-includes/theme.php, break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28337 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:49:19 +00:00
Scott Taylor
b99dead052 In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28336 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:46:11 +00:00
Scott Taylor
b62ca9c298 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28335 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:44:06 +00:00
Scott Taylor
f63b6cde3a In wp-includes/revision.php - remove dead code: 
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28334 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-07 03:37:45 +00:00
Scott Taylor
098a5145c5 In WP_Query, remove duplicate variable setting: 
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28333 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:42:28 +00:00
Scott Taylor
16a58e34a2 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming. 
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28332 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:38:23 +00:00
Scott Taylor
11e65eb200 In wp_get_attachment_link(), $post_title is set and then not used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28331 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:34:10 +00:00
Scott Taylor
b626b11590 In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28330 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:32:25 +00:00
Scott Taylor
3f2a078f5e In get_network_by_path(), $exact_domains is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28329 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:31:14 +00:00
Scott Taylor
24b03d819b In update_metadata_by_mid(), $original_value is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28328 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:28:02 +00:00
Scott Taylor
e95edb29aa In edit_post_link(), $post_type_obj is unused. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28327 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:26:20 +00:00
Scott Taylor
5cf2a50dba In paginate_links(), break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28326 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:24:22 +00:00
Scott Taylor
ef5998eabb In wp-includes/functions.php, remove dead code: 
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28325 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:22:22 +00:00
Scott Taylor
5e90fb1b3e In wp_set_comment_status(), the default case returns, so no default value for $status is needed. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28324 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:16:42 +00:00
Scott Taylor
5530fe4c11 In wp-includes/comment-template.php, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28323 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:14:35 +00:00
wonderboymusic
2b1c764ec7 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used. 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28322 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 21:08:02 +00:00
Sergey Biryukov
18916debfd Update deleted site message in ms_site_check(). 
props boonebgorges.
fixes #28150.

git-svn-id: https://develop.svn.wordpress.org/trunk@28321 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:45:54 +00:00
Scott Taylor
0f4f941900 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28320 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:36:34 +00:00
Scott Taylor
9ad07c8c28 In wp-includes/class-wp-customize-setting.php, break is unreachable after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28319 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:33:03 +00:00
Scott Taylor
376125e0b7 In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28318 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:28:46 +00:00
Scott Taylor
c5463c5cb2 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28317 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:26:00 +00:00
Scott Taylor
5df63351b2 In wp-includes/bookmark.php, remove dead code: 
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28316 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 18:21:50 +00:00
Sergey Biryukov
d7a159bf81 Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.

git-svn-id: https://develop.svn.wordpress.org/trunk@28285 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 11:57:36 +00:00
Drew Jaynes (DrewAPicture)
8764f791f1 Where a filter no longer exists, it need not be notated. 
Fixes #24444. See r28258.


git-svn-id: https://develop.svn.wordpress.org/trunk@28283 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:37:17 +00:00
Andrew Nacin
cb022f4957 Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression. 
props jeremyfelt.
fixes #27927.


git-svn-id: https://develop.svn.wordpress.org/trunk@28280 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:31:12 +00:00
Andrew Nacin
7839dd671c Multisite: Fix case sensitivity regressions in 3.9. 
props jeremyfelt.
fixes #27866.


git-svn-id: https://develop.svn.wordpress.org/trunk@28276 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 05:23:56 +00:00
Scott Taylor
a1c6a10489 In general-template.php - remove dead code: 
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28274 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:57:22 +00:00
Andrew Nacin
7ada7af9d0 Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers. 
props rzen, ehg.
fixes #27848.


git-svn-id: https://develop.svn.wordpress.org/trunk@28266 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 04:13:52 +00:00
Scott Taylor
eda51bf856 Remove duplicate variable setting for $link in wp_list_authors(). 
See #27882.



git-svn-id: https://develop.svn.wordpress.org/trunk@28265 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-06 03:51:42 +00:00
Scott Taylor
2b1619329e Add .dfxp and .srt files to mime-type whitelist in wp_get_mime_types(). They are both captioning formats supported by MediaElement. 
Props joedolson.
Fixes #27643.



git-svn-id: https://develop.svn.wordpress.org/trunk@28259 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 20:07:53 +00:00
Scott Taylor
5c306af76d When $type is atom in get_the_category_rss(), use get_bloginfo_rss( 'url' ) when setting the scheme attribute for the <category> node. 
Props ejdanderson.
Fixes #24444.



git-svn-id: https://develop.svn.wordpress.org/trunk@28258 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 19:04:39 +00:00
Scott Taylor
fc4dfba1b8 Remove by-reference modifiers from arguments in wp_remote_retrieve_* functions. 
Props jesin.
Fixes #27687.



git-svn-id: https://develop.svn.wordpress.org/trunk@28257 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-05 18:45:14 +00:00
Scott Taylor
89ecbcc7cb In WP_Date_Query::get_sql_for_subquery(), don't parse duplicate parameters - only parse one of w and week or month and monthnum. 
Adds unit tests.

Props oso96_2000, ChriCo.
Fixes #25835.



git-svn-id: https://develop.svn.wordpress.org/trunk@28252 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 23:06:07 +00:00
Scott Taylor
61765b8efd Set the proper value for wp_title() when is_author() and is_post_type_archive() are both true. post_type should always win due to the precedence indicated in get_queried_object(). 
Props mordauk.
Fixes #25398.



git-svn-id: https://develop.svn.wordpress.org/trunk@28251 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 22:20:47 +00:00
Sergey Biryukov
ece95a0257 Prevent 'paged-*' from being added to body classes on 404 error pages. 
props psoluch.
see #16468.

git-svn-id: https://develop.svn.wordpress.org/trunk@28249 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-04 13:16:13 +00:00
Drew Jaynes (DrewAPicture)
5ad1751132 Improve inline documentation for the wpdb::$show_errors property. 
Note that SQL/DB errors are displayed by default if both WP_DEBUG and WP_DEBUG_DISPLAY evaluate to true.

Props ericlewis.
Fixes #16615.


git-svn-id: https://develop.svn.wordpress.org/trunk@28243 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 12:18:07 +00:00
Sergey Biryukov
da6a3d1745 Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu(). 
props Tmeister.
fixes #27745.

git-svn-id: https://develop.svn.wordpress.org/trunk@28242 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:58:51 +00:00
Sergey Biryukov
6c401709f6 Correct 'show_in_menu' parameter description in register_taxonomy(). 
fixes #27943.

git-svn-id: https://develop.svn.wordpress.org/trunk@28241 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:28:05 +00:00
Sergey Biryukov
b9834e8275 Correct @return value for current_time(). 
props arnee.
fixes #27940.

git-svn-id: https://develop.svn.wordpress.org/trunk@28240 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 11:24:23 +00:00
Dominik Schilling (ocean90)
cb9480b4eb Update jQuery to 1.11.1. 
fixes #28103.

git-svn-id: https://develop.svn.wordpress.org/trunk@28238 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-02 09:28:55 +00:00
Sergey Biryukov
2558cf0139 Fix arrow positioning in "Insert/edit link" modal. 
props avryl, sergej.mueller.
fixes #28096.

git-svn-id: https://develop.svn.wordpress.org/trunk@28236 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 21:20:16 +00:00
Andrew Nacin
790cb99b27 Shortcode JS: Avoid errors when an escaped shortcode includes a newline between brackets. 
props gcorne.
props Clorith, jorbin for tests.
see #27907, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28223 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-01 03:36:27 +00:00
Andrew Nacin
e18e93bb80 Improve TinyMCE string for paste command browser support. 
props ebinnion.
fixes #27988.


git-svn-id: https://develop.svn.wordpress.org/trunk@28220 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 21:19:35 +00:00
Dominik Schilling (ocean90)
a13b695fbd Customizer: Allow to skip cropping header images if image width is smaller than or equal to theme width. 
Add tests.

see #27936 for trunk.

git-svn-id: https://develop.svn.wordpress.org/trunk@28219 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 20:24:28 +00:00
Dominik Schilling (ocean90)
fd26def119 Revert [28217]. 
Misfired commit for #27936.

git-svn-id: https://develop.svn.wordpress.org/trunk@28218 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 20:17:59 +00:00
Dominik Schilling (ocean90)
5d8f69e0c5 Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28217 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 14:20:05 +00:00
Drew Jaynes (DrewAPicture)
609cf29058 Clean up duplicate hook notations and adjacency for calls to the wp_signup_location filter. 
Also adds braces missed in [25535].

See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28215 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 07:11:32 +00:00
Drew Jaynes (DrewAPicture)
9c66e66ac5 Ensure the wp_set_comment_status action hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28214 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:54:33 +00:00
Drew Jaynes (DrewAPicture)
bf8c70a4ee Ensure the style_loader_tag filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28209 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:28:19 +00:00
Drew Jaynes (DrewAPicture)
9da8915408 Ensure the register filter hook is only documented once. 
See #26869.


git-svn-id: https://develop.svn.wordpress.org/trunk@28208 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 06:23:31 +00:00
Mark Jaquith
c4dd499979 Use '&mdash; Select &mdash;' instead of '-- Select --' for nav menus. Looks nicer. 
see #27878

git-svn-id: https://develop.svn.wordpress.org/trunk@28205 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-25 00:34:20 +00:00
Mark Jaquith
65b0b658d7 Force users to choose a nav menu in the custom nav menu widget, for a better customizer UX 
Before, they had to make a dummy change to get it to render. Now they
are made to choose a nav menu from the dropdown, which feels more
natural.

fixes #27878 for trunk. props westonruter

git-svn-id: https://develop.svn.wordpress.org/trunk@28197 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 20:44:32 +00:00
Dominik Schilling (ocean90)
0202625937 Recent Posts Widget: Use ob_end_flush() instead of ob_flush(). 
`ob_end_flush()` flushes the output buffer *and* turns output buffering off, same as `ob_get_flush()`.

props m_i_n.
see #28009 for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28195 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 19:47:09 +00:00
John Blackbourn
2d3568380b Remove some unnecessary abstraction introduced in [28191]. See #27985. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28194 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 11:54:31 +00:00
Andrew Ozz
fff29139b5 TinyMCE: update the 'paste' plugin to the latest dev. version. Included changes: 1b7c41cd7b and 7998b8025d. See #27909, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28192 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-24 00:58:13 +00:00
johnbillion
34b0686be1 Avoid an expensive attachment counting query on the post editing screen. See #27985, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28191 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 22:04:03 +00:00
Andrew Ozz
a6de675d14 TinyMCE: when adding a caption to an image that is in a paragraph with other text, move the caption node above the paragraph instead of below. See #27922, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28190 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 20:41:59 +00:00
Andrew Ozz
c602aac562 Drag/drop on the editor to upload: don't trigger the uploader when selected test is being dragged from one window to another. See #27880, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28189 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-23 20:34:43 +00:00
Andrew Ozz
a528be21ad Run WP_Editors::enqueue_scripts() on admin_print_footer_scripts priority 1 (later), instead of admin_footer. Fixes incompatibility with the customizer. Props feedmeastraycat, see #27853, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28187 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 22:40:33 +00:00
Andrew Ozz
db22ae4e32 TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847, for trunk. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28185 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 21:10:14 +00:00
Scott Taylor
77c156631a Alter the layout of the checkboxes in the modal view for Audio/Video Details to allow translations more room to breathe. 
See #27893.



git-svn-id: https://develop.svn.wordpress.org/trunk@28184 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 20:28:35 +00:00
Scott Taylor
4507f1e04f Persisting <track> elements as the body of a [video] shortcode in MCE Views: 
* When generating the view's HTML, ensure that the shortcode's `content` is added to the model
* Add a `PostProcess` event in the `wpview` plugin to properly return the shortcode when the editor mode is toggled, ensuring that elements in the body are not dropped.

Props azaozz, wonderboymusic.
See #27915.




git-svn-id: https://develop.svn.wordpress.org/trunk@28183 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 18:20:54 +00:00
Scott Taylor
97c497abc2 Refinements for asynchronous rendering in wp.mce.media.PlaylistView: 
* Add `visibility: hidden` as an inline style to `<audio>` tags, there is a race with the stylesheet which can get enqueued in the body and loaded in the footer.
* When creating new instances of `MediaElementPlayer`, always push them onto a stack. Lone views can be responsible for multiple instances of the same shortcode on render.
* Rename `wp.media.mixin.unsetPlayer()` to `wp.media.mixin.unsetPlayers()` to reflect the above.
* Call `wp.media.mixin.unsetPlayers()` on the view's `unbind()` method, instead of inline in the `render()` method
* Make sure `WPPlaylistView` is instantiated for each editor instance
* Ensure that the `No Items Found` view state is not rendered when attachments actually do exist.

Props gcorne, wonderboymusic.
See #27899.




git-svn-id: https://develop.svn.wordpress.org/trunk@28182 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 17:52:06 +00:00
Andrew Nacin
620fc6660c TinyMCE: Restore old wordpress_adv_hidden editor parameter to enable force-showing the kitchen sink. 
props azaozz.
see #27963, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28181 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 13:49:28 +00:00
Andrew Nacin
adf4aa7393 Editor: Shrink the font size for the chosen format so it fits in more locales. 
props SergeyBiryukov.
see #27903, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28180 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-22 13:23:29 +00:00
Scott Taylor
8c6b77a4da Use the proper translated string for Video Playlist "drag info" - the text displayed above the playlist's sortable attachments. 
See #27937.



git-svn-id: https://develop.svn.wordpress.org/trunk@28178 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 19:36:21 +00:00
Andrew Nacin
5295d232af Remove version string from Thickbox so it assumes the WP core version. Bust some caches. 
props celloexpressions.
see #27861, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28176 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-21 05:06:54 +00:00
Scott Taylor
99ca08fb55 Add calc() rules for max-width of playlist caption. 
Props celloexpressions.
See #27923.



git-svn-id: https://develop.svn.wordpress.org/trunk@28174 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 05:09:47 +00:00
Scott Taylor
a39eb76bc5 Support RTL properly when displaying playlists. 
Props SergeyBiryukov.
See #27924.



git-svn-id: https://develop.svn.wordpress.org/trunk@28173 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 04:26:59 +00:00
Scott Taylor
22c3cc1fec Properly account for text overflow in .wp-playlist-caption by adding display: block. 
Props celloexpressions.
See #27923.



git-svn-id: https://develop.svn.wordpress.org/trunk@28172 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 04:24:53 +00:00
Scott Taylor
47d8ce50b0 Add a compatibility layer in wp-playlist.js to avoid VM errors from MediaElement's plugin bridge in the TinyMCE views for playlists by suppressing playback for files whose mime-type is not supported in the user's browser natively. 
This is similar to how audio and video shortcodes are handled: file types are whitelisted for native playback.

See #27892.



git-svn-id: https://develop.svn.wordpress.org/trunk@28171 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-20 03:52:57 +00:00
Andrew Nacin
55a3551646 Customizer: Correct reference to the 'Add new image' button. 
props jjeaton.
see #27890, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28170 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 19:44:43 +00:00
Scott Taylor
29a1d6fe13 Don't show textareas that have "hidden" as a class in the media modal. 
See #27915.



git-svn-id: https://develop.svn.wordpress.org/trunk@28169 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:33:42 +00:00
Andrew Nacin
9ed158cc8c Properly translate 'Select Poster Image'. 
props dimadin.
see #27845, for trunk.


git-svn-id: https://develop.svn.wordpress.org/trunk@28168 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:27:51 +00:00
Andrew Nacin
9223056bb3 Fix logic inversion in [28124] to ensure widgets stay with themes during a theme switch. 
fixes #27897.


git-svn-id: https://develop.svn.wordpress.org/trunk@28161 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-19 18:11:24 +00:00
Scott Taylor
6ccd360ff4 Don't set the poster image for videos in a playlist if the image is the video mime-type icon blown up. 
See #27892.



git-svn-id: https://develop.svn.wordpress.org/trunk@28158 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-18 17:38:53 +00:00
Andrew Nacin
18f073cde0 Trunk is now 4.0-alpha. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28157 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 19:36:35 +00:00
Andrew Nacin
91f1a42b6a WordPress 3.9. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28153 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 18:00:26 +00:00
Mark Jaquith
3127edf4c8 Prevent customizer header image list from listing user images twice when no theme-specified images exist 
fixes #27839. props mcsf

git-svn-id: https://develop.svn.wordpress.org/trunk@28152 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 18:00:10 +00:00
Andrew Nacin
bd9e4f4f30 Final about page. 
props melchoyce, helen, wonderboymusic, nacin, and the illustrious Michael Pick.
fixes #27713, #27837.


git-svn-id: https://develop.svn.wordpress.org/trunk@28150 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 17:39:18 +00:00
Mark Jaquith
e05574bcf9 Ensure that wp.media.view.settings.post is set before accessing the post's id 
Avoids JS error in cases where media-editor is loaded individually
instead of with the whole `wp_enqueue_media()` process.

fixes #27836. props nacin

git-svn-id: https://develop.svn.wordpress.org/trunk@28149 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 15:25:35 +00:00
Andrew Nacin
aeef0e992a Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.


git-svn-id: https://develop.svn.wordpress.org/trunk@28145 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:37:59 +00:00
Andrew Nacin
51882f8707 Graceful failures for TinyMCE views of video/audio playlists. 
props gcorne.
fixes #27821.


git-svn-id: https://develop.svn.wordpress.org/trunk@28144 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:22:28 +00:00
Andrew Nacin
6ac55e5a83 Widgets: Remove create_function() from the customizer class. 
props westonruter.
fixes #27805.


git-svn-id: https://develop.svn.wordpress.org/trunk@28143 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:10:09 +00:00
Andrew Nacin
6196b0811e Add missing string translation in widgets. 
see #27453, #27112.


git-svn-id: https://develop.svn.wordpress.org/trunk@28140 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-16 00:00:33 +00:00
Andrew Nacin
85925b39ad Cast wp_count_attachments() before iterating it to avoid a notice when items exist without a mime type. 
props bobbingwide.
fixes #27802.


git-svn-id: https://develop.svn.wordpress.org/trunk@28139 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 23:59:48 +00:00
Andrew Nacin
31a847bb9c 3.9-RC2 
git-svn-id: https://develop.svn.wordpress.org/trunk@28135 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:58:01 +00:00
Andrew Nacin
0437f710a5 Allow the API to add text to auto update emails. 
fixes #27812.


git-svn-id: https://develop.svn.wordpress.org/trunk@28134 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 08:51:23 +00:00
Drew Jaynes (DrewAPicture)
ecbe6226fa Inline documentation for three remaining hooks in wp-includes/general-template.php. 
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.

That's 184/184 hook docs files complete. Boom!

Props kpdesign, DrewAPicture.
Fixes #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28131 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 04:41:37 +00:00
Drew Jaynes (DrewAPicture)
c91efaa74c Inline documentation for hooks in wp-includes/general-template.php. 
Props jesin, kpdesign.
See #27719.


git-svn-id: https://develop.svn.wordpress.org/trunk@28130 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 04:00:48 +00:00
Andrew Nacin
61cb5d3e49 Add a TTL to core update checks to allow us to narrow the 12-hour update window. 
props dd32.
fixes #27772.


git-svn-id: https://develop.svn.wordpress.org/trunk@28129 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 02:22:07 +00:00
Drew Jaynes (DrewAPicture)
93443ecd13 Inline documentation for hooks in wp-includes/media.php. 
Props scottlee for the initial patch. Props kpdesign, DrewAPicture.
Fixes #27718.


git-svn-id: https://develop.svn.wordpress.org/trunk@28128 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-15 01:35:49 +00:00
Andrew Nacin
16490ce89c Image Details modal: Remember the last state of the advanced toggle. 
props gcorne.
fixes #27366.


git-svn-id: https://develop.svn.wordpress.org/trunk@28125 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 23:55:04 +00:00
Andrew Nacin
a8efcb993f Customizer: Properly handle widget settings when activating a previewed theme. 
props westonruter, ocean90, gcorne.
fixes #27767.


git-svn-id: https://develop.svn.wordpress.org/trunk@28124 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 22:45:40 +00:00
Drew Jaynes (DrewAPicture)
6a8889ea8c Inline documentation for hooks in wp-includes/class-wp-customize-widgets.php 
Fixes #27531.


git-svn-id: https://develop.svn.wordpress.org/trunk@28117 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 18:40:29 +00:00
Andrew Ozz
cd356b6404 DFW: 
- Add background color and remove the top border from the status bar (at the bottom).
- Fix spinner to always be next to the Save button.
- Remove width: auto; from .mce-fixed-width.
Fixes #27709

git-svn-id: https://develop.svn.wordpress.org/trunk@28116 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 08:14:01 +00:00
Andrew Nacin
e1c90794e5 TinyMCE: Always load translations, even in English, as we modify some strings. 
Move a setting to after the translations filter, and remove unused strings.

see #24067.


git-svn-id: https://develop.svn.wordpress.org/trunk@28112 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 03:22:38 +00:00
Drew Jaynes (DrewAPicture)
7c57669ec2 Inline documentation for hooks in wp-includes/link-template.php. 
Props johnbillion, DrewAPicture.
Fixes #27716.


git-svn-id: https://develop.svn.wordpress.org/trunk@28111 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 02:12:48 +00:00
Drew Jaynes (DrewAPicture)
11f2a0dc31 Inline documentation for hooks in wp-includes/functions.php. 
Props jesin, GaryJ.
Fixes #27715.


git-svn-id: https://develop.svn.wordpress.org/trunk@28109 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:19:37 +00:00
Andrew Nacin
5b4cd4b027 Plupload: Restore 3.8 handles and filenames to avoid breaking plugins. 
fixes #27763.


git-svn-id: https://develop.svn.wordpress.org/trunk@28108 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-14 00:06:03 +00:00
Andrew Nacin
c43b8b063d Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.


git-svn-id: https://develop.svn.wordpress.org/trunk@28107 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:59:01 +00:00
Drew Jaynes (DrewAPicture)
d2e679179b Part II of inline documentation for hooks in wp-includes/post.php. 
Documents all remaining hooks following [28041] and [28042]. Also updates the hash notation style for `wp_insert_post()`.

Props nacin for several hook descriptions.

Fixes #25376.


git-svn-id: https://develop.svn.wordpress.org/trunk@28106 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 23:05:20 +00:00
Andrew Nacin
8e6a1f479b Customizer: Fix header image cropping when working with huge images. Affected Firefox in particular. 
props ehg.
fixes #27790.


git-svn-id: https://develop.svn.wordpress.org/trunk@28101 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 18:19:55 +00:00
Andrew Nacin
e164ec2461 Customizer: Account for a sidebar with no container to which classes can be added. 
props ocean90.
fixes #27780.


git-svn-id: https://develop.svn.wordpress.org/trunk@28100 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:40:07 +00:00
Andrew Nacin
f7d4569c8d Add context to string added in [28097]. 
props azaozz.
fixes #27785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28099 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:34:13 +00:00
Andrew Nacin
42f6f43c35 Add missing 'Address' string for TinyMCE. 
props pavelevap, ocean90.
fixes #27785.


git-svn-id: https://develop.svn.wordpress.org/trunk@28097 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:20:54 +00:00
Andrew Nacin
985727f256 RTL for login screen. 
props yoavf.
fixes #27784.


git-svn-id: https://develop.svn.wordpress.org/trunk@28096 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 16:05:16 +00:00
Andrew Ozz
07885ba6c9 Add hooks to the wpeditimage tinymce plugin and to the image details portion of the media modal. 
- Add wp.media.events which is intended to be a global media event bus.
- Add a post-render event to the ImageDetails view that third-party code can leverage to add subviews.
- Performance improvement for the initialization of the PostImage model.
- A bit more markup to the image details template to make it easier to add a view to the advanced options.
Props gcorne, fixes #27698

git-svn-id: https://develop.svn.wordpress.org/trunk@28095 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 04:01:53 +00:00
Andrew Ozz
3396375d47 RTL for TinyMCE: 
- Add _dir: 'rtl' to the TinyMCE translation object.
- Fix editor.css for RTL.
- Fix the Edit and Delete buttons position for wpview and images.
- For _mce_set_direction(), update documentation and fix adding the 'ltr' button.
Fixes #27773

git-svn-id: https://develop.svn.wordpress.org/trunk@28094 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-13 00:22:56 +00:00
Andrew Nacin
36f7e292d2 Add an explanation for 'Paste from Word' in the 'Paste from Text' dialog. 
fixes #27777. see #27160.


git-svn-id: https://develop.svn.wordpress.org/trunk@28091 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:47:59 +00:00
Andrew Ozz
027f0872bd Update the TinyMCE paste plugin to the latest development version. It includes a fix for pasting from Word: removes inline comments and change tracking. 
Changeset: f8cffdf342
Fixes #27771

git-svn-id: https://develop.svn.wordpress.org/trunk@28089 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 20:00:52 +00:00
Andrew Nacin
aa08fb55ce User Query: Don't blindly re-append new meta queries for capabilities. 
fixes #21119.


git-svn-id: https://develop.svn.wordpress.org/trunk@28087 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 19:03:56 +00:00
Andrew Nacin
9defa138a4 Custom Headers: Allow for longer strings. 
props ehg.
see #27755.


git-svn-id: https://develop.svn.wordpress.org/trunk@28086 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 18:39:46 +00:00
Andrew Ozz
17a90fff8b TinyMCE wpViews: 
- Prevent undo steps from being added when the body of a wpview changes.
- Add unbind() to handle cleanup on DOM rebuilding in TinyMCE.
- Ensure that MediaElement's cleanup routine is run on every player in all instances of the editor.
- Initialize the players after some delay to ensure CSS is loaded.
Props gcorne and wonderboymusic, fixes #27389

git-svn-id: https://develop.svn.wordpress.org/trunk@28084 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:45:48 +00:00
Drew Jaynes (DrewAPicture)
b5612f8b80 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869


git-svn-id: https://develop.svn.wordpress.org/trunk@28083 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-12 00:00:32 +00:00
Andrew Nacin
8f0329b452 Translate custom header customize control strings. Remove final added before beta to see what breakage we might cause by refactoring this class. 
see #21785. fixes #27738.


git-svn-id: https://develop.svn.wordpress.org/trunk@28082 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 23:24:32 +00:00
Andrew Ozz
8aacd10a8c Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739 
git-svn-id: https://develop.svn.wordpress.org/trunk@28081 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 22:16:01 +00:00
Andrew Nacin
5dd9108e48 Editor: Ensure the link dialog does not display when styles are missing. 
props mattheu.
fixes #27605.


git-svn-id: https://develop.svn.wordpress.org/trunk@28071 602fd350-edb4-49c9-b593-d223f7449a82
 2014-04-11 03:08:23 +00:00