Commit Graph

17974 Commits

Author SHA1 Message Date
Sergey Biryukov
e9e2e6fc2c Bundled Themes: Add block-patterns tag to Twenty Nineteen and Twenty Twenty.
Follow-up to [49347], [49348].

See #51098, #51099.

git-svn-id: https://develop.svn.wordpress.org/trunk@49585 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:54:59 +00:00
Sergey Biryukov
cb60fe2323 Bundled Themes: Introduce block patterns for Twenty Seventeen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.

git-svn-id: https://develop.svn.wordpress.org/trunk@49584 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:20:21 +00:00
Sergey Biryukov
ddc94bc982 Bundled Themes: Introduce block patterns for Twenty Sixteen.
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.

git-svn-id: https://develop.svn.wordpress.org/trunk@49583 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 21:12:32 +00:00
Sergey Biryukov
17f7e5fc98 Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes.
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.

git-svn-id: https://develop.svn.wordpress.org/trunk@49582 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:40:13 +00:00
Helen Hou-Sandi
f517634e28 Upgrade/Install: Enable all core autoupdates for new installs.
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.


git-svn-id: https://develop.svn.wordpress.org/trunk@49581 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:19:46 +00:00
John Blackbourn
0ad0c55a28 General: Convert wp_array_get() to a "private" function and add tests.
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720


git-svn-id: https://develop.svn.wordpress.org/trunk@49580 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 20:18:08 +00:00
Sergey Biryukov
e0f55936d9 Editor: Update packages.
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.

git-svn-id: https://develop.svn.wordpress.org/trunk@49579 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:34:55 +00:00
Jonathan Desrosiers
4b10e110e0 Twenty Twenty-One: Use consistent casing in strings.
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `’`, which is also preferred per the Internationalization guidelines.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49578 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 19:28:35 +00:00
Jonathan Desrosiers
2d2e1dd4ae Twenty Twenty-One: Convert inline ESLint comments to JSHint.
WordPress Core currently uses JSHint instead of ESlint.

See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49575 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:46:44 +00:00
Jonathan Desrosiers
db3ce8f32d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.

git-svn-id: https://develop.svn.wordpress.org/trunk@49574 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:34:44 +00:00
Timothy Jacobs
1f07e76f46 App Passwords: MOAR accessibility improvements.
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.

Props alexstine, SergeyBiryukov.
Fixes #51580.


git-svn-id: https://develop.svn.wordpress.org/trunk@49573 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 18:12:14 +00:00
Sergey Biryukov
5f5c04d46b Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8.
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.

git-svn-id: https://develop.svn.wordpress.org/trunk@49572 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 17:53:41 +00:00
Anthony Burchell
d70214528e Media: Allow users to switch from media grid to list mode in media library.
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.


git-svn-id: https://develop.svn.wordpress.org/trunk@49568 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 15:44:58 +00:00
Anthony Burchell
4afa79feed Media: Improve count in Media Library pagination.
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.

Props donsony, karmatosed, desrosj, mista-flo, justinahinon.

Fixes #39968.


git-svn-id: https://develop.svn.wordpress.org/trunk@49567 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 15:38:32 +00:00
Dominik Schilling
4006c07417 I18N: Revert [49236] for now to investigate alternative implementations.
See #39210, #51678, #26511.

git-svn-id: https://develop.svn.wordpress.org/trunk@49566 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:41:19 +00:00
Sergey Biryukov
e8e031d2dd Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later.
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.

git-svn-id: https://develop.svn.wordpress.org/trunk@49565 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 14:34:33 +00:00
Sergey Biryukov
ea136a3af6 Coding Standards: Pass an empty string instead of null as the $replacement parameter to _deprecated_file().
Follow-up to [48327].

See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49564 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 11:15:49 +00:00
Peter Wilson
8b2aa594e3 Canonical: Prevent ID enumeration of private post slugs.
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.

Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272.



git-svn-id: https://develop.svn.wordpress.org/trunk@49563 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-12 04:14:44 +00:00
Sergey Biryukov
fc29c9e623 I18N: Add trailing punctuation to some translator comments.
Follow-up to [49549].

See #51580.

git-svn-id: https://develop.svn.wordpress.org/trunk@49562 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-11 10:39:52 +00:00
Sergey Biryukov
98e774ee2e Docs: Clarify sprintf() usage for the before_widget argument of register_sidebar().
Follow-up to [49203], [49560].

See #19709.

git-svn-id: https://develop.svn.wordpress.org/trunk@49561 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-11 10:37:33 +00:00
Helen Hou-Sandi
9a14f55ace Widgets: Do not use wrapping container in the admin.
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.


git-svn-id: https://develop.svn.wordpress.org/trunk@49560 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:38:59 +00:00
Helen Hou-Sandi
2a7d1e2394 Editor: Display short description from block directory in results.
Props dd32, ryelle.
Fixes #51212.


git-svn-id: https://develop.svn.wordpress.org/trunk@49559 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 20:24:38 +00:00
Sergey Biryukov
bde89301fd Help/About: Add Site Health Status dashboard widget to the Help → Content tab.
Reorder the items in the help tab to align with their default position on the Dashboard screen.

Follow-up to [47063], [47300].

Props nlpro.
Fixes #51745.

git-svn-id: https://develop.svn.wordpress.org/trunk@49558 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 19:03:12 +00:00
Sergey Biryukov
4a5c2857da TinyMCE: Update to 4.9.11.
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt

A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11

See #51051.

git-svn-id: https://develop.svn.wordpress.org/trunk@49557 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-10 10:42:04 +00:00
Anthony Burchell
3d583b8c67 Media: Removes duplicate alignment fix for browser uploader.
See #41648


git-svn-id: https://develop.svn.wordpress.org/trunk@49555 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 23:41:01 +00:00
Anthony Burchell
98a0e0eeed Media: Adjusts alignment of file name text in browser uploader.
Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers.

Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine.
Fixes #41648


git-svn-id: https://develop.svn.wordpress.org/trunk@49553 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 23:32:21 +00:00
Helen Hou-Sandi
6411c0953c Feeds: Don't treat media URLs with fragments as unique for enclosures.
Props archduck, dshanske.
Fixes #47421.


git-svn-id: https://develop.svn.wordpress.org/trunk@49552 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 20:26:18 +00:00
Anthony Burchell
907936209a Media: Adjust box-sizing for audio players.
Fix cropped container around playhead time in audio player.

Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov, 
Fixes #51685


git-svn-id: https://develop.svn.wordpress.org/trunk@49550 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 19:32:16 +00:00
Timothy Jacobs
d519284b5c App Passwords: Further accessibility improvements.
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.

Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes #51580.


git-svn-id: https://develop.svn.wordpress.org/trunk@49549 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 18:03:57 +00:00
Sergey Biryukov
2e01c76841 Coding Standards: Use consistent formatting for error messages in WP_Image_Editor_Imagick::write_image() and ::strip_meta().
See #50767.

git-svn-id: https://develop.svn.wordpress.org/trunk@49546 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:33:51 +00:00
John Blackbourn
8e25b92b63 Docs: Docblock corrections relating to WP_Post objects.
See #51373, #50768


git-svn-id: https://develop.svn.wordpress.org/trunk@49544 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 15:13:56 +00:00
John Blackbourn
e4f47125ab Media: Restore the ability of WP_Image_Editor_Imagick->save() to create a missing directory when needed.
Props eemitch, mikeschroder, hellofromTonya, p00ya, johnbillion

Fixes #51665


git-svn-id: https://develop.svn.wordpress.org/trunk@49542 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 13:16:54 +00:00
Sergey Biryukov
6b76c5222d I18N: Merge duplicate "Column" strings, remove unnecessary context.
Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259.

git-svn-id: https://develop.svn.wordpress.org/trunk@49541 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 11:15:06 +00:00
Sergey Biryukov
52f6f7b64f Coding Standards: Adjust formatting in WP_Block::render() for better readability.
Follow-up to [49310], [49539].

See #51606.

git-svn-id: https://develop.svn.wordpress.org/trunk@49540 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 10:59:06 +00:00
Sergey Biryukov
aac637dcdc Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.
Standardize on "Go to..." as a more appropriate option for most cases.

Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235.

git-svn-id: https://develop.svn.wordpress.org/trunk@49539 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-09 10:51:52 +00:00
Sergey Biryukov
31831c74d9 Networks and Sites: Assign the array of site or network data returned from filters to the respective class property:
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.

This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.

This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.

Follow-up to [46086], [48990].

Props yakimun, spacedmonkey.
Fixes #51333.

git-svn-id: https://develop.svn.wordpress.org/trunk@49538 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-08 11:45:36 +00:00
Sergey Biryukov
8f86eb9550 Site Health: Validate the test result data format in JS before using it.
This will discard any invalid responses instead of causing fatal errors.

It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.

Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes #50145.

git-svn-id: https://develop.svn.wordpress.org/trunk@49537 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-08 09:50:07 +00:00
Sergey Biryukov
0ecd258cf1 REST API: Use _n() in some error messages for proper plural forms support.
Follow-up to [47923], [49053].

Props audrasjb, tobifjellner, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51727.

git-svn-id: https://develop.svn.wordpress.org/trunk@49536 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-07 21:57:54 +00:00
Timothy Jacobs
a104c26283 App Passwords: Bump database version to flush rewrite rules.
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.

Fixes #51723.


git-svn-id: https://develop.svn.wordpress.org/trunk@49534 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 22:13:41 +00:00
Sergey Biryukov
da1763cf5b Docs: Add a @see reference to esc_url() from esc_url_raw().
Follow-up to [49512].

See #50585.

git-svn-id: https://develop.svn.wordpress.org/trunk@49513 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 14:14:50 +00:00
Sergey Biryukov
73d785a307 Docs: Improve return value description for esc_url().
Add a reference to `esc_url()` from `esc_url_raw()` return value description.

Props stevenlinx, audrasjb, helen.
Fixes #50585.

git-svn-id: https://develop.svn.wordpress.org/trunk@49512 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 14:01:06 +00:00
Sergey Biryukov
c95968a640 Bundled Themes: Correct list block alignment in editor styles.
Additionally:
* Indent nested lists in list and category blocks.
* Match ordered and unordered indentation for the classic block's lists.

This applies to:
* Twenty Ten
* Twenty Eleven
* Twenty Thirteen
* Twenty Fourteen
* Twenty Fifteen
* Twenty Sixteen
* Twenty Seventeen

Props sabernhardt, amolv, kjellr, audrasjb, francina.
Fixes #51157.

git-svn-id: https://develop.svn.wordpress.org/trunk@49511 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 11:51:12 +00:00
Sergey Biryukov
1e06d3511d Twenty Twenty: Correctly indent nested unordered lists in RTL editor styles.
Props sabernhardt.
Fixes #51574.

git-svn-id: https://develop.svn.wordpress.org/trunk@49510 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-06 11:36:14 +00:00
Sergey Biryukov
b4a488b650 Docs: Fix typo in a comment in Walker::display_element().
Props david.binda, sabernhardt.
Fixes #51713.

git-svn-id: https://develop.svn.wordpress.org/trunk@49509 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 18:44:48 +00:00
Sergey Biryukov
31af0afd4f Twenty Thirteen: Correct alignment of blocks inside a full-width or wide-width group block.
Props sabernhardt.
Fixes #51440.

git-svn-id: https://develop.svn.wordpress.org/trunk@49508 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 15:03:41 +00:00
Sergey Biryukov
691408de7f Twenty Twenty: Correct heading blocks alignment in editor styles.
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.

Props sabernhardt, Lumne.
Fixes #51148.

git-svn-id: https://develop.svn.wordpress.org/trunk@49507 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 15:00:18 +00:00
Sergey Biryukov
33111495b2 Docs: Improve documentation for WP_Query::is_archive() per the documentation standards.
Follow-up to [49504].

See #50545.

git-svn-id: https://develop.svn.wordpress.org/trunk@49506 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 09:42:49 +00:00
Sergey Biryukov
e38410c2fd Docs: Consistently place @see tags after @since in WP_Query methods, per the documentation standards.
See #50768.

git-svn-id: https://develop.svn.wordpress.org/trunk@49505 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-05 09:40:38 +00:00
Helen Hou-Sandi
7a16c4d580 Improve documentation for is_archive().
Props stevenlinx.
Fixes #50545.


git-svn-id: https://develop.svn.wordpress.org/trunk@49504 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 17:01:28 +00:00
Sergey Biryukov
da97d6779a Docs: Change the @since entry for template and template_lock post type arguments to 5.0.0.
These arguments were introduced with the initial block editor, but not documented previously.

Follow-up to [49495].

Props TimothyBlynJacobs.
See #46261.

git-svn-id: https://develop.svn.wordpress.org/trunk@49496 602fd350-edb4-49c9-b593-d223f7449a82
2020-11-04 02:45:26 +00:00