Commit Graph

  • 97ea98f145 Press This: don't check for already-hoisted global in press-this.php. Scott Taylor 2016-08-31 06:28:19 +00:00
  • 2748d489f0 Press This: in wp_ajax_press_this_save_post() and wp_ajax_press_this_add_category(), don't check for a global instance. WP_Press_This is a Controller, but not really a Singleton. This also keeps it from being a pluggable class, which it is right now. Scott Taylor 2016-08-31 06:24:57 +00:00
  • f9feaf1778 Customize: Improve handling of active state for dynamically-created controls/sections/panels. Weston Ruter 2016-08-31 06:20:33 +00:00
  • 9851ab5ded Query: in wp_old_slug_redirect(), use get_query_var() instead of importing and touching the global $wp_query directly. wonderboymusic 2016-08-31 06:20:03 +00:00
  • 988752b138 Press This: in get_shortcut_link(), just check a class constant on WP_Press_This instead of instantiating the object and reading an instance prop. wonderboymusic 2016-08-31 06:07:01 +00:00
  • 1825eff382 General: use get_bloginfo( 'version' ) instead of global $wp_version in several locations - excluding those locations which reload version.php mid-flight. Scott Taylor 2016-08-31 05:48:49 +00:00
  • 2078dda129 Multisite: use get_current_site() instead of $GLOBALS['current_site'] (stop yelling!) in a few remaining spots. Scott Taylor 2016-08-31 05:03:37 +00:00
  • 3605bd7633 Multisite: use get_current_blog_id() where applicable, in lieu of plucking the $blog_id global from outer space. Scott Taylor 2016-08-31 04:55:01 +00:00
  • 84c2742175 HTTP API: Revert changes to wp_parse_url() while PHP 5.2 errors are investigated. John Blackbourn 2016-08-31 00:23:26 +00:00
  • 6d894b4274 List Tables: AJAX actions for List Tables do not need to declare global $wp_list_table. List tables on admin screens are in global scope, and they contain hooks that don't pass the the list table as context, hence using globals there so that functions can import them. That problem does not exist in the AJAX actions, which are virtually impossible to hook into as is. Scott Taylor 2016-08-30 20:06:30 +00:00
  • 7ca480cc4e OEmbed: add unit tests. @group external-oembed is not run by default. Scott Taylor 2016-08-30 18:54:53 +00:00
  • 7734c6ac24 HTTP API: Separate the test for wp_parse_url() with -1 as its component into a separate test, so the remaining tests can use strict type checking. This helps avoid gotches with the potentially empty values (ie. null) that we're testing for. John Blackbourn 2016-08-30 18:30:51 +00:00
  • 8a6568945a HTTP API: The tests for wp_parse_url() can't be strict on type because this causes the tests to fail on PHP 5.2 which, bizarrely, returns the results of parse_url() (when called with a $component parameter) in a different order to later PHP versions. John Blackbourn 2016-08-30 17:48:06 +00:00
  • 1135308324 Posts, Post Types: Introduce a missing private query var that should have been introduced as part of #15459. John Blackbourn 2016-08-30 17:39:38 +00:00
  • ba5803c16e HTTP API: Prevent a fatal error on PHP < 5.4.7 due to changes introduced in [38449]. John Blackbourn 2016-08-30 17:15:54 +00:00
  • 48f389015e HTTP API: Add a $component parameter to wp_parse_url() to give it parity with PHP's parse_url() function. John Blackbourn 2016-08-30 16:35:33 +00:00
  • dd8591044a Accessibility: Hide the "No activity yet" smiley from assistive technologies. Andrea Fercia 2016-08-30 16:13:31 +00:00
  • 19b838af8b Script Loader: Properly adjust tests missed in [38443]. Pascal Birchler 2016-08-30 14:50:14 +00:00
  • 2fc4e48d07 Comments: Don't do direct SQL query when fetching decendants. Boone Gorges 2016-08-30 14:48:00 +00:00
  • f80068e75b Tests: Require Basic_Object and Basic_Subclass files earlier in call stack. Boone Gorges 2016-08-30 14:32:04 +00:00
  • caf0e90b30 Tests: Add docblocks for Basic_Object and Basic_Subclass classes. Boone Gorges 2016-08-30 14:31:56 +00:00
  • bf41a5dc23 Script Loader: Close the <link> tag in wp_resource_hints(). Sergey Biryukov 2016-08-30 11:19:13 +00:00
  • 7fc579eec9 Database: Don't force an unsupported character set that previously would've silently failed. Gary Pendergast 2016-08-30 07:37:59 +00:00
  • fd7979ad63 Database: Ensure that variables are defined correctly. Gary Pendergast 2016-08-30 07:13:31 +00:00
  • 003616dbd9 i18n: after r38364, check that global $wp_locale is an instance of WP_Locale before calling ->is_rtle() in is_rtl(). Scott Taylor 2016-08-30 05:56:13 +00:00
  • 53016dd3aa Remove unnecessary uniqueness check in get_attachment_taxonomies(). Boone Gorges 2016-08-30 03:06:06 +00:00
  • 7105787ced Customize: Allow users to more seamlessly create page-based nav menus during customization. Weston Ruter 2016-08-29 22:58:32 +00:00
  • 2936068f96 Accessibility: Improve the file upload inputs styling. Andrea Fercia 2016-08-29 21:07:31 +00:00
  • 88de856e57 Themes: Correct the type for the $name parameter of the get_header, get_footer, get_sidebar, and get_template_part_{$slug} hooks. John Blackbourn 2016-08-29 20:41:42 +00:00
  • 142fefb269 Post Thumbnails: Prevent post thumbnail previews from spilling into other images. Joe McGill 2016-08-29 12:24:09 +00:00
  • 6b23bbb92b Comments: Add support for all HTTP protocol versions when returning a 405 from wp-comments-post.php. John Blackbourn 2016-08-29 11:59:45 +00:00
  • 9d70a4495d Bootstrap: Check that ini_get_all() exists before calling it, allows us to work around hosts who disable the function for "security purposes". Dion Hulse 2016-08-29 02:58:25 +00:00
  • e916b9e14c HTTP: Accept non-string values in cookies, fixing a regression since 4.5. Dion Hulse 2016-08-29 02:41:56 +00:00
  • 7f2a81061a HTTP: Handle an edgecase within the URI parsing library included in Requests, where if a double slash exists at the start of the path the URL is passed to cURL malformed. Dion Hulse 2016-08-29 02:32:48 +00:00
  • 3b723b31ee Themes: Correct the list of possible values for the dynamic portion of the {$type}_template_hierarchy and {$type}_template filters. John Blackbourn 2016-08-28 23:56:04 +00:00
  • 92802bfd23 TinyMCE: change the default font for the vi locale to the same stack as he_IL. Andrew Ozz 2016-08-28 18:51:44 +00:00
  • 22ff75ac5e Editor: fix jumpiness on pressing backspace and delete in the Text editor. Andrew Ozz 2016-08-28 18:40:00 +00:00
  • 99bc5e7fb6 Editor: Use Beacon API over sync request Ella Iseulde Van Dorpe 2016-08-28 18:28:52 +00:00
  • 16bb82eb76 I18N: Correct various instances of incorrect usage of esc_attr_e(). John Blackbourn 2016-08-28 18:05:02 +00:00
  • 9033b02e43 Upgrade/Install: Don't display PHP errors during installation. John Blackbourn 2016-08-28 17:49:05 +00:00
  • da865e68b7 Formatting: Add a parameter to wp_send_json_error(), wp_send_json_success(), and wp_send_json() for specifying the HTTP response code. John Blackbourn 2016-08-28 17:41:25 +00:00
  • 289581e280 Security: Return a 403 instead of a 200 HTTP status when check_ajax_referer() fails. John Blackbourn 2016-08-28 17:30:29 +00:00
  • a03376e798 Security: Trigger a _doing_it_wrong() when check_ajax_referer() is called without its first parameter. This brings it inline with check_admin_referer(). John Blackbourn 2016-08-28 17:14:52 +00:00
  • c786774d21 Themes: Introduce tests for the theme template hierarchy. John Blackbourn 2016-08-28 16:18:51 +00:00
  • 6ab9dc2dba Themes: Update filter names in the inline documentation for the get_*_template() functions. John Blackbourn 2016-08-28 16:14:53 +00:00
  • 58956ecf2d Permalinks: Correct an invalid peramstructure tag in a test. John Blackbourn 2016-08-28 12:52:23 +00:00
  • 9701c29b90 Bootstrap: Fix failing external HTTP tests after [38411]. Pascal Birchler 2016-08-28 10:33:24 +00:00
  • 536d18babb Upgrade/Install: After [37687], fix the number of params passed to the upgrade hooks. swissspidy 2016-08-28 10:03:02 +00:00
  • 5f7706e5e8 Admin: allow WP_Screen to be checked via autoload in convert_to_screen(). Scott Taylor 2016-08-28 02:24:14 +00:00
  • 7bb34dc5d9 Query: Add and improve tests for query conditionals on the front page and home page. John Blackbourn 2016-08-28 02:01:53 +00:00
  • 20dae52ec9 Script Loader: autoload in load-{scripts|styles}.php. Scott Taylor 2016-08-28 00:06:45 +00:00
  • 4225e71a6b Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399. Scott Taylor 2016-08-27 22:31:11 +00:00
  • 06b6097bca Bootstrap: run composer install after r38409. Scott Taylor 2016-08-27 19:08:18 +00:00
  • 7b0cd0ac85 Bootstrap: move composer.{json|lock} into src. Scott Taylor 2016-08-27 19:05:28 +00:00
  • 551fa31b5a Media: Add a $wp_error parameter to wp_insert_attachment() to give it parity with wp_insert_post(). John Blackbourn 2016-08-27 17:24:58 +00:00
  • f59a3b54c8 Build/Test tools: Ensure the Tests_Query_Conditionals tests set up the environment correctly before re-registering initial taxonomies. John Blackbourn 2016-08-27 17:02:54 +00:00
  • fccaf594c7 Users: Correct the documentation for the wp_dropdown_users_args filter description and its parameters. John Blackbourn 2016-08-27 16:53:08 +00:00
  • 417de45c08 Build/Test Tools: Add support for is_front_page() to assertQueryTrue() and assert that all the tested conditions are supported by the method. John Blackbourn 2016-08-27 15:27:35 +00:00
  • 7b275f6a07 i18n: Retire another remaining wp-includes/locale.php require, and instead load the required WP_Locale class directly. Dion Hulse 2016-08-27 15:12:18 +00:00
  • 52acaaad50 Themes: Remove failing tests introduced in [38390]. John Blackbourn 2016-08-27 14:52:56 +00:00
  • e353179ce5 Bootstrap: Revert [38399] as it's broken /build/ and subsequently core.svn.wordpress.org. Dion Hulse 2016-08-27 14:36:42 +00:00
  • 68175f94c3 After [38399], update the .gitignore file accordingly. Pascal Birchler 2016-08-27 11:28:11 +00:00
  • b8f88aa597 Unit tests: Enforce $args object in wp_nav_menu() & Walker_Nav_Menu. Peter Wilson 2016-08-27 11:27:17 +00:00
  • 388690382c Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader. Scott Taylor 2016-08-27 09:15:01 +00:00
  • 02319efa71 Unit Tests: Scott Taylor 2016-08-27 08:35:16 +00:00
  • f0af25bd80 Press This: the file for the WP_Press_This class should not produce side effects. Similar to what we did in r38355 for WP_Site_Icon, drop the instances of global instantiation for $wp_press_this via loading the file. The variable can be set inline when necessary. In most of those places, if the global is already set, the file does not load and stomp it currently. Scott Taylor 2016-08-27 06:06:50 +00:00
  • a8b98b7924 Customize: Circumvent the customizer attempting to preview links to static assets (such as uploaded images). Weston Ruter 2016-08-27 06:04:42 +00:00
  • 5d4485b184 Bootstrap: exclude more files from the autoloader.classmap in composer.json. Scott Taylor 2016-08-27 05:39:31 +00:00
  • 0da2aa2434 Bootstrap: add composer.lock and src/wp-vendor files. Nothing is using this code yet, just going through the motions. Ignore the files in src/wp-vendor/composer that will explode in PHP 5.2. Scott Taylor 2016-08-27 03:48:08 +00:00
  • 1c52ad1196 Bootstrap: run composer require xrstf/composer-php52 to get the updated suggested version. Change the vendor-dir to wp-vendor. Scott Taylor 2016-08-27 03:35:35 +00:00
  • c6731b76ac List Tables: move _WP_List_Table_Compat into its own file. Scott Taylor 2016-08-26 22:22:58 +00:00
  • 07fe41b23d Bootstrap: exclude some files from the Composer autoload setup via exclude-from-classmap. Scott Taylor 2016-08-26 22:21:00 +00:00
  • 8139765b1f Themes: Begin introducing unit tests for the expected theme template hierarchy. More to come. johnbillion 2016-08-26 22:19:16 +00:00
  • 0ff32a41b0 XML-RPC: break up class-IXR.php into individual class files. Scott Taylor 2016-08-26 22:07:14 +00:00
  • 55f5577813 Multisite: move get_current_site() to load.php so that it can be used in more places, instead of importing global $current_site. Scott Taylor 2016-08-26 21:34:36 +00:00
  • aa2fcba472 Roles: set a property, $db, on WP_Roles to reduce global imports. Scott Taylor 2016-08-26 21:15:22 +00:00
  • 3586ac294f Bootstrap: load option.php in wp-settings.php, not in functions.php. Scott Taylor 2016-08-26 21:10:30 +00:00
  • 9df1424d88 Themes: Make the template hierarchy for a given template type filterable. John Blackbourn 2016-08-26 21:02:08 +00:00
  • 39a145e0e1 Bootstrap: add a composer.json file to the project. No code relies on it (yet), and no vendor dir is checked in (yet). No autoloader is being used (yet). Taking this first step will hopefully encourage the perfectionists of our world to scrutinize each line. Scott Taylor 2016-08-26 20:59:54 +00:00
  • db0e1ed0af Unit Tests: after r38303, replace usage of global $_wp_additional_image_sizes with wp_get_additional_image_sizes(). Scott Taylor 2016-08-26 20:50:24 +00:00
  • e795f6da1d Build/Test Tools: Remove many unnecessary calls to rand_str() which can, in theory, fail at random. Static strings are much more appropriate. John Blackbourn 2016-08-26 20:21:30 +00:00
  • 6eaa56f3d4 Don't improperly cast IDs when fetching post, user, or term objects. Boone Gorges 2016-08-26 19:08:23 +00:00
  • 8b431f6859 FTP: ensure that there is only one class named ftp, which is what is expected in the loading of this arcane library. This ensures that an autoload generator, something along the lines of Composer, won't hiccup when it gets to these files. Scott Taylor 2016-08-26 18:46:17 +00:00
  • a581574b3a Upgrade/Install: wp-admin/includes/class-wp-upgrader-skins.php is unused, remove it. All of the same includes are loaded in class-wp-upgrader.php. Scott Taylor 2016-08-26 18:24:40 +00:00
  • 5e71c349af Role/Capability: Only users who can manage options should be able to trash/delete the page for posts or the front page, as they are the only users who can restore it or subsequently alter the "Front page displays" setting. John Blackbourn 2016-08-26 18:22:28 +00:00
  • f21f8c1076 Eliminate unnecessary variable in WP_Term_Query. Boone Gorges 2016-08-26 18:10:56 +00:00
  • d227752665 Load: move WP_MatchesMapRegex into its own file. Scott Taylor 2016-08-26 18:10:23 +00:00
  • c82c1b828b Script Loader: move _WP_Dependency into its own file. Scott Taylor 2016-08-26 18:05:29 +00:00
  • aad8b9805e Load: remove class-feed.php (There is no class named Feed or WP_Feed, it just loads other classes) and, instead, move the require calls to the only place they are ever included: inside fetch_feed(). This simplifies the include path. Scott Taylor 2016-08-26 17:52:05 +00:00
  • 223b79162c Load: remove session.php and, instead, move the 2 require calls to wp-settings.php. This simplifies the include path. wonderboymusic 2016-08-26 17:43:03 +00:00
  • ff0386b5c1 Use shared fixture in comment_exists() tests. Boone Gorges 2016-08-26 17:41:51 +00:00
  • 3a4811afb4 Load: load class-phpass.php (PasswordHash class) early in wp-settings.php, instead of require_once()'ing it in several places. Scott Taylor 2016-08-26 17:39:37 +00:00
  • dac30944ff Docs: Alignment after [38369]. John Blackbourn 2016-08-26 16:50:58 +00:00
  • 87c1b26ee7 Docs: Correct various documentation around object and stdClass types. John Blackbourn 2016-08-26 16:48:17 +00:00
  • bc38f711cf Embeds: Add a missing regex delimiter for Facebook URLs. John Blackbourn 2016-08-26 12:16:56 +00:00
  • cb0048a6c5 Embeds: Add support for embedding Facebook posts and videos via oEmbed. John Blackbourn 2016-08-26 11:56:47 +00:00
  • d9b3ae759a Embeds: Many of our oEmbed providers now default to HTTPS embeds, redirect to the HTTPS oEmbed endpoint, or have complete support for HTTPS even if they don't default to HTTPS. John Blackbourn 2016-08-26 11:24:38 +00:00
  • acc91a60e0 Embeds: Always use the HTTPS endpoint for YouTube embeds. The scheme parameter is no longer required as all YouTube assets now use HTTPS. John Blackbourn 2016-08-26 10:38:05 +00:00
  • 4de1595d47 i18n: move is_rtl() to l10n.php (which loads way earlier). Load WP_Locale file in wp-settings.php. Retire wp-includes/locale.php - it only loaded the class and the one function, is_rtl(). If someone loaded this file for fun somewhere else, it would be a fatal error. Scott Taylor 2016-08-26 10:19:26 +00:00
  • a048646021 Load: move is_wp_error() to load.php so that WP_Error is in a file by itself. Scott Taylor 2016-08-26 09:57:47 +00:00