Commit Graph

  • 1b292c965a Embed: wp-settings.php loads class-wp-embed.php, which currently produces side effects. Move the global instantiation to wp-settings.php. WP_Embed is then in a file by itself. Scott Taylor 2016-08-26 09:52:18 +00:00
  • 1ff3356d22 OEmbed: move _wp_oembed_get_object() to embed.php, where all of the other embed functions live. WP_oEmbed is then in a file by itself. Load class-oembed.php in wp-settings.php and remove extraneous include calls. Scott Taylor 2016-08-26 09:48:32 +00:00
  • 05cd65dd82 L10N: improve accuracy of docs. Scott Taylor 2016-08-26 09:37:30 +00:00
  • 8a667f3036 Formatting: for a performance boost in remove_accents(), convert chr() calls to string literals. Scott Taylor 2016-08-26 09:34:44 +00:00
  • 62fe5001ba Editor: improve word-count.js documentation. Scott Taylor 2016-08-26 09:24:34 +00:00
  • 9bb9ea8185 Cron: clarify descriptions for Cron API functions. Scott Taylor 2016-08-26 09:21:33 +00:00
  • b16dcd954d Query: collapse several of the is_* methods using __call(). Add @method annotations. Scott Taylor 2016-08-25 19:41:42 +00:00
  • a02d79cf73 Site Icon: There is no good reason for class-wp-site-icon.php to drop a global instance of itself whenever the file is loaded. The lone use of the global instance of WP_Site_Icon is in an AJAX action that provides virtually no way to override - the file is loaded immediately before the global is used. Scott Taylor 2016-08-25 19:08:38 +00:00
  • 9e9cc9d07a Feed: move 'WP_Feed_Cache', 'WP_Feed_Cache_Transient', WP_SimplePie_File and WP_SimplePie_Sanitize_KSES into their own files via svn cp. If we move forard with autoloading, class-feed.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem. class-feed.php is an interesting name: there is no Feed or WP_Feed class. Scott Taylor 2016-08-25 18:18:01 +00:00
  • 9c722d92cc Session: move WP_Session_Tokens and WP_User_Meta_Session_Tokens into their own files via svn cp. If we move forard with autoloading, session.php is useless. We could even remove it now, and just load these new files in wp-settings.php. That can be decided post-mortem. Scott Taylor 2016-08-25 17:43:41 +00:00
  • b71117fdc7 Diff: move WP_Text_Diff_Renderer_inline (behold that lowercase "i") and WP_Text_Diff_Renderer_Table into their own files via svn cp. Scott Taylor 2016-08-25 17:36:22 +00:00
  • 3638dd6716 Query: move WP_Query into its own file via svn cp. Scott Taylor 2016-08-25 17:19:47 +00:00
  • 66ac1f40ed Docs: Add a missing parenthesis in an example in the DocBlock for wp_redirect(). Drew Jaynes 2016-08-25 07:35:15 +00:00
  • 861bdc722f TinyMCE: fix toolbars alignment in RTL. Andrew Ozz 2016-08-25 01:19:24 +00:00
  • 8d490e9d83 Docs: Improve the docs for the_title() and make them more consistent with the_title_attribute(). Sergey Biryukov 2016-08-24 15:59:00 +00:00
  • 47e8c055ef Administration: Underline links in the admin footer for better accessibility. Sergey Biryukov 2016-08-24 15:42:13 +00:00
  • 80439d1c48 I18N: Add translator comments for strings in wp-includes/functions.wp-scripts.php. Sergey Biryukov 2016-08-23 23:52:31 +00:00
  • 5ae7139efa I18N: Add translator comments for strings in wp-includes/functions.php. Sergey Biryukov 2016-08-23 23:47:28 +00:00
  • 407f0aaa34 I18N: Add translator comments for strings in wp-includes/deprecated.php. Sergey Biryukov 2016-08-23 23:35:15 +00:00
  • 75c975c5d1 I18N: Add translator comments for strings in wp-includes/class-walker-comment.php. Sergey Biryukov 2016-08-23 23:32:15 +00:00
  • 364754b01b I18N: Add translator comments for strings in wp-includes/author-template.php. Sergey Biryukov 2016-08-23 23:17:32 +00:00
  • bcc0fc20b3 I18N: Add translator comments for strings in wp-includes/admin-bar.php. Sergey Biryukov 2016-08-23 23:04:33 +00:00
  • 5e1193272f Taxonomy: in get_terms(), do not assume that legacy args are being passed when the only params are top-level meta_* values. Add keys in WP_Term_Query::__construct(). Scott Taylor 2016-08-23 14:44:19 +00:00
  • 148b09a79e Query: use correct description in the docblock for $number in WP_Comment_Query, WP_Network_Query, and WP_Site_Query. Scott Taylor 2016-08-23 14:40:09 +00:00
  • da8597c76b Cache: in WP_Object_Cache, $cache_misses is public, but $cache_hits is private. They should both be public, because they're useful for debugging purposes. Scott Taylor 2016-08-23 14:37:31 +00:00
  • 3aee745492 AJAX: add a new function, wp_doing_ajax(), which can replace... (wait for it...) DOING_AJAX checks via the constant. Scott Taylor 2016-08-23 14:32:18 +00:00
  • b1de6df8b4 Media: remove function_exists() call for ini_get() in _load_image_to_edit_path(). Scott Taylor 2016-08-23 14:23:41 +00:00
  • c913fc4c23 WP Mail: If post-by-email functionality is disabled, wp-mail.php should return a 403 Forbidden status code instead if 500 Internal Server Error. Sergey Biryukov 2016-08-23 14:01:16 +00:00
  • 74b912705d Tests: Fix incorrect variable name from [38330]. Boone Gorges 2016-08-23 13:48:13 +00:00
  • b93e0739a9 Tests: Attachment create() method should match signature of other create() methods. Boone Gorges 2016-08-23 13:42:36 +00:00
  • 934ffcf5b1 I18N: Remove unnecessary context for two strings on "Add New User" screen. Sergey Biryukov 2016-08-23 12:53:54 +00:00
  • d96cb127ee TinyMCE: make sure the temporary id is removed when using the default image dialog and inserting an external image. Andrew Ozz 2016-08-23 04:42:58 +00:00
  • 8d48e9a685 I18N: Remove unnecessary context in wp_post_revision_title_expanded(). Sergey Biryukov 2016-08-23 01:45:04 +00:00
  • 862b5a554f I18N: Use a consistent context for "Add New" submenu strings in admin bar (Toolbar). Sergey Biryukov 2016-08-23 01:41:16 +00:00
  • afd7e3b16d I18N: Allow for WordPress Plugin/Theme Directory URLs to be localized. Sergey Biryukov 2016-08-23 01:18:53 +00:00
  • 3a35ca8bd6 I18N: Replace unnecessary context with translator comments in wp_post_revision_title() and wp_post_revision_title_expanded(). Sergey Biryukov 2016-08-23 00:34:31 +00:00
  • e408cbe86d I18N: Replace unnecessary context with a translator comment for %s Sites string in network_step1(). Sergey Biryukov 2016-08-23 00:16:43 +00:00
  • aca32f8771 I18N: Replace unnecessary context with a translator comment for %s KB string on Network Settings screen. Sergey Biryukov 2016-08-23 00:10:49 +00:00
  • 03e402b2ec Embeds: In get_oembed_endpoint_url(), avoid inadvertent stomping of the $format parameter passed to oembed_endpoint_url filter. Sergey Biryukov 2016-08-23 00:04:46 +00:00
  • f2a91f6157 I18N: Add translator comments for Edit Site: %s string in network admin. Sergey Biryukov 2016-08-22 23:52:56 +00:00
  • 653fe9aaa1 Users: after [38317], use a @property annotation, instead of a public field. Scott Taylor 2016-08-22 22:14:03 +00:00
  • e8ab847c74 Widgets: $option_name and $alt_option_name have been used as members ever since WP_Widget became an object in 2.8, but never declared. Scott Taylor 2016-08-22 21:50:44 +00:00
  • 459f3aa9a3 Users: $user_level has been publicly-accessed on instances of WP_User since version 2.0, but is has never been declared. Scott Taylor 2016-08-22 21:40:35 +00:00
  • 03aad23a01 Locale: declare the $month_genitive field on WP_Locale. Scott Taylor 2016-08-22 21:32:09 +00:00
  • 6f19452077 HTTP: in WP_HTTP_Response, the @param declarations for $status and $headers were swapped. Let us correct this. Scott Taylor 2016-08-22 21:27:02 +00:00
  • 670878cbaa Database: WP_Network, WP_Network_Query, and WP_Site_Query call wpdb::_escape(), thus requiring it to be public. It previously had no access modifier. _ at the beginning of a method, believe it or not, does not enforce visibility constraints. Scott Taylor 2016-08-22 21:09:03 +00:00
  • 6df9616ff6 Comments: in wp_handle_comment_submission(), $_wp_unfiltered_html_comment is passed as part of $comment_data, but is not used locally. Scott Taylor 2016-08-22 21:03:05 +00:00
  • d46de8b22b Taxonomy: remove unnecessary break in WP_Term::__get(). Scott Taylor 2016-08-22 20:59:35 +00:00
  • 46d7304d4a Nav Menus: remove unnecessary variable assignment in wp_nav_menu_item_post_type_meta_box(). Scott Taylor 2016-08-22 20:57:41 +00:00
  • 368e28243f REST API: remove unnecessary variable assignments in rest_handle_options_request(). Scott Taylor 2016-08-22 20:55:29 +00:00
  • 0dcc38a1ef Media: remove unnecessary variable assignment in gallery_shortcode(). Scott Taylor 2016-08-22 20:52:44 +00:00
  • 0774c039f4 General: remove variable set needlessly in wp_check_jsonp_callback(). Scott Taylor 2016-08-22 20:50:31 +00:00
  • b4fca4a558 Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation. Drew Jaynes 2016-08-22 18:24:48 +00:00
  • f9491ed8f6 Common CSS: Allow for .nav-tab-wrapper class to be used on elements other than h3 to increase flexibility for custom settings pages. Sergey Biryukov 2016-08-22 16:32:11 +00:00
  • 8673ec7459 Multisite: Fix copy/paste issue in id attribute for a dismissible message on Sites screen. Sergey Biryukov 2016-08-22 14:21:15 +00:00
  • 92d8f4afdc Login: retrieve_password() does not need to import 2 globals that it does not use. Scott Taylor 2016-08-22 04:47:19 +00:00
  • 45cd115bf6 Media: add a function, wp_get_additional_image_sizes(), that wraps the retrieval of the global $_wp_additional_image_sizes. Removes 6 global imports. Scott Taylor 2016-08-22 04:36:42 +00:00
  • e878e8156b Media: fix unit test after [38296]. Scott Taylor 2016-08-22 04:16:29 +00:00
  • 4c137392c8 Customize: Ensure a newly-added custom link nav menu item has the appropriate CSS class names. Weston Ruter 2016-08-22 03:11:51 +00:00
  • 99b6d24042 Docs: Update jsdoc in customize-nav-menus.js to remove references to Menu Customizer plugin. Weston Ruter 2016-08-22 00:55:42 +00:00
  • 3ffa745991 Docs: Update outdated phpdoc for WP_Customize_Manager::validate_setting_values() to reflect changes in [37942]. Weston Ruter 2016-08-22 00:40:15 +00:00
  • 2e111412f9 Comments: in WP_Comment_Query::fill_descendants(), continue if there is an empty array in the loop. Scott Taylor 2016-08-21 06:42:44 +00:00
  • f6fced867b Comments: in WP_Comment_Query::fill_descendants(), compute count() in the first for expression so that it does not run on each iteration. Scott Taylor 2016-08-21 06:24:18 +00:00
  • 081e51d94b Media: use wp_get_attachment_metadata() instead of get_post_meta() where appropriate. Scott Taylor 2016-08-21 06:14:37 +00:00
  • c593c6fa95 Media: wp_get_attachment_link() fails to output text for non-images if the attachment post doesn't have a title and $text (argument #5) was not passed to the func. In this case, use the filename. Scott Taylor 2016-08-20 23:44:07 +00:00
  • d911ef44dc Media: when calling pathinfo(), also pass a PATHINFO_* constant to avoid array notices for unset keys. Scott Taylor 2016-08-20 23:35:50 +00:00
  • a26f7f7d28 Media: Add some docs to media-gallery.js RIP. Scott Taylor 2016-08-20 22:58:34 +00:00
  • 29a5d46701 Allow attachment taxonomies to be fetched as objects. Boone Gorges 2016-08-20 17:34:13 +00:00
  • 773eb46bf8 Introduce tests for get_attachment_taxonomies(). Boone Gorges 2016-08-20 17:24:12 +00:00
  • 86a2c06f6f Introduce tests for get_object_taxonomies(). Boone Gorges 2016-08-20 17:00:56 +00:00
  • 4bf8693357 Docs: Correct usage examples for wpdb::prepare(), which should not be called statically. Sergey Biryukov 2016-08-20 13:16:33 +00:00
  • f05beeba8c Query: Non-scalar and negative values for 'p' should always result in a 404. Boone Gorges 2016-08-20 02:31:31 +00:00
  • 54b51f1a26 Mail: Don't set Sender field when setting From. Boone Gorges 2016-08-20 02:16:54 +00:00
  • ba9eda1a9b Tests: Move some utility classes to their own files. Boone Gorges 2016-08-19 15:44:37 +00:00
  • f3425a50ac Docs: Fix typo in load_plugin_textdomain() parameter description. Sergey Biryukov 2016-08-19 14:28:42 +00:00
  • 5fabc6b769 Add wordpress-importer tests demonstrating slashed data behavior. Boone Gorges 2016-08-19 13:26:04 +00:00
  • 6f44d8c2dd Bootstrap/Load: Include Plugin API via require_once Aaron Jorbin 2016-08-19 04:09:55 +00:00
  • 1774eb80e6 Fix jshint of Gruntfile.js Aaron Jorbin 2016-08-18 20:04:16 +00:00
  • b786d481a9 Query: use composition for $db in WP_Date_Query, removes need to import global $wpdb in multiple methods. Scott Taylor 2016-08-18 19:47:15 +00:00
  • bad7b66501 Query: use composition for $db in WP_Query, removes need to import global $wpdb in multiple methods. Scott Taylor 2016-08-18 19:38:18 +00:00
  • 8c68a5c354 Unit Tests: skip checking the value in Tests_User:test_user_properties for db. Casting to array is not the most elegant thing here, and various versions of PHP key protected/private fields differently when objects are cast. Scott Taylor 2016-08-18 19:37:23 +00:00
  • 83c7544ef8 In is_object_in_term(), return error object rather than caching it. Boone Gorges 2016-08-18 19:14:52 +00:00
  • e1590fff09 External Libraries: Update Minified version of jquery.masonry.js Aaron Jorbin 2016-08-18 18:54:41 +00:00
  • 4e55f2248b Query: add a protected field, $db, (composition, as it were) to WP_*_Query classes to hold the value for the database abstraction, instead of importing the global $wpdb into every method that uses it. Reduces the number of global imports by 32. Scott Taylor 2016-08-18 18:20:55 +00:00
  • 1e15f01687 Requests: Update to Requests master (fb5b517) which corrects a logic inversion in the cURL transport checks. Dion Hulse 2016-08-18 03:47:55 +00:00
  • 1bdd60ef65 Build/Test Tools: Ensure PHP 7.1 is tested on Travis. Aaron Jorbin 2016-08-17 20:45:07 +00:00
  • e784e65d68 Permalinks: Correct the documentation for the get_sample_permalink filter, and improve the documentation for the get_sample_permalink() function. John Blackbourn 2016-08-17 18:29:47 +00:00
  • a93c94c6b2 About Page: Add release video and move images to CDN. Dominik Schilling (ocean90) 2016-08-16 17:57:06 +00:00
  • dd92169bfe Post Thumbnails: Restore thumbnail support for media files. Dominik Schilling 2016-08-15 19:15:48 +00:00
  • 40c9dcfa80 External Libraries: Update Masonry shim to prevent error using isAnimated option Aaron Jorbin 2016-08-15 18:19:18 +00:00
  • e8f182885a About Page: Enhance responsive images. Dominik Schilling 2016-08-13 19:27:22 +00:00
  • a0aba9dc44 Script Loader: Fix protocol-relative URLs for the preconnect relation type. Dominik Schilling 2016-08-13 18:34:12 +00:00
  • 19a85950ad Docs: Add a period missed in an argument description in [38253] for #36338. Drew Jaynes 2016-08-13 17:43:42 +00:00
  • 77aa4a8b72 Docs: Add documentation for all arguments accepted by export_wp(). Drew Jaynes 2016-08-13 17:42:05 +00:00
  • 17afb9c704 Bootstrap/Load: Revert Plugin Global restoration around advance-cache.php. Aaron Jorbin 2016-08-13 15:59:03 +00:00
  • 363d8ad2a6 Users: Merge two duplicate strings introduced in [37940]. Sergey Biryukov 2016-08-12 14:11:58 +00:00
  • 97c4e332b5 About Page: Fix punctuation errors in two strings. Dominik Schilling 2016-08-11 20:50:38 +00:00
  • defc92a66e About Page: Third pass for 4.6. Dominik Schilling 2016-08-10 23:32:27 +00:00
  • 1ca2426e77 Upgrader: Rename class-wp-automatic-upgrader.php to class-wp-automatic-updater.php. Dominik Schilling 2016-08-10 19:50:18 +00:00
  • a0a6262f17 Update/Install error messages: do not escape from the template, escape the error message string before inserting it. Andrew Ozz 2016-08-10 19:02:09 +00:00