mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2026-10-04 06:37:06 +00:00
Boone Gorges
1f5147bf83
Hierarchical comment queries work by first fetching the IDs of top-level comments, and then filling the descendant tree one level at a time based on the top-level results. When top-level comment IDs are found in the cache, `WP_Comment_Query` does not generate the SQL used to fetch these comments. In this case, the `fill_descendants()` query does not have enough information to fill children. As a result, descendant comments were failing to be filled in cases where the top-level comments were found in the cache. This was a minor bug previously, because comment caches were not maintained between pageloads. Since comment caches are now persistent [37613], the problem becomes evident anywhere that a persistent object cache is in use. The solution is to cache parent-child relationships, so that when top-level comments are found in the cache, descendant comments should be found there as well. Fixes #36487. git-svn-id: https://develop.svn.wordpress.org/trunk@37625 602fd350-edb4-49c9-b593-d223f7449a82