mirror of
https://github.com/gosticks/wordpress-develop.git
synced 2025-10-16 12:05:38 +00:00
bf2f6f8104
The descendant query in `WP_Comment_Query::fill_descendants()` uses the clauses of the main `get_comment_ids()` query as a basis, discarding the `parent`, `parent__in`, and `parent__not_in` clauses. As implemented in WP 4.4 [34546], the WHERE clause was assembled in such a way that any modifications applied using the `comments_clauses` filter were not inherited by `fill_descendants()`. This resulted in descendant queries that did not always properly filter results, and sometimes contained syntax errors. The current changeset fixes the problem by using the post-filter WHERE clause as the basis for the `fill_descendants()` query. This change requires a new approach for eliminating the unneeded parent-related clauses: instead of eliminating values in an associative array, we must use regular expressions. Props boonebgorges, firebird75. Fixes #35192. git-svn-id: https://develop.svn.wordpress.org/trunk@36277 602fd350-edb4-49c9-b593-d223f7449a82 |
||
|---|---|---|
| src | ||
| tests | ||
| tools/i18n | ||
| .editorconfig | ||
| .gitignore | ||
| .jshintrc | ||
| .travis.yml | ||
| Gruntfile.js | ||
| package.json | ||
| phpunit.xml.dist | ||
| wp-cli.yml | ||
| wp-config-sample.php | ||
| wp-tests-config-sample.php | ||