vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-04-14 17:44:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Call uncalled function in d3-selection tests (#42592)

Browse Source 
typescript@next has better detection of boolean checks on uncalled
functions. This caught an error in d3-selection's tests.
This commit is contained in:
Nathan Shively-Sanders
2020-02-24 08:43:46 -08:00
committed by GitHub
parent 98974cc1f6
commit 58f3f0e713
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
types/d3-selection/d3-selection-tests.ts
View File

@@ -1208,37 +1208,37 @@ selTextAndCircle = text.join(enter => enter.append('circle').text(d => d.data));
selText = text.join(
'text',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
selText = text.join<SVGTextElement>(
'custom',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
selText = text.join(
enter => enter.append('text').text(d => d.data),
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
selTextAndCircle = text.join(
'circle',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
selTextAndCircle = text.join<SVGCircleElement>(
'custom',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
selTextAndCircle = text.join(
enter => enter.append('circle').text(d => d.data),
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.data).remove(),
);
@@ -1246,37 +1246,37 @@ selTextAndCircle = text.join(
selText = text.join<'text', OldDatum>(
'text',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => `Bye ${d.oldData}`).remove(),
);
selText = text.join<SVGTextElement, OldDatum>(
'custom',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => `Bye ${d.oldData}`).remove(),
);
selText = text.join<SVGTextElement, OldDatum>(
enter => enter.append('text').text(d => d.data),
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.oldData).remove(),
);
selTextAndCircle = text.join<'circle', OldDatum>(
'circle',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.oldData).remove(),
);
selTextAndCircle = text.join<SVGCircleElement, OldDatum>(
'circle',
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.oldData).remove(),
);
selTextAndCircle = text.join<SVGCircleElement, OldDatum>(
enter => enter.append('circle').text(d => d.data),
update => r ? undefined : update.text(d => d.data).attr('fill', 'gray'),
update => r() ? undefined : update.text(d => d.data).attr('fill', 'gray'),
exit => exit.text(d => d.oldData).remove(),
);