vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-10-04 06:47:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

@types/passport-http: fix unused template param #1 (#35083)

Browse Source 
* fix(passport-http): use unused template param

It looks like this was rigged up so the appropriate callback definition could be inferred, but one detail got missed.

* test(passport-http): add tests demonstrating passReqToCallback
This commit is contained in:
Ian Remmel
2019-05-06 11:22:27 -07:00
committed by Jesse Trinity
parent 980af53777
commit 64dcd8e53f
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
types/passport-http/index.d.ts
Vendored
+1 -1
View File
@@ -12,7 +12,7 @@ import express = require("express");
export interface BasicStrategyOptions<req extends boolean = boolean> {
realm?: string;
passReqToCallback?: boolean;
passReqToCallback?: req;
}
export interface DigestStrategyOptions {
types/passport-http/passport-http-tests.ts
+3
View File
@@ -25,6 +25,9 @@ function validateNonce(nonce: string) {
function validateParams(nonce: string, cnonce: string, nc: number, opaque: string) {
}
new http.BasicStrategy({passReqToCallback: false}, (username, password, done) => {});
new http.BasicStrategy({passReqToCallback: true}, (req, username, password, done) => {});
passport.use(new http.BasicStrategy((username, password, done) => {
User.findOne({
username,