vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-06-28 14:20:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[snapsvg] Make handler optional for un... methods (#27252)

Browse Source 
For `unclick` the handler argument was already marked as optional. As in snapsvg's [implementation of the `un...` methods](https://github.com/adobe-webplatform/Snap.svg/blob/master/src/mouse.js#L340) there is no difference in how the various events are handled, the handler should also be optional for the other event types. I tried this with `undblclick` in particular, and it works as expected (removes all `dblclick` events).
This commit is contained in:
Willem Sonke
2018-07-21 02:57:12 +02:00
committed by Wesley Wigham
parent 9fa7394da1
commit 9fa36689ab
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
types/snapsvg/index.d.ts vendored
View File

@@ -203,16 +203,16 @@ declare namespace Snap {
touchcancel(handler: (event: MouseEvent) => void, thisArg?: any): Snap.Element;
unclick(handler?: (event: MouseEvent) => void): Snap.Element;
undblclick(handler: (event: MouseEvent) => void): Snap.Element;
unmousedown(handler: (event: MouseEvent) => void): Snap.Element;
unmousemove(handler: (event: MouseEvent) => void): Snap.Element;
unmouseout(handler: (event: MouseEvent) => void): Snap.Element;
unmouseover(handler: (event: MouseEvent) => void): Snap.Element;
unmouseup(handler: (event: MouseEvent) => void): Snap.Element;
untouchstart(handler: (event: MouseEvent) => void): Snap.Element;
untouchmove(handler: (event: MouseEvent) => void): Snap.Element;
untouchend(handler: (event: MouseEvent) => void): Snap.Element;
untouchcancel(handler: (event: MouseEvent) => void): Snap.Element;
undblclick(handler?: (event: MouseEvent) => void): Snap.Element;
unmousedown(handler?: (event: MouseEvent) => void): Snap.Element;
unmousemove(handler?: (event: MouseEvent) => void): Snap.Element;
unmouseout(handler?: (event: MouseEvent) => void): Snap.Element;
unmouseover(handler?: (event: MouseEvent) => void): Snap.Element;
unmouseup(handler?: (event: MouseEvent) => void): Snap.Element;
untouchstart(handler?: (event: MouseEvent) => void): Snap.Element;
untouchmove(handler?: (event: MouseEvent) => void): Snap.Element;
untouchend(handler?: (event: MouseEvent) => void): Snap.Element;
untouchcancel(handler?: (event: MouseEvent) => void): Snap.Element;
hover(hoverInHandler: (event: MouseEvent) => void, hoverOutHandler: (event: MouseEvent) => void, thisArg?: any): Snap.Element;
hover(hoverInHandler: (event: MouseEvent) => void, hoverOutHandler: (event: MouseEvent) => void, inThisArg?: any, outThisArg?: any): Snap.Element;