vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-08-11 20:40:20 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make React's SyntheticEvent.currentTarget generic over T again (#10784)

Browse Source 
* Make SyntheticEvent.target generic over T again

This change was added in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/084926e23accedcbf700bf480e38abdeabcd971e but then reverted in https://github.com/DefinitelyTyped/DefinitelyTyped/commit/5607f54defce88bc52a0440288f434cafffdb5ce. The revert _looks_ like an accident to me, as it's a merge coming in from master vs. a purposeful change. Maybe it got accidentally stepped on in resolving a conflict?

If `target` should no longer be the intersection of `EventTarget` and `T`, then there's not much point to `SyntheticEvent` being generic over `T`.

* Make `currentTarget` generic over instead instead of `target`
This commit is contained in:
Josh Abernathy
2016-09-06 23:01:03 +09:00
committed by Masahiro Wakame
parent f80ef83201
commit a13fa7abf5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
react/index.d.ts
Vendored
+1 -1
View File
@@ -272,7 +272,7 @@ declare namespace React {
interface SyntheticEvent<T> {
bubbles: boolean;
currentTarget: EventTarget;
currentTarget: EventTarget & T;
cancelable: boolean;
defaultPrevented: boolean;
eventPhase: number;