vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-02-04 07:52:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Lowercase js-cookie same site cookie values (#39143)

Browse Source 
* Lowercase same site cookie values

This matches the documented usage at https://github.com/js-cookie/js-cookie/#samesite, and also is more consistent with other attribute values typically entered in lowercase (e.g. domain names and true/false values).

* Use lowercase value in test
This commit is contained in:
Theodore Brown 2019-10-16 11:15:47 -06:00 committed by Andrew Branch
parent f51857f054
commit cde2fbca9b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
types/js-cookie/index.d.ts vendored
View File

@ -39,7 +39,7 @@ declare namespace Cookies {
* providing some protection against cross-site request forgery
* attacks (CSRF)
*/
sameSite?: 'Strict' | 'Lax' | 'None';
sameSite?: 'strict' | 'lax' | 'none';
/**
* An attribute which will be serialized, conformably to RFC 6265

2
types/js-cookie/js-cookie-tests.ts
View File

@ -9,7 +9,7 @@ Cookies.set('name', 'value', { expires: 7, path: '', domain: '', secure: true })
Cookies.set('name', 'value', { secure: true });
Cookies.set('name', 'value', { domain: '' });
Cookies.set('name', 'value', { path: '' });
Cookies.set('name', 'value', { sameSite: 'Strict' });
Cookies.set('name', 'value', { sameSite: 'strict' });
Cookies.set('name', 'value', { custom: 'property' });
// $ExpectType string | undefined