Merge pull request #33045 from Flarna/node-spawnsync-error

[node] Make SpawnSyncReturns.error optional
This commit is contained in:
Jesse Trinity
2019-03-01 17:48:30 -08:00
committed by GitHub
4 changed files with 4 additions and 4 deletions

View File

@@ -8,7 +8,7 @@ pw.on('error', (err: Error) => {
console.log(err);
});
const r1: Error = spawn.sync('foo').error;
const r1: Error | undefined = spawn.sync('foo').error;
const r2: string[] = spawn.sync('foo').output;
const r3: Buffer = spawn.sync('foo').stdout;
const r4: Buffer = spawn.sync('foo').stderr;

View File

@@ -291,7 +291,7 @@ declare module "child_process" {
stderr: T;
status: number;
signal: string;
error: Error;
error?: Error;
}
function spawnSync(command: string): SpawnSyncReturns<Buffer>;
function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns<string>;

View File

@@ -293,7 +293,7 @@ declare module "child_process" {
stderr: T;
status: number;
signal: string;
error: Error;
error?: Error;
}
function spawnSync(command: string): SpawnSyncReturns<Buffer>;
function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns<string>;

View File

@@ -2292,7 +2292,7 @@ declare module "child_process" {
stderr: T;
status: number;
signal: string;
error: Error;
error?: Error;
}
export function spawnSync(command: string): SpawnSyncReturns<Buffer>;
export function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns<string>;