vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Modernization: Remove dynamic properties in Tests_File.

Browse Source 
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this case, as the `$badchars` property never changes, declaring this as a class constant is the sensible option.

As for the `$dir` property (which cannot be turned into a constant due to the function call), this is used in multiple tests, so making this property explicit makes sense.

Follow-up to [139/tests], [53557], [53558], [53850], [53851], [53852], [53853].

Props jrf.
See #56033.

git-svn-id: https://develop.svn.wordpress.org/trunk@53854 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov 2022-08-07 14:48:42 +00:00
parent 278081ed1d
commit 101e686f7a
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/phpunit/tests/file.php
View File

@ -5,12 +5,14 @@
*/
class Tests_File extends WP_UnitTestCase {
const BADCHARS = '"\'[]*&?$';
private $dir;
public function set_up() {
parent::set_up();
$this->dir = untrailingslashit( get_temp_dir() );
$this->badchars = '"\'[]*&?$';
}
/**
@ -137,7 +139,7 @@ class Tests_File extends WP_UnitTestCase {
public function test_unique_filename_is_sanitized() {
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' );
$filename = wp_unique_filename( $this->dir, $name . self::BADCHARS . '.txt' );
// Make sure the bad characters were all stripped out.
$this->assertSame( $name . '.txt', $filename );