vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2025-10-16 12:05:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
26,386 Commits 1 Branch 0 Tags 243 MiB
dfffa2cffd
Commit Graph

1731 Commits

Author SHA1 Message Date
Scott Taylor
25593e291c When queries are passed to WP_Tax_Query, the value for operator is assumed to be uppercase. This is an unnecessary constraint. In ->get_sql(), cast it using $operator = strtoupper( $query['operator'] ). 
Props clifgriffin.
Fixes #27557.


git-svn-id: https://develop.svn.wordpress.org/trunk@28618 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 17:52:25 +00:00
Helen Hou-Sandi
2e1c4959af Fix a jshint error introduced in [28607]. see #23560. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28617 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 14:24:20 +00:00
Helen Hou-Sandi
220a45a32d Don't use the box shadow focus styling for the admin menu or toolbar. see #28267. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28616 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 14:22:39 +00:00
Andrew Ozz
6418ba1696 Regex should be non-greedy, see #28389 
git-svn-id: https://develop.svn.wordpress.org/trunk@28615 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 07:55:17 +00:00
Andrew Ozz
8f5ea4bacd TinyMCE: fix problems with undo/redo after resizing an image several times. Fixes #28389. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28614 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 07:50:35 +00:00
Scott Taylor
8530693a51 If post__in or post_parent__in is passed to WP_Query as an empty array, nuke the query. Both vars are currently only checked for truthiness after which they are ignored. Setting these vars at all indicates explicit filtering being desired. 
Adds unit test.

Fixes #28099.


git-svn-id: https://develop.svn.wordpress.org/trunk@28613 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 06:03:15 +00:00
Scott Taylor
4d1e46231b When parsing the main query, if s is set to empty: ?s= and $this->is_main_query() && array_key_exists( 's', $this->query ) - kill the query instead of loading the homepage. This will load the search page with no results. 
Fixes #11330.



git-svn-id: https://develop.svn.wordpress.org/trunk@28612 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 05:47:35 +00:00
Andrew Nacin
6e269a7120 Append the date to $wp_version in the build output, for nightly packages. 
props azaozz.
fixes #26751.


git-svn-id: https://develop.svn.wordpress.org/trunk@28611 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 04:32:41 +00:00
Andrew Nacin
e317e5454a Force SSL on the frontend via canonical when the home URL uses the https scheme. 
fixes #27954.


git-svn-id: https://develop.svn.wordpress.org/trunk@28610 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 04:12:05 +00:00
Andrew Nacin
961459ee31 Forcing SSL logins now forces SSL for the entire admin, with no middle ground. 
fixes #10267.


git-svn-id: https://develop.svn.wordpress.org/trunk@28609 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 03:58:41 +00:00
Helen Hou-Sandi
b27a8697d6 At long last, improved keyboard accessibility for the media modal. 
props lessbloat, grahamarmfield, sharonaustin, bramd.
see #23560.


git-svn-id: https://develop.svn.wordpress.org/trunk@28607 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 03:38:31 +00:00
Andrew Ozz
139b5b3cb0 TinyMCE: update to 4.0.28. Also includes 43fff5b453. Part-props avryl for the patch on #27941, fixes #28391, #27941. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28606 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 00:58:11 +00:00
Scott Taylor
32893ac7ea Allow users to sort posts by type in WP_Query. 
Props DeBAAT.
Fixes #28214.


git-svn-id: https://develop.svn.wordpress.org/trunk@28605 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-29 00:23:45 +00:00
Dominik Schilling (ocean90)
0af37cccdb Pass $post->ID to get_comments_number filter. 
Also fixes indentation and a typo in corresponding filter docs.

see #26240.

git-svn-id: https://develop.svn.wordpress.org/trunk@28604 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:35:21 +00:00
Drew Jaynes (DrewAPicture)
d201ded99e Fix parameter description for the $post_id argument in get_comments_number() to note that it is optional. 
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28602 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 22:04:59 +00:00
Andrew Nacin
0c7edb2045 Revert [28579] and [28582]. see #21963. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28601 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 18:13:55 +00:00
Sergey Biryukov
2d420d52bb Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard. 
props ghost1227.
fixes #26754.

git-svn-id: https://develop.svn.wordpress.org/trunk@28599 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 13:41:23 +00:00
Sergey Biryukov
5a8b1cfac2 Fix SlideShare oEmbed regex. 
props kovshenin.
fixes #28380.

git-svn-id: https://develop.svn.wordpress.org/trunk@28597 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-28 13:31:22 +00:00
Scott Taylor
598e79479b RIP Viddler oEmbed support. 
More: https://gigaom.com/2014/02/07/viddler-gets-ready-to-delete-personal-videos/

See #28379.



git-svn-id: https://develop.svn.wordpress.org/trunk@28596 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 21:59:42 +00:00
Scott Taylor
d80969655c Update the Scribd oEmbed pattern to more actually represent which endpoints from the site are discoverable. 
See #28379.


git-svn-id: https://develop.svn.wordpress.org/trunk@28595 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 21:54:24 +00:00
Scott Taylor
0b209f55ee When parsing an [embed] shortcode into a TinyMCE view, don't attempt to append any returned <script>s to the editor's <head>. This affects only a few supported endpoints: Issuu and Twitter. 
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28594 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 19:59:47 +00:00
Scott Taylor
7eb0253744 For YouTube playlist oEmbed, we need keep BC for wp_oembed_remove_provider() by not changing the existing YouTube endpoint keys. So, rather than merging the rules, the playlist endpoints should be on their own line. 
Props kovshenin.

See #28125, [28552].


git-svn-id: https://develop.svn.wordpress.org/trunk@28593 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 18:42:30 +00:00
Sergey Biryukov
b8b933418a Pass anchor text to 'edit_post_link' and 'edit_comment_link' filters. 
props kwight.
fixes #28373.

git-svn-id: https://develop.svn.wordpress.org/trunk@28590 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 13:42:27 +00:00
Sergey Biryukov
a25a5de409 Update documentation for is_new_day(). 
props obenland.
fixes #28333.

git-svn-id: https://develop.svn.wordpress.org/trunk@28588 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 11:40:11 +00:00
Sergey Biryukov
6bca1ca960 Clean up wp_widget_rss_output(): 
* Fix appending [&hellip;] to $summary.
* Use wp_trim_words() instead of wp_html_excerpt().
* Trim $title before checking if it's empty. props UmeshSingla.
* Use correct escaping function for $title.

fixes #28356.

git-svn-id: https://develop.svn.wordpress.org/trunk@28586 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 11:07:32 +00:00
Sergey Biryukov
06bf55f809 Avoid a PHP notice in adjacent_image_link() if no images were found. 
props nabil_kadimi.
see #28361.

git-svn-id: https://develop.svn.wordpress.org/trunk@28584 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 10:54:45 +00:00
Scott Taylor
4dd4a32cde In wp_get_object_terms(), before returning terms (and before running them through the 'wp_get_object_terms' filter) - run them through $terms = array_values( array_unique( $terms, SORT_REGULAR ) ). 
There will be "dupes" when the function is called with `'fields' => 'all_with_object_id'`, but the objects will actually be unique due to the `object_id` addition, so they shouldn't be filtered out. 

Adds unit tests. All other unit tests pass.

Fixes #11003.


git-svn-id: https://develop.svn.wordpress.org/trunk@28583 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 03:28:05 +00:00
Scott Taylor
7f2cad1809 Fix some inline docs churn in wp_insert_post() after [28579]. 
Props kpdesign.
See #21963.



git-svn-id: https://develop.svn.wordpress.org/trunk@28582 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-27 00:23:21 +00:00
Scott Taylor
792fe23675 When adding a URL in the Insert from URL state in the media modal, attempt to show a preview of the content. Drop the unused width and height fields. 
This will probably be iterated upon.

Props helen, jtsternberg, wonderboymusic.
See #15490.


git-svn-id: https://develop.svn.wordpress.org/trunk@28581 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:56:27 +00:00
Scott Taylor
8567bba0bf Don't pass embeds through the_content() when trying to render MCE previews, leverage WP_Embed and do_shortcode() instead. 
Props kovshenin.
See #28195.



git-svn-id: https://develop.svn.wordpress.org/trunk@28580 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:42:08 +00:00
Scott Taylor
6cd28991e3 Combine wp_insert_attachment() and wp_insert_post(). wp_insert_attachment() becomes a wrapper. Update inline docs. 
Props wonderboymusic, DrewAPicture.
See #21963.


git-svn-id: https://develop.svn.wordpress.org/trunk@28579 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:19:03 +00:00
Scott Taylor
ef81c3fdba Add oEmbed support for Mixcloud. 
Props Jayjdk.
Fixes #27169.



git-svn-id: https://develop.svn.wordpress.org/trunk@28578 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 23:09:00 +00:00
Scott Taylor
5413bfc35a Allow the settings view for galleries to be disabled when instantiating wp.media.controller.GalleryEdit. 
Props nd987.
Fixes #23116.


git-svn-id: https://develop.svn.wordpress.org/trunk@28577 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-26 22:48:56 +00:00
Andrew Ozz
92f79f5bcd TinyMCE: fix saving the editor content on switching Visual -> Text, fixes #28353 
git-svn-id: https://develop.svn.wordpress.org/trunk@28576 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-25 22:46:06 +00:00
Sergey Biryukov
aa6d49590b Fix typo in [28574]. 
see #28360.

git-svn-id: https://develop.svn.wordpress.org/trunk@28575 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-25 16:11:26 +00:00
Sergey Biryukov
508c1c1ae7 Replace $in_same_cat with $in_same_term in adjacent post functions for consistency. 
props ixkaito.
fixes #28360.

git-svn-id: https://develop.svn.wordpress.org/trunk@28574 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-25 16:09:07 +00:00
Sergey Biryukov
95e42909a9 Suggest get_current_site() as an alternative for get_current_site_name(). 
props jesin.
fixes #28346.

git-svn-id: https://develop.svn.wordpress.org/trunk@28573 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-25 14:31:16 +00:00
Sergey Biryukov
191705a964 Fix inversed logic in Walker_Category::start_el(). see [28359]. 
Correct 'use_desc_for_title' parameter description.

see #26557.

git-svn-id: https://develop.svn.wordpress.org/trunk@28572 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-24 13:41:11 +00:00
Sergey Biryukov
90a40a07a1 Pass $post to 'protected_title_format' and 'private_title_format' filters. 
props johnjamesjacoby, DrewAPicture.
fixes #23724.

git-svn-id: https://develop.svn.wordpress.org/trunk@28571 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-24 06:47:55 +00:00
Drew Jaynes (DrewAPicture)
cff4631f00 Add inline documentation for the option_none_value argument added to wp_dropdown_users|categories() in [28564]. 
Fixes #16625.


git-svn-id: https://develop.svn.wordpress.org/trunk@28570 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-24 05:38:06 +00:00
Drew Jaynes (DrewAPicture)
c4dc6180a5 Use three-digit x.x.x style version for @deprecated phpDoc tags. 
See #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28569 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-24 05:22:34 +00:00
Andrew Ozz
8d02021b7c TinyMCE: update to 4.0.26. Includes fixes for the 'paste' plugin (paste from Word/Excel, paste in WebKit/Blink), show/hide/isHidden in inline mode, drag/drop in tables and in Safari, and others. Fixes #28342, #28016, #28250 and #28067 
git-svn-id: https://develop.svn.wordpress.org/trunk@28568 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-24 01:43:16 +00:00
Andrew Ozz
cfb7408e2a wpView: fix selecting a view's text string in Safari, props gcorne, fixes #28088 
git-svn-id: https://develop.svn.wordpress.org/trunk@28565 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 20:55:53 +00:00
Scott Taylor
cd7d3f2ee8 wp_dropdown_pages() allows option_none_value to be passed. Add that arg to the $defaults for wp_dropdown_users() and wp_dropdown_categories() as well. 
Props solarissmoke. 
Fixes #16625.


git-svn-id: https://develop.svn.wordpress.org/trunk@28564 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 20:46:18 +00:00
Scott Taylor
70f735669a Replaces all uses of TEMPLATEPATH and STYLESHEETPATH in core with get_template_directory() and get_stylesheet_directory(). 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.


git-svn-id: https://develop.svn.wordpress.org/trunk@28563 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 20:11:08 +00:00
Scott Taylor
e2a124a911 When adding queries to tax_query: if the query's field is term_taxonomy_id, don't require taxonomy to be specified. In WP_Tax_Query::transform_query(), $query['taxonomy'] is never checked for the 'term_taxonomy_id' case because 'term_taxonomy_id' is the primary key being looked up. 
Adds unit tests.

Props helen.
Fixes #25284.



git-svn-id: https://develop.svn.wordpress.org/trunk@28562 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 19:58:52 +00:00
Scott Taylor
aa34ede226 Truly check for ! empty() instead of falsey '' when determining whether to add LIMIT clause to SQL in wp_get_archives(). 
Props jjeaton for the initial patch.
Fixes #27834.


git-svn-id: https://develop.svn.wordpress.org/trunk@28560 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 18:27:10 +00:00
Scott Taylor
3b060c1931 Read the src attribute for the [embed] shortcode if the shortcode's body is empty. 
These work:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]`
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"][/embed]`

If you do:
`[embed src="https://www.youtube.com/watch?v=ZqD-LPOWIT0"]http://any-other-url.com[/embed]`

... "http://any-other-url.com" will be the URL that is parsed.

Props kovshenin, aaroncampbell for making initial patches.
Fixes #24456.



git-svn-id: https://develop.svn.wordpress.org/trunk@28559 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 18:05:24 +00:00
Scott Taylor
1061a15eaf Allow get_comments_number() to officially accept $post or $post_id. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.


git-svn-id: https://develop.svn.wordpress.org/trunk@28558 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-23 17:43:03 +00:00
John Blackbourn
d07954ea60 Add CollegeHumor.com oEmbed support. Fixes #24497. Props johnzanussi. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28557 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 23:46:22 +00:00
Scott Taylor
e2240cd82f Viddler has had a new oEmbed endpoint for at least 10 months. Let us update to it. 
Props garhdez.
Fixes #24296.


git-svn-id: https://develop.svn.wordpress.org/trunk@28556 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 23:16:11 +00:00
Scott Taylor
2baa683984 Support Polldaddy's short URL format as a whitelisted oEmbed provider. 
Props donncha.
Fixes #28283.



git-svn-id: https://develop.svn.wordpress.org/trunk@28555 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 23:12:05 +00:00
Scott Taylor
47be64543c Add Issuu to list of whitelisted oEmbed providers. 
Props issuu.
Fixes #28312.



git-svn-id: https://develop.svn.wordpress.org/trunk@28554 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:49:10 +00:00
Scott Taylor
a4e1ec0b90 Fix parsing in wp_match_mime_types() to allow some mime-types with + in them to appear in the list of filter links shown above the list table on upload.php. 
Props _duck.
Fixes #20672.



git-svn-id: https://develop.svn.wordpress.org/trunk@28553 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:35:36 +00:00
Scott Taylor
1bc5e8329a Support oEmbed matching for YouTube playlist URLs. 
Fixes #28125.


git-svn-id: https://develop.svn.wordpress.org/trunk@28552 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 21:11:31 +00:00
Scott Taylor
285d74a283 In is_user_option_local(), $user_id is set conditionally, but never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28551 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:17:12 +00:00
Scott Taylor
7b3181e4ed $count is set in get_post_galleries() and never used, relic from PFUI RIP. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28550 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:13:01 +00:00
Scott Taylor
1d78b1dcc4 $gallery_div is set twice in gallery_shortcode() before it is used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28549 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:11:16 +00:00
Scott Taylor
ae9cf4a66d In get_attachment_icon_src(), $class is set in 2 conditions but never used. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28548 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:07:30 +00:00
Scott Taylor
363301f36e break is unreachable in WP_Theme::translate_header(). 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28547 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:04:16 +00:00
Scott Taylor
8b3d002486 In WP_Customize_Manager::register_controls(), $menu_locations is set and never used. 
git-svn-id: https://develop.svn.wordpress.org/trunk@28546 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 19:00:30 +00:00
Sergey Biryukov
5edb7a633f Remove unnecessary array_reverse() from wp_get_post_revisions(). 
WP_Query properly handles multiple 'orderby' values since [28541].

fixes #26042.

git-svn-id: https://develop.svn.wordpress.org/trunk@28543 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:50:11 +00:00
Scott Taylor
d6f1c4f904 Because PHP can be configured without --filter, it is not 100% safe to use filter_var(). This is problematic for casting "false" to false, as PHP always casts it to true. FILTER_VALIDATE_BOOLEAN fixes this, but it may not be available. 
Add a new function, `wp_validate_boolean()`, to replace `filter_var( $var, FILTER_VALIDATE_BOOLEAN )`.

Fixes #28170.



git-svn-id: https://develop.svn.wordpress.org/trunk@28542 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:33:34 +00:00
Scott Taylor
0baa73f2e4 Apply order to each passed value for orderby in WP_Query: 
* Since `orderby` in `WP_Query` can accept space-delimited sets, yet only one `order` value: when multiple values are passed (and `DESC` is the order), the default sort order `ASC` is being applied to all values before the last in the set.
* There is a unit test that sporadically fails since 3.6 in `tests/post/revision` due to multiple posts having the same `post_date` from being added so rapidly
* When ordering revisions in `wp_get_post_revisions()`, order by `post_date ID`
* Change the `order` value in `wp_get_post_revisions()` to `ASC`. This will produce SQL like: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID ASC`. Previously, this would have produced SQL like: `ORDER BY $wpdb->posts.post_date DESC`, and with the addition of ` ID`: `ORDER BY $wpdb->posts.post_date ASC, $wpdb->posts.ID DESC`. Clearly, wrong. The original SQL produced: `ORDER BY $wpdb->posts.post_date DESC`. As such, return the reversions in reverse order using `array_reverse()`. Not doing so would break "Preview Changes."
* Add unit tests to assert that all of this works.
* All existing unit tests pass with the change to ordering multiple `orderby`s in `WP_Query`.
* In the future, we should support independent `order` for each `orderby`, see #17065.

Props SergeyBiryukov, wonderboymusic.
Fixes #26042.


git-svn-id: https://develop.svn.wordpress.org/trunk@28541 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 18:18:11 +00:00
Sergey Biryukov
b0b85cc484 Use correct variable. see [28534], [28538]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28540 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:39:22 +00:00
Scott Taylor
312ef7b264 These functions import $wpdb but do not use it. 
See #27882.


git-svn-id: https://develop.svn.wordpress.org/trunk@28539 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:36:42 +00:00
Sergey Biryukov
ce653e1925 Remove redundant assignment. see [28379], [28534]. 
see #22400.

git-svn-id: https://develop.svn.wordpress.org/trunk@28538 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-22 17:34:34 +00:00
Scott Taylor
a0c78339fc Fix some bad UI recursion in wp_get_archives() caused by [28379]. It appears that $afterafter was appropriately named. 
See #22400.



git-svn-id: https://develop.svn.wordpress.org/trunk@28534 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-20 23:08:23 +00:00
Scott Taylor
6f4df85c8f WP_Query was only missing one access modifier. 
Add access modifier (`public`) to applicable class methods/members of `WP_Rewrite`. I am not brave enough to set some of the `var`s to `private` without more testing.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28533 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:40:08 +00:00
Scott Taylor
707c313333 WP_Date_Query was only missing one access modifier. 
Add access modifier (`public`) to all default widgets' class methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28532 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:29:42 +00:00
Scott Taylor
dc1ada20c7 Upgrade _WP_List_Table_Compat to PHP5-style constructor. 
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28531 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 17:19:09 +00:00
Scott Taylor
02eba613a5 Add access modifiers to WP_User_Query. 
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and
__call().

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28528 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 15:47:33 +00:00
Scott Taylor
3e054a2c7e Add public access modifier to methods/members of WP_Widget and WP_Widget_Factory. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28527 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 15:42:00 +00:00
Scott Taylor
02a28ec4e9 In wpdb, make some things explicitly public. Do not set anything to private. This would instantly blow up hyperdb in the wild. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28526 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 15:35:29 +00:00
Scott Taylor
1cbef26922 Add access modifiers to WP_Text_Diff_Renderer_Table that are compatible with its parent class. Some of the inline docs suggest access that, if implemented, would produce fatal errors. 
Add magic methods for BC: __get(), __set(), __isset(), __unset(), and __call().

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28525 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 15:22:45 +00:00
Scott Taylor
daecbc9659 Classes that have __set() also need __isset() and __unset(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28524 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:51:35 +00:00
Scott Taylor
bf54ad6054 Add missing access modifiers to methods in WP_Query. Add magic methods for __get(), __set(), __isset(), __unset(), and __call(). 
Add unit test for magic methods.

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28523 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:48:56 +00:00
Scott Taylor
5771dfbfa5 Add missing access modifiers to methods in WP_Meta_Query. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28522 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:34:01 +00:00
Scott Taylor
77c6420969 Some classes with __get() method also need __set(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28521 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:31:00 +00:00
Scott Taylor
e76545e011 Fix fatal error in unit test. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28520 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:24:06 +00:00
Scott Taylor
d398ea806c Add missing access modifiers to methods in WP_Comment_Query. Add a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28519 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:18:51 +00:00
Scott Taylor
ce917f0bc4 Add missing access modifiers to methods in WP_Scripts and WP_Styles. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28518 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:16:39 +00:00
Scott Taylor
bd478a0135 Add missing access modifiers to methods in WP_Dependencies and _WP_Dependency. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28517 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:13:24 +00:00
Scott Taylor
0e17651d7d Add missing access modifiers to methods in WP and WP_MatchesMapRegex. Add magic __call() and __get() methods to WP_MatchesMapRegex for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28516 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:11:34 +00:00
Scott Taylor
ea0e965af3 Add missing access modifiers to methods in wp_xmlrpc_server. Add a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28515 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 06:08:04 +00:00
Scott Taylor
f716ff94e4 Add missing access modifiers to methods/members in Walker and subclasses. Add a magic __get() method. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28514 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:59:07 +00:00
Scott Taylor
f297dcba9a Add missing access modifiers to methods/members in WP_Image_Editor_* classes. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28513 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:52:24 +00:00
Scott Taylor
9406ca3bb8 Add access modifiers to methods/members in WP_HTTP_IXR_Client. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28512 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:50:19 +00:00
Scott Taylor
0401ec1c9f Add access modifiers to methods/members in WP_Error. Add a magic __get() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28511 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:49:22 +00:00
Scott Taylor
26af443ade Add access modifiers to methods/members in WP_Embed. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28510 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:46:56 +00:00
Scott Taylor
8bb3b642ec Add missing access modifiers to methods/members in WP_Customize_*. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28509 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:44:49 +00:00
Scott Taylor
ddce296dd3 Add access modifier to methods/members in WP_Ajax_Response. Adds a magic __get() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28508 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:40:11 +00:00
Scott Taylor
4a5a7cb88a Add access modifier to methods/members in WP_oEmbed. Adds a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28507 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:36:38 +00:00
Scott Taylor
0d5768f0f4 Add access modifier to methods of HTTP classes. There are no new private or protected methods, so no need for __call(). 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28506 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:33:08 +00:00
Scott Taylor
8c2ccf6d7c Add access modifiers to methods/members in WP_Feed_Cache, WP_SimplePie_File, and WP_Feed_Cache_Transient. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28505 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:26:48 +00:00
Scott Taylor
1d13dc8a85 Add access modifiers to methods/members in Walker_Category and Walker_CategoryDropdown. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28504 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:22:38 +00:00
Scott Taylor
599dff5c3d Add access modifiers to methods/members in WP_Roles. Add a magic __call() method for BC. 
See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28503 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:19:36 +00:00
Scott Taylor
241d1a4d99 Add access modifiers to methods/members in WP_Object_Cache. Add a magic __get() method for BC. 
See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28502 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:15:20 +00:00
Scott Taylor
b185ac51b2 In wp_list_bookmarks(), $categorize should now be $r['categorize]. 
See #22400.


git-svn-id: https://develop.svn.wordpress.org/trunk@28501 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:10:45 +00:00
Scott Taylor
e43d2a73d8 Fix some hackificator odds and ends in wp-admin: 
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed

See #27881.


git-svn-id: https://develop.svn.wordpress.org/trunk@28500 602fd350-edb4-49c9-b593-d223f7449a82
 2014-05-19 05:03:44 +00:00